Uh oh!
There was an error while loading. Please reload this page.
fix(macos): prepare support for react-native-macos 0.66 - #704
Merged
Conversation
Tommy Nguyen (tido64)
requested review from
Saad Najmi (Saadnajmi), Lorenzo Sciandra (kelset) and Tom Underhill (tom-un)January 18, 2022 10:37
Tommy Nguyen (tido64)
requested review from
Araz Abishov (arazabishov) and Sam Mathias Weggersen (sweggersen)
as code ownersJanuary 18, 2022 10:37
| const VALID_TAGS = ["canary-macos", "canary-windows", "main", "nightly"]; | ||
| const REACT_NATIVE_VERSIONS = { | ||
| "canary-macos": "^0.64", | ||
| "canary-macos": "^0.66", |
Contributor
There was a problem hiding this comment.
just a simple question for me to learn - here you can put 0.66 already even if it's not out yet?
Contributor
There was a problem hiding this comment.
(as far as I can see, the canary macos on npm have the 0.0.0-hash format)
MemberAuthor
There was a problem hiding this comment.
This is for pointing at the correct version of react-native to install with react-native-macos. The latter doesn't specify which version to use because it is self-contained, but I think cli complains if it cannot find react-native.
Tommy Nguyen (tido64)
enabled auto-merge (squash)
January 18, 2022 12:02
Lorenzo Sciandra (kelset)
approved these changes
Jan 18, 2022
Merged
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make sure to call
__apply_Xcode_12_5_M1_post_install_workaroundif it is defined.Platforms affected
Test plan