Uh oh!
There was an error while loading. Please reload this page.
[0.74] Switch New Architecture templates to use prebuilt NuGets - #13621
Merged
Jon Thysell (jonthysell) merged 1 commit intoAug 27, 2024
Conversation
This PR backports #13338 to 0.74. ## Description This PR updates the `cpp-app` and `cpp-lib` new architecture templates to build against the pre-built `Microsoft.ReactNative` NuGet packages by default. ### Type of Change - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ### Why Building the `Microsoft.ReactNative` native code is very resource-intensive. Pre-building that code makes for much faster builds and greatly improved developer experience. This experience has been experimental and poorly support for Paper for some time now - for the new architecture projects we want using NuGets to be the primary experience from day one. Resolves#12639 ### What The `cpp-app` and `cpp-lib` new architecture templates now set up projects to consume the ("-Fabric" versions) of the pre-built `Microsoft.ReactNative` NuGet packages by default. The CI and PR builds have also been updated to make sure nugets for x64, x86, arm64 are built first and then consumed by the new project tests. To support working on RNW itself, the new projects made using "devMode" (i.e. by yarn linking with your local RNW repo) will still build against the source of that local RNW repo rather than the nugets. This PR also fixes the `--singleproc` flag for `run-windows`. Previously it didn't do anything on machines with high RAM, but now if you specify the flag it forces single processor builds as expected. ## Screenshots Building x64 Release Paper (build RNW from source):  Building x64 Release Fabric (use RNW Nugets):  ## Testing Verified new projects build and run using the pre-built nugets. ## Changelog Should this change be included in the release notes: _yes_ [0.74] Switch New Architecture templates to use prebuilt NuGets
Jon Thysell (jonthysell)
marked this pull request as ready for review
August 27, 2024 21:24
Marlene Cota (marlenecota)
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #13338 to 0.74.
Description
This PR updates the
cpp-appandcpp-libnew architecture templates to build against the pre-builtMicrosoft.ReactNativeNuGet packages by default.Type of Change
Why
Building the
Microsoft.ReactNativenative code is very resource-intensive. Pre-building that code makes for much faster builds and greatly improved developer experience. This experience has been experimental and poorly support for Paper for some time now - for the new architecture projects we want using NuGets to be the primary experience from day one.Resolves#12639
What
The
cpp-appandcpp-libnew architecture templates now set up projects to consume the ("-Fabric" versions) of the pre-builtMicrosoft.ReactNativeNuGet packages by default.The CI and PR builds have also been updated to make sure nugets for x64, x86, arm64 are built first and then consumed by the new project tests.
To support working on RNW itself, the new projects made using "devMode" (i.e. by yarn linking with your local RNW repo) will still build against the source of that local RNW repo rather than the nugets.
This PR also fixes the
--singleprocflag forrun-windows. Previously it didn't do anything on machines with high RAM, but now if you specify the flag it forces single processor builds as expected.Screenshots
Building x64 Release Paper (build RNW from source):
Building x64 Release Fabric (use RNW Nugets):
Testing
Verified new projects build and run using the pre-built nugets.
Changelog
Should this change be included in the release notes: yes
[0.74] Switch New Architecture templates to use prebuilt NuGets
Microsoft Reviewers: Open in CodeFlow