Skip to content

fix: resolve artifact path mismatch in perf-comment workflow - #15883

Merged
Abhijeet Jha (iamAbhi-916) merged 1 commit into
microsoft:mainfrom
iamAbhi-916:fix/perf-comment-artifact-paths
Mar 31, 2026
Merged

fix: resolve artifact path mismatch in perf-comment workflow#15883
Abhijeet Jha (iamAbhi-916) merged 1 commit into
microsoft:mainfrom
iamAbhi-916:fix/perf-comment-artifact-paths

Conversation

@iamAbhi-916

@iamAbhi-916Abhijeet Jha (iamAbhi-916) commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Description

resolve artifact path mismatch in perf-comment workflow

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

The perf-comment.yml workflow never posted PR comments because it looked for pr-number.txt and report.md at hardcoded flat paths (perf-results/pr-number.txt), but download-artifact@v4 preserves the nested directory structure from the upload, placing files at perf-results/packages/e2e-test-app-fabric/.perf-results/.

What

  • Replaced hardcoded file path checks with find to locate pr-number.txt and report.md regardless of artifact directory nesting
  • Passed the discovered report.md path as a step output to the PR comment posting step

Testing

Changelog

Should this change be included in the release notes: indicate: no

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916Abhijeet Jha (iamAbhi-916) added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Mar 31, 2026
@iamAbhi-916
Abhijeet Jha (iamAbhi-916) merged commit 855a194 into microsoft:mainMar 31, 2026
31 checks passed
Abhijeet Jha (iamAbhi-916) added a commit to iamAbhi-916/react-native-windows that referenced this pull request Apr 15, 2026
Abhijeet Jha (iamAbhi-916) added a commit to iamAbhi-916/react-native-windows that referenced this pull request Apr 15, 2026
Abhijeet Jha (iamAbhi-916) added a commit that referenced this pull request Apr 16, 2026
* [Fabric]: Performance Tests for React Native Windows (#15666)
* perf testing v1( view , text , textinput)
* Fixed spike testing by using median and other issues
* chore: gitignore perf-testing build output
* remove scripts/ as separate folder
* add component perf tests for Button, Image, ScrollView, Switch, Modal, ActivityIndicator, Pressable, TouchableOpacity, TouchableHighlight, FlatList, and SectionList
* Cleanup
* Change files
* lint fix and format
* cleanup
* fix pipeline issues with cachedAct!
* Save PR number to artifact for future report workflow
* remove tsconfig from tracking
* review comments
* update baselines
* lint:fix
* add statistical stability gates (Mann-Whitney U, CV, gate/track mode)
* add maxCV and mode to defaultConfig threshold
* Add 100x stress-gate scenarios to all 13 perf suites
* lint fix and format
* update yarn lock
* Bump version to 0.0.0-canary.1033
* Native perf benchmarking infra for Fabric components (#15772)
* add native perf benchmarking infrastructure for Fabric components
measures
rendering pipeline — JS reconciliation → Fabric → Yoga layout → Composition commit → frame
Missing Components: Button, Modal, Pressable, TouchableHighlight, TouchableOpacity, SectionList.
* Added all 6 missing components
* Change files
* updates baselines in release mode
* add winAppsdk and dev mode
* Change files
* use winget as installer
* use direct download from download.microsoft.com
* relax TouchableOpacity bulk threshold in JS test
* update snapshots
* update snapshots
* review comments and segregate native tests
* poll for valid perf JSON instead of single read to handle transient UIA failures
* nit
* lint:fix and format
* fix: use --msbuildprops instead of -- /p: for SDK version override
* fix: resolve artifact path mismatch in perf-comment workflow (#15883)
* fix: include hidden files in perf artifact upload to restore PR comments (#15893)
* fix: resolve artifact path mismatch in perf-comment workflow
* fix: include hidden files in perf artifact upload
* fix: auto-discover native perf results in compare report
* Do not create m_childrenContainer when using a custom visual to mount children into (#15877)
* Do not create m_childrenContainer when using a custom visual to mount children into
* Change files
* fix
* RELEASE: Releasing 10 package(s) (main) (#15885)
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
* Implement onClick (#15889)
* Implement onClick
* Change files
* RELEASE: Releasing 10 package(s) (main) (#15891)
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
* Fork ubroken module (#15892)
* fix: auto-discover native perf results in compare report
* Change files
* fix: capture live run metrics in PerfJsonReporter instead of re-reading baselines
* Change files
* fix: use temp files for cross-process live metrics
* lint fix
* make touchableOpacity less noisy
* Change files
* codegen build fix
* revert: undo codegen changes (schema version mismatch)
---------
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com>
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
Co-authored-by: Vladimir Morozov <vmorozov@microsoft.com>
* fix: respect track mode in compare-results to avoid false regression (#15933)
* fix: respect track mode in compare-results to avoid false regression failures
* Change files
* fix: update TouchableOpacity multiple-100 baseline to match CI environment
* update snapshots
---------
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com>
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
Co-authored-by: Vladimir Morozov <vmorozov@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMergeCauses a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iamAbhi-916@vineethkuttan@HariniMalothu17