Skip to content

Strip out color code characters from redbox error message - #4278

Merged
2 commits merged into
microsoft:masterfrom
acoates-ms:stripchalk
Mar 10, 2020
Merged

Strip out color code characters from redbox error message#4278
2 commits merged into
microsoft:masterfrom
acoates-ms:stripchalk

Conversation

@acoates-ms

@acoates-msAndrew Coates (acoates-ms) commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

This aligns with a similar change that was made in Android/iOS: react/react-native#24662

This greatly increases the readability of certain kinds of errors.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms
Andrew Coates (acoates-ms) requested a review from a team as a code ownerMarch 9, 2020 23:27
@ghostghost added the vnext label Mar 9, 2020
@acoates-msAndrew Coates (acoates-ms) added AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) and removed vnext labels Mar 9, 2020
@ghost

Copy link
Copy Markdown

Hello Andrew Coates (@acoates-ms)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
ghost merged commit b717348 into microsoft:masterMar 10, 2020
@acoates-ms
Andrew Coates (acoates-ms) deleted the stripchalk branch May 21, 2020 17:17
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMergeCauses a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@acoates-ms@vmoroz