Uh oh!
There was an error while loading. Please reload this page.
Align local metro config with future CLI changes - #4827
Merged
2 commits merged intoMay 8, 2020
Merged
Conversation
Deleted user (ghost)
commented
May 7, 2020
Hello Andrew Coates (@acoates-ms)! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
Nick Gerleman (NickGerleman)
approved these changes
May 7, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In react-native-community/cli#1115 some minor code review feedback slightly modified the metro config. I want our local copy that we are using until the CLI has this logic to match the CLI version as much as possible to catch issues, so I'm applying those changes here too.
Microsoft Reviewers: Open in CodeFlow