Uh oh!
There was an error while loading. Please reload this page.
[eslint-config] Upgrade to ESLint 8 - #3009
Closed
Lukas (lukashass) wants to merge 8 commits into
Closed
Conversation
Closed
Lukas (lukashass)
commented
Dec 6, 2021
ContributorAuthor
Superseded by #3057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to ESLint 8.
Closes#2998 and closes#2890 (for real this time 😉)
Details
To make
eslint-configcompatible with ESLint 8, its dependencies need to be upgraded as well:@typescript-eslint/*(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)v5.0.0eslint-plugin-promise(Support ESLint 8.x eslint-community/eslint-plugin-promise#218)eslint-plugin-react(Support ESLint 8.x jsx-eslint/eslint-plugin-react#3055)v7.27.0eslint-plugin-tsdoc(seems to work fine as it is)PRReleaseHow it was tested
Run
rush rebuild