Uh oh!
There was an error while loading. Please reload this page.
[API Extractor] Add missing required parameter for getResolvedModule to ensure that modules can resolve accurately with Node16/nodenext support - #3434
Conversation
…ypescript can resolve accurately
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
8afde43 to
18b51b5CompareChris Holt (chrisdholt)
commented
May 25, 2022
Thanks for the review Daniel Rosenwasser (@DanielRosenwasser) - build is passing with updated types! Ian Clanton-Thuon (@iclanton), Pete Gonzalez (@octogonz), Daniel (@D4N14L), Apostolis Haitalis (@apostolisms) - Apologies for the ping, but curious if anyone is available to work with us on getting this out the door to unblock our release? Thank you! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ypescript can resolve accurately
Summary
With the addition of
Node16andnodenext, Typescript now requires the mode to be passed in order to accurately resolve modules. This PR adds support formodethanks to the help of Daniel Rosenwasser (@DanielRosenwasser) and does so in a way that returns undefined gracefully in case the fn isn't supported in older versions.This resolves#3433.
Details
modegetModeForUsageLocationwhich maps to the TS equivalentHow it was tested
Tested locally with Typescript 4.7.2 and the error is gone, API Extractor succeeds.