Uh oh!
There was an error while loading. Please reload this page.
[rush-lib] Add autoInstallPeers in pnpm-config - #4379
Merged
Pete Gonzalez (octogonz) merged 4 commits intoOct 6, 2023
Conversation
Collaborator
Ian Clanton-Thuon (@iclanton)Daniel (@D4N14L)David Michon (@dmichon-msft) Should Rush instead default to
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Pete Gonzalez (octogonz)
approved these changes
Oct 6, 2023
Pete Gonzalez (octogonz)
commented
Oct 7, 2023
Collaborator
🚀 This feature was released with Rush 5.109.1 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PNPM8 changes the default value for
auto-install-peerssetting. It is default to true inPNPM8
In this PR, we want to provide a option inside
pnpm-config.jsonto let user overwriteauto-install-peerssetting easily.Details
If user set auto-install-peers in
pnpm-config.jsononly, use the value inpnpm-config.jsonIf user set auto-install-peers in
pnpm-config.jsonand.npmrc, use the value inpnpm-config.json, and output a warning messageIf user set auto-install-peers in
.npmrconly, do nothing, let pnpm handle itIf user does not set auto-install-peers in both
pnpm-config.jsonand.npmrc, rush will default it tofalseHow it was tested
Manually tested on rush-example repo.
Impacted documentation
N/A