.Net: Sync to MEAI 9.3.0-preview.1.25114.11 by roji · Pull Request #10989 · microsoft/semantic-kernel

Shay Rojansky (roji) · 2025-03-14T20:50:35Z

A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below.

Stephen Toub (stephentoub) · 2025-03-14T21:12:01Z

Sync to MEAI 9.3.0-preview.1.25114.11

Thanks! You beat me to it. I was waiting for a new build of ONNXRuntimeGenAI to be available, as I expect there will be versioning issues without that. It's supposed to be out today.

Stephen Toub (stephentoub) · 2025-03-15T03:38:51Z

Mark Wallace (@markwallace-microsoft), Roger Barreto (@rogerbarreto), are there known issues with the Process tests? I'm not familiar with that part of the codebase, but it's not clear to me why it would be impacted at all by the changes in this PR.

Roger Barreto (rogerbarreto) · 2025-03-15T09:51:01Z

are there known issues with the Process tests? I'm not familiar with that part of the codebase

I saw that, will have a look, thought the same

Stephen Toub (stephentoub) · 2025-03-18T15:54:51Z

The PR is building now. We should definitely revisit the 512e76b commit, though, after today's release is unblocked. It seems like there's some kind of conflict in the OllamaSharp package due to it carrying a source generator that depends on versions of compiler binaries that are incompatible with other aspect's of the repo's build. This was the way I found to temporarily work around it (other things I tried like excluding the analyzer assets for OllamaSharp were insufficient), but I don't like it as a longer-term solution.

A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below. --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>

Shay Rojansky (roji) requested a review from a team as a code owner March 14, 2025 20:50

Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 14, 2025

github-actionsBot changed the title ~~Sync to MEAI 9.3.0-preview.1.25114.11~~.Net: Sync to MEAI 9.3.0-preview.1.25114.11Mar 14, 2025

Shay Rojansky (roji)had a problem deploying to integration March 14, 2025 20:51 — with GitHub Actions Failure

Shay Rojansky (roji) commented Mar 14, 2025
View reviewed changes

Shay Rojansky (roji)force-pushed the NewMEAI branch from f30f609 to 0f2dc57Compare March 14, 2025 20:56

Shay Rojansky (roji)had a problem deploying to integration March 14, 2025 20:57 — with GitHub Actions Failure

Shay Rojansky (roji)force-pushed the NewMEAI branch from 0f2dc57 to 8c0801dCompare March 14, 2025 21:08

Shay Rojansky (roji)had a problem deploying to integration March 14, 2025 21:09 — with GitHub Actions Failure

Stephen Toub (stephentoub) reviewed Mar 14, 2025
View reviewed changes

Comment threaddotnet/Directory.Packages.props

Stephen Toub (stephentoub) reviewed Mar 14, 2025
View reviewed changes

Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs Outdated

Stephen Toub (stephentoub) reviewed Mar 14, 2025
View reviewed changes

Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs Outdated

Stephen Toub (stephentoub) reviewed Mar 14, 2025
View reviewed changes

Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs

Shay Rojansky (roji)had a problem deploying to integration March 14, 2025 21:47 — with GitHub Actions Failure

Shay Rojansky (roji) commented Mar 14, 2025
View reviewed changes

Comment threaddotnet/src/SemanticKernel.Abstractions/Contents/KernelContent.cs Outdated

Shay Rojansky (roji)had a problem deploying to integration March 14, 2025 21:50 — with GitHub Actions Failure

Roger Barreto (rogerbarreto) reviewed Mar 14, 2025
View reviewed changes

Comment threaddotnet/src/SemanticKernel.Abstractions/Contents/BinaryContent.cs Outdated

Alexandre Zollinger Chohfi (azchohfi) mentioned this pull request Mar 14, 2025
Moved to ORTGenAI's IChatClient. microsoft/ai-dev-gallery#246
Merged

Stephen Toub (stephentoub) self-assigned this Mar 15, 2025

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 1e1515e to 1adbf42Compare March 15, 2025 02:56

Stephen Toub (stephentoub)had a problem deploying to integration March 15, 2025 02:56 — with GitHub Actions Failure

Stephen Toub (stephentoub)had a problem deploying to integration March 15, 2025 03:03 — with GitHub Actions Failure

Stephen Toub (stephentoub)had a problem deploying to integration March 15, 2025 03:26 — with GitHub Actions Failure

Roger Barreto (rogerbarreto) reviewed Mar 15, 2025
View reviewed changes

Comment threaddotnet/src/Connectors/Connectors.Ollama.UnitTests/Services/OllamaChatCompletionTests.cs

Roger Barreto (rogerbarreto) reviewed Mar 15, 2025
View reviewed changes

Comment threaddotnet/Directory.Packages.props Outdated

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 843cec5 to 8868bdaCompare March 17, 2025 17:29

Stephen Toub (stephentoub)had a problem deploying to integration March 17, 2025 17:29 — with GitHub Actions Failure

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 8868bda to 86fac93Compare March 17, 2025 18:02

Stephen Toub (stephentoub)had a problem deploying to integration March 17, 2025 18:02 — with GitHub Actions Failure

Stephen Toub (stephentoub)had a problem deploying to integration March 18, 2025 00:49 — with GitHub Actions Failure

Stephen Toub (stephentoub)had a problem deploying to integration March 18, 2025 01:25 — with GitHub Actions Failure

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 5ea480f to 04fcb3aCompare March 18, 2025 02:31

Stephen Toub (stephentoub)temporarily deployed to integration March 18, 2025 02:31 — with GitHub Actions Inactive

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 04fcb3a to 15ced1cCompare March 18, 2025 03:07

Stephen Toub (stephentoub)had a problem deploying to integration March 18, 2025 03:08 — with GitHub Actions Failure

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 15ced1c to 3097ef1Compare March 18, 2025 03:13

Stephen Toub (stephentoub)had a problem deploying to integration March 18, 2025 03:14 — with GitHub Actions Failure

Mark Wallace (markwallace-microsoft)had a problem deploying to integration March 18, 2025 09:31 — with GitHub Actions Failure

Roger Barreto (rogerbarreto)had a problem deploying to integration March 18, 2025 10:21 — with GitHub Actions Failure

Mark Wallace (markwallace-microsoft)had a problem deploying to integration March 18, 2025 14:14 — with GitHub Actions Failure

Update to use M.E.AI 9.3.0-preview.1.25161.3
fd2db0c

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from e10878b to 875b332Compare March 18, 2025 14:57

Stephen Toub (stephentoub)temporarily deployed to integration March 18, 2025 14:57 — with GitHub Actions Inactive

Roger Barreto (rogerbarreto) reviewed Mar 18, 2025
View reviewed changes

Comment threaddotnet/Directory.Packages.props Outdated

Try toolset package?
512e76b

Stephen Toub (stephentoub)force-pushed the NewMEAI branch from 875b332 to 512e76bCompare March 18, 2025 15:26

Stephen Toub (stephentoub)temporarily deployed to integration March 18, 2025 15:26 — with GitHub Actions Inactive

Roger Barreto (rogerbarreto) approved these changes Mar 18, 2025
View reviewed changes

Comment threaddotnet/samples/Concepts/Plugins/CreatePluginFromOpenApiSpec_Github.cs

Mark Wallace (markwallace-microsoft) approved these changes Mar 18, 2025
View reviewed changes

Mark Wallace (markwallace-microsoft) added this pull request to the merge queue Mar 18, 2025

Merged via the queue into microsoft:main with commit ea00f4fMar 18, 2025

Shay Rojansky (roji) deleted the NewMEAI branch March 18, 2025 16:31

Navigation Menu

Uh oh!

.Net: Sync to MEAI 9.3.0-preview.1.25114.11 - #10989

.Net: Sync to MEAI 9.3.0-preview.1.25114.11#10989
Mark Wallace (markwallace-microsoft) merged 2 commits into
microsoft:mainfrom
roji:NewMEAI

Shay Rojansky (roji) commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 15, 2025

Uh oh!

Uh oh!

Uh oh!

Roger Barreto (rogerbarreto) commented Mar 15, 2025

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Shay Rojansky (roji) commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 15, 2025

Uh oh!

Uh oh!

Uh oh!

Roger Barreto (rogerbarreto) commented Mar 15, 2025

Uh oh!

Uh oh!

Uh oh!

Stephen Toub (stephentoub) commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants