Skip to content

.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient - #11678

Merged
Roger Barreto (rogerbarreto) merged 29 commits into
microsoft:feature-msextensions-aifrom
rogerbarreto:issues/11628-functioninvoking-extension
May 6, 2025
Merged

.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient#11678
Roger Barreto (rogerbarreto) merged 29 commits into
microsoft:feature-msextensions-aifrom
rogerbarreto:issues/11628-functioninvoking-extension

Conversation

@rogerbarreto

@rogerbarretoRoger Barreto (rogerbarreto) commented Apr 22, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Motivation and Context

This PR introduces changes recently merged to MEAI which allow flexibility and reusage from the higher level implementation perspective of Semantic Kernel.

  • KernelFunctionInvokingChatClient : MEAI.FunctionInvokingChatClient
  • AutoInvocationFunctionContext : MEAI.FunctionInvocationContext
  • KernelArguments : MEAI.AIFunctionArguments

FYI Stephen Toub (@stephentoub)Steve Sanderson (@SteveSandersonMS)

@rogerbarretoRoger Barreto (rogerbarreto) added the msft.ext.ai Related to Microsoft.Extensions.AI label Apr 22, 2025
@markwallace-microsoftMark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 22, 2025
@rogerbarretoRoger Barreto (rogerbarreto) moved this from Sprint: In Review to Bug in Semantic KernelApr 22, 2025
jeffhandley
Jeff Handley (jeffhandley) reviewed Apr 23, 2025
View reviewed changes

@jeffhandleyJeff Handley (jeffhandley) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger Barreto (@RogerBarret0) I left several comments for us to consider with Steve Sanderson (@SteveSandersonMS).

Even if we don't make changes into MEAI GA for the possible API additions, the approach you've taken here to refactor the replacement classes out to keep the Kernel* classes more maintainable seems reasonable to me.

You also mentioned a middleware-type concept when we chatted, but I didn't spot where that was surfacing in here. Can you explain that again and/or draw my attention to it please?

Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs Outdated
Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs Outdated
Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs Outdated
Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatClient/FunctionInvocationContextV2.cs Outdated
Comment threaddotnet/src/SemanticKernel.Abstractions/AI/ChatClient/KernelFunctionInvokingChatClient.cs Outdated
@rogerbarreto
Roger Barreto (rogerbarreto) marked this pull request as draft April 23, 2025 06:37
@rogerbarretoRoger Barreto (rogerbarreto) added needs discussion Issues that require discussion by the internal Semantic Kernel team before proceeding api_proposal Issues tagged with this label propose a change to the public API surface labels Apr 23, 2025
@rogerbarretoRoger Barreto (rogerbarreto) changed the title .Net: KernelFunctionInvokingChatClient specialization of MEAI.FunctionInvokingChatClient.Net: KernelFunctionInvokingChatClient specialization of MEAI.FunctionInvokingChatClient (Proposal)Apr 23, 2025
@rogerbarreto
Roger Barreto (rogerbarreto) marked this pull request as ready for review May 1, 2025 09:59
@rogerbarretoRoger Barreto (rogerbarreto) added PR: ready for review All feedback addressed, ready for reviews and removed needs discussion Issues that require discussion by the internal Semantic Kernel team before proceeding api_proposal Issues tagged with this label propose a change to the public API surface labels May 1, 2025
westey-m
westey (westey-m) reviewed May 1, 2025
View reviewed changes
Comment threaddotnet/src/Functions/Functions.OpenApi/RestApiOperationRunner.cs Outdated
SergeyMenshykh
SergeyMenshykh approved these changes May 1, 2025
View reviewed changes
Comment thread.../SemanticKernel.Abstractions/Filters/AutoFunctionInvocation/AutoFunctionInvocationContext.cs Outdated
@rogerbarreto
Roger Barreto (rogerbarreto) merged commit 9381c8d into microsoft:feature-msextensions-aiMay 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westey-mwestey (westey-m)westey-m left review comments
@dmytrostrukDmytro Struk (dmytrostruk)dmytrostruk approved these changes
@SergeyMenshykhSergeyMenshykhSergeyMenshykh approved these changes
@stephentoubStephen Toub (stephentoub)Awaiting requested review from stephentoub
+1 more reviewer
@jeffhandleyJeff Handley (jeffhandley)jeffhandley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@rogerbarretoRoger Barreto (rogerbarreto)

Labels

kernel.corekernelIssues or pull requests impacting the core kernelmsft.ext.aiRelated to Microsoft.Extensions.AI.NETIssue or Pull requests regarding .NET codePR: ready for reviewAll feedback addressed, ready for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rogerbarreto@jeffhandley@dmytrostruk@SergeyMenshykh@westey-m@markwallace-microsoft