Uh oh!
There was an error while loading. Please reload this page.
fix: apply Redis JSON collection key prefixes on delete - #14314
fix: apply Redis JSON collection key prefixes on delete#14314medimedi (medisean) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Redis JSON collection deletion when collection-name key prefixes are enabled.
Changes:
- Applies collection key prefixes during JSON deletion.
- Adds a regression test for prefixed keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
python/tests/unit/connectors/memory/test_redis_store.py | Verifies prefixed JSON deletion behavior. |
python/semantic_kernel/connectors/redis.py | Prefixes keys during JSON deletion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): c5352c557478
Model:claude-opus-4.8
Overview
This is a minimal, well-scoped bug fix that routes each delete key in RedisJsonCollection._inner_delete through _get_redis_key, so deletes target the same prefixed key that upsert writes and get reads when prefix_collection_name_to_key_names=True. The change makes the JSON delete path consistent with the JSON upsert/get paths and with the sibling RedisHashsetCollection._inner_delete, which already applied the prefix. The default (prefix=False) case is unaffected because _get_redis_key is a no-op there, callers always pass raw keys so there is no double-prefixing, and a targeted regression test pins the prefixed key. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Closes#13904
RedisJsonCollection._inner_deletenow resolves keys through the same collection-prefix helper used by upsert and get. This prevents deletes from silently targeting the unprefixed key whenprefix_collection_name_to_key_names=True, with a regression test for the prefixed JSON collection.Validation:
python3 -m compileall -q python/semantic_kernel/connectors/redis.py python/tests/unit/connectors/memory/test_redis_store.pygit diff --checkopentelemetry.