Uh oh!
There was an error while loading. Please reload this page.
Method name is added to exception message. - #787
Merged
Shawn Callegari (shawncal) merged 2 commits intoMay 6, 2023
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
SergeyMenshykh
requested review from
Lee Miller (lemillermicrosoft)
and removed request for
Lee Miller (lemillermicrosoft)May 5, 2023 14:48
Shawn Callegari (shawncal)
approved these changes
May 6, 2023
Shawn Callegari (shawncal)force-pushed
the
improve-exception-message
branch
from
May 6, 2023 05:34
c67ea62 to
50a32acCompareShawn Callegari (shawncal)
enabled auto-merge (squash)
May 6, 2023 05:35
Stuart Cam (codebrain) pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
### Motivation, Context and Description This PR adds function/method name into exception message that is thrown if a native function, marked with SKFunctionInputAttribute, doesn't have an input parameter of string type. The method name can be useful for debugging and troubleshooting.
Desmond Howard (dehoward) pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation, Context and Description This PR adds function/method name into exception message that is thrown if a native function, marked with SKFunctionInputAttribute, doesn't have an input parameter of string type. The method name can be useful for debugging and troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
This PR adds function/method name into exception message that is thrown if a native function, marked with SKFunctionInputAttribute, doesn't have an input parameter of string type. The method name can be useful for debugging and troubleshooting.
Contribution Checklist
dotnet format