Uh oh!
There was an error while loading. Please reload this page.
fixed active workspace bug for users switching public workspaces - #735
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression where authenticated users who aren’t owners/admins/document-managers couldn’t activate a public workspace for chat due to an overly strict membership check on the setActive endpoint.
Changes:
- Removes the membership/role gate from
PATCH /api/public_workspaces/setActivewhile keeping auth + feature-flag enforcement. - Bumps app version to
0.238.025and adds corresponding release notes. - Adds/updates workflow documentation images and adjusts
.gitignorefortmp_images.
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
application/single_app/route_backend_public_workspaces.py | Drops the “Not a member” 403 check for setActive on public workspaces. |
application/single_app/config.py | Version bump 0.238.024 → 0.238.025. |
docs/explanation/release_notes.md | Adds bug-fix entry for the public workspace activation 403. |
.gitignore | Updates ignore pattern for tmp_images. |
docs/images/workflow-retention_policy.png | Adds/updates workflow image asset. |
docs/images/workflow-admin_settings_updates.png | Adds/updates workflow image asset. |
Uh oh!
There was an error while loading. Please reload this page.
Paul Lizer (paullizer)
left a comment
There was a problem hiding this comment.
looks good to me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…microsoft/simplechat into fix-public-workspace-active-bug
Uh oh!
There was an error while loading. Please reload this page.
Bug Fixes
/api/public_workspaces/setActiveendpoint that only allowed owners, admins, and document managers — even though public workspaces are intended to be accessible to all authenticated users for chatting.setActiveendpoint; the route still requires authentication (@login_required,@user_required) and the public workspaces feature flag (@enabled_required).route_backend_public_workspaces.py,api_set_active_public_workspace)