Uh oh!
There was an error while loading. Please reload this page.
Runner: make MPI bind-to configurable - #797
Conversation
one (alephpiece)
commented
Mar 27, 2026
@microsoft-github-policy-service agree |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Hongtao Zhang (polarG)
left a comment
There was a problem hiding this comment.
Overall: The feature is well-motivated and docs are solid, but the PR needs fixes before merge. See inline comments for details.
| # | Severity | Finding |
|---|---|---|
| 1 | BLOCKER | Existing MPI tests break — missing bind_to key on test mode dicts |
| 2 | SHOULD-FIX | No input validation on bind_to — injection risk + invalid values |
| 3 | SHOULD-FIX | No new tests for the bind_to feature |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Replaced with inline file comments.
Hongtao Zhang (polarG)
commented
Apr 23, 2026
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #797 +/- ##
==========================================
+ Coverage 85.69% 85.70% +0.01%
==========================================
Files 103 103 Lines 7890 7897 +7 ==========================================
+ Hits 6761 6768 +7
Misses 1129 1129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Make MPI process binding configurable in SuperBench runner modes so benchmarks with their own topology-aware affinity logic can disable the default
-bind-to numabehavior when needed.Major Revision
bind_tofield formpimodes in the runnerbind_totonumabind_tovalue instead of a hard-codednuma