Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add artifact post-processing orchestration - #10086

Merged
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing
Jul 21, 2026
Merged

Add artifact post-processing orchestration#10086
Amaury Levé (Evangelink) merged 28 commits into
mainfrom
dev/amauryleve/implement-artifact-postprocessing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Implements the remaining testfx-side pieces of RFC 018 so dotnet/sdk can orchestrate artifact consolidation after multi-module MTP runs.

  • adds the experimental IArtifactPostProcessor contract, DTOs, and registration surface
  • promotes tool registration APIs for extension-owned merge tools
  • advertises post-processor kinds and legacy extensions during the dotnet-test handshake
  • adds the hidden internal-merge-artifacts dispatcher with manifest routing and merged artifact return over the existing pipe
  • adds the user-facing merge-trx tool and TRX post-processor over the existing merge engine
  • adds localized diagnostics, API baselines, unit coverage, and help/info expectations

Review follow-ups

Two independent review passes were completed, including the MSTest/MTP expert reviewer. Follow-up fixes include:

  • localizing platform-side dispatcher and manifest diagnostics
  • restricting artifact-post-processor pipe setup and handshake identity to the internal dispatcher
  • warning when processor capabilities overlap
  • using deterministic unique merged TRX filenames to avoid cross-run overwrites
  • adding malformed-manifest and successful TRX processing coverage
  • scoping tool option validation to the selected tool

Validation

  • Microsoft.Testing.Platform.UnitTests — 1399 passed
  • Microsoft.Testing.Extensions.UnitTests — 775 passed, 5 expected skips
  • merge-trx end-to-end produced a valid merged TRX
  • package build and NuGet validation succeeded
  • all-extensions --help and --info acceptance tests passed across net462, net8.0, and net10.0

Related to dotnet/sdk#47613 and RFC 018 (#9187).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements RFC 018 artifact post-processing orchestration for MTP, including extension APIs, SDK handshake support, internal dispatching, and TRX merging.

Changes:

  • Adds artifact post-processor contracts, registration, manifest routing, and pipe reporting.
  • Promotes tool registration and adds the merge-trx tool.
  • Adds API baselines, localized resources, and tests.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Extensions/ArtifactPostProcessing/ArtifactPostProcessingTests.csTests capabilities, registration, and manifests.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxArtifactPostProcessorTests.csTests TRX post-processing.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.csAdds merge-tool info expectations.
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.csMakes tool registration public.
src/Platform/Microsoft.Testing.Platform/Tools/ITool.csPromotes and documents tool contracts.
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.csAdds identity and message sending.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.csAdds handshake capabilities and modes.
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.csAdvertises tool execution mode.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlfSyncs Traditional Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlfSyncs Simplified Chinese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlfSyncs Turkish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlfSyncs Russian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlfSyncs Portuguese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlfSyncs Polish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlfSyncs Korean resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlfSyncs Japanese resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlfSyncs Italian resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlfSyncs French resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlfSyncs Spanish resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlfSyncs German resources.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlfSyncs Czech resources.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds dispatcher diagnostics.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.csExposes a resource to tests.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txtTracks new public APIs.
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txtTracks new internal APIs.
src/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.csAdds pipe-aware tool execution.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Modes.csBuilds processors and dispatcher connections.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.csRegisters built-in dispatcher components.
src/Platform/Microsoft.Testing.Platform/Hosts/ITestHostBuilder.csAdds processor registration internally.
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.csAdvertises processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessor.csDefines processor contracts and DTOs.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.csDefines processor registration.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.csParses orchestration manifests.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManager.csBuilds registered processors.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingHandshakeProperties.csSerializes processor capabilities.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.csRoutes and reports processed artifacts.
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.CommandLine.csDefines dispatcher CLI options.
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineHandler.csHides internal tools from info.
src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.csExposes registration managers.
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.csAdds public registration surfaces.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportExtensions.csRegisters TRX processor and tool.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Utilities.csGenerates deterministic merge IDs.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.csImplements merge-trx.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxMergeTool.CommandLine.csDefines merge-tool options.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxCompareTool.csMarks the comparer visible.
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxArtifactPostProcessor.csImplements automatic TRX merging.
src/Platform/Microsoft.Testing.Extensions.TrxReport/ToolTrxMergeFactory.csCreates merge-tool components.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlfSyncs Traditional Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hans.xlfSyncs Simplified Chinese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlfSyncs Turkish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ru.xlfSyncs Russian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlfSyncs Portuguese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pl.xlfSyncs Polish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlfSyncs Korean TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ja.xlfSyncs Japanese TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlfSyncs Italian TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlfSyncs French TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.es.xlfSyncs Spanish TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.de.xlfSyncs German TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.cs.xlfSyncs Czech TRX resources.
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resxAdds TRX merge diagnostics.
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txtTracks TRX internal APIs.

Review details

  • Files reviewed: 62/62 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/Hosts/ToolsTestHost.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 13:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/63 changed files
  • Comments generated: 3
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:52
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:32

  • This normalization is still incomplete on non-NETCOREAPP targets. JsonConfigurationFileParser.netstandard.cs:34 casts the deserialized root directly to JsonObject, so a valid non-object JSON root such as [] throws InvalidCastException, not JsonException. That exception bypasses both this wrapper and the dispatcher's IOException/UnauthorizedAccessException/FormatException filter, faulting the tool instead of returning the localized invalid-manifest result. Normalize InvalidCastException here as well.
 catch (JsonException ex)
{
throw new FormatException(ex.Message, ex);
}

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:48

  • An empty or scalar input entry is silently discarded instead of being rejected. The JSON parser represents {} in the first array slot as the key inputs:0, but this parts.Length >= 3 filter ignores that key, so inputs: [{}] loads as an empty manifest and never reaches the required-path check below. Include two-part index keys so every declared input is validated.
 {
throw new FormatException(PlatformResources.ArtifactPostProcessingManifestInvalid);
}
int[] inputIndices = [.. values.Keys
.Where(key => key.StartsWith("inputs:", StringComparison.Ordinal))
.Select(key => key.Split(':'))
  • Files reviewed: 63/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

CopilotAI review requested due to automatic review settings July 20, 2026 13:58

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs:16

  • The promoted registration surface is not usable for third-party tools that need arguments. Tool option scoping now requires IToolCommandLineOptionsProvider (ToolsTestHost.cs:207-210), but that interface is internal (Tools/IToolCommandLineOptionsProvider.cs:8), so an external extension can register an ITool here but cannot associate any command-line options with it; ordinary public ICommandLineOptionsProvider implementations are rejected as unknown options. Expose a public way to bind option providers to a tool (for example, make the scoped provider contract public or add an options-aware registration overload).
    src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs:126
  • The published dotnet-test pipe specification is now stale: docs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md:337-345 lists only the prior host types, execution modes, and properties through ID 13. Document ArtifactPostProcessor, tool, and capability properties 14/15 so SDK and host implementers have an accurate wire contract.
  • Files reviewed: 63/63 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 17:57
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 70/70 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Platform/Microsoft.Testing.Platform/Tools/ITool.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 18:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingManifest.cs:101

  • Malformed optional metadata is silently accepted. For example, "kind": { "value": "trx" } has no scalar at the kind key, so this first branch returns null before inspecting the raw JSON; empty objects/arrays follow the same path. This contradicts the manifest's string-or-null schema and the strict handling already applied to numeric metadata. Validate the raw JSON type whenever the property exists, then read its scalar value.
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 75/75 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threaddocs/mstest-runner-protocol/004-protocol-dotnet-test-pipe.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 20, 2026 21:45

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/ArtifactPostProcessingDispatcherTool.cs:138

  • This path comparison is incorrect on case-insensitive non-Windows filesystems (notably default macOS volumes): Ordinal treats Input.trx and input.trx as different even when they resolve to the same file. It also compares lexical paths without resolving symlinks. Consequently, a processor output that aliases an input can pass this guard, violating the read-only-input contract, and a casing variant of the output directory can be rejected despite being valid. Please canonicalize paths (including links where supported) and determine case sensitivity for the output filesystem, as SharedExtensionHelpers/MergeOutputFileHelper.cs:17-42 does.
 StringComparison pathComparison = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
? StringComparison.OrdinalIgnoreCase
: StringComparison.Ordinal;
return outputPath.StartsWith(outputDirectoryPrefix, pathComparison)
&& File.Exists(outputPath)
&& !inputs.Any(input => string.Equals(Path.GetFullPath(input.Path), outputPath, pathComparison))
  • Files reviewed: 75/75 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

⚠️Partial analysis — the binlog-mcp MCP server was unreachable from this sandbox (network access blocked by security policy). The binary logs could not be queried programmatically.

What we know

  • Azure DevOps build: [#1518663]((dev.azure.com/redacted) — failed
  • PR head SHA: 09cf260d2e72473f905d0c5fc6eaf9c1cd83453c
  • Binlogs staged (6 legs): Build_Linux_Release, Build_Windows_NT_Release, Build_Linux_Debug, Build_Darwin_Release, Build_Windows_NT_Debug, Build_Darwin_Debug

What to do

Please inspect the originating [Azure DevOps build]((dev.azure.com/redacted) directly for the compiler errors, then check:

  1. Build errors (CS####, SA####, RS####, CA####) in the build log
  2. Public API surface — if new public members were added, ensure PublicAPI.Unshipped.txt is updated
  3. Nullable annotations — recent nullability changes cascade across call sites

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 47.6 AIC · ⌖ 5.06 AIC · ⊞ 6.2K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:30
@github-actions

This comment has been minimized.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 22566837-4117-4194-ba2a-94481459619d
CopilotAI review requested due to automatic review settings July 21, 2026 07:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 74/74 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10086

32 tests graded across 7 files. 28 × A, 4 × C. The most common issue is a single IsTrue(result.IsValid) assertion that confirms success but does not capture which option caused it, and two tests that bundle multiple distinct behaviors (valid + several invalid scenarios) in one method body. Consider splitting the multi-scenario tests and enriching the boolean-only assertions with an ErrorMessage or similar check.

GradeTestNotes
C (70–79)mod ArtifactPostProcessingTests.
ValidateProcessedArtifact_
RejectsInvalidPaths
Tests valid path, missing file, outside-dir, and reused-input in one body — consider splitting into four focused tests.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
ToolOptionDoesNotConflictWith
NormalExtension
Only Assert.IsTrue(result.IsValid) — consider also asserting the absence of an ErrorMessage to anchor the contract.
C (70–79)mod CommandLineHandlerTests.
ParseAndValidateAsync_
RepeatedToolOption_
ValidatesAggregatedArguments
Only Assert.IsTrue(result.IsValid); the mock is set up to return failure for wrong counts, but the test never checks the error path — consider adding a negative DataRow.
C (70–79)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithTwoInputs_
WritesUniquelyNamedMergedReport
Two behaviors (merge produces output; reordered inputs produce same file) in ~50 lines — consider splitting idempotency into its own test.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
DuplicateCapabilitiesWithinOneProcessor_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
KindMatchingAnotherProcessorExtension_
ReturnsEmpty
No issues found.
A (90–100)new ArtifactPostProcessingTests.
FindProcessorConflicts_
SameCapabilityAcrossProcessors_
ReturnsFirstProcessor
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
AreSortedAndDeduplicated
No issues found.
A (90–100)new ArtifactPostProcessingTests.
HandshakeProperties_
WithNoCapabilities_
ReturnsNull
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
BuildsOnlyEnabledProcessors
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
CapabilityContainingSeparator_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manager_
InvalidCapability_
ThrowsInvalidOperationException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
LoadsVersionedAttributedInputs
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithEmptyInputEntry_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputMissingPath_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInputsThatIsNotArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithInvalidValueType_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithMalformedJson_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithTopLevelArray_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
Manifest_
WithUnsupportedVersion_
ThrowsFormatException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
ProcessedArtifact_
BlankKind_
ThrowsArgumentException
No issues found.
A (90–100)new ArtifactPostProcessingTests.
SupportsArtifactPostProcessing_
ReturnsExpectedValue
No issues found.
A (90–100)mod CommandLineHandlerTests.
ParseAndValidateAsync_
UnknownJsonOptionForSelectedTool_
ReturnsInvalid
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
InvalidOutputDirectory_
ReturnsInvalidCommandLine
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
OptionsFromTestConfig_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
RepeatedInputs_
WritesOutputTrx
No issues found.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
MergeTool_
UnexpectedPositionalArgument_
ReturnsInvalidCommandLine
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessageExecutionModes_
AreStable
No issues found.
A (90–100)mod DotnetTestProtocolContractTests.
HandshakeMessagePropertyNames_
AreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessageExecutionModes_
ValuesAreStable
No issues found.
A (90–100)mod ProtocolTests.
HandshakeMessagePropertyNames_
ValuesAreStable
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
Capabilities_
DescribeTrxArtifacts
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
IsIndependentOfInputOrder
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
CreateMergeRunId_
WithDifferentExecutionId_
ProducesDifferentId
No issues found.
A (90–100)new TrxArtifactPostProcessorTests.
ProcessAsync_
WithFewerThanTwoInputs_
ReturnsNull
No issues found.
A (90–100)new ToolsHostTests.
AggregateArguments_
CombinesRepeatedOptionOccurrences
No issues found.
A (90–100)new ToolsHostTests.
ValidateCommandLineOptionsAsync_
ReturnsProviderFailure
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
DuplicateToolOption_
ReturnsInvalid
No issues found.
A (90–100)new ToolsHostTests.
ValidateToolProviders_
SystemOptionCollision_
ReturnsInvalid
No issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 136.7 AIC · ⌖ 5.44 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e404361 into mainJul 21, 2026
41 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/implement-artifact-postprocessing branch July 21, 2026 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101