Uh oh!
There was an error while loading. Please reload this page.
Restore localization filters after #10268 - #10281
Merged
Amaury Levé (Evangelink) merged 1 commit intoJul 28, 2026
Merged
Conversation
Remove invalid translations reintroduced by a late OneLocBuild commit after the filtered PR had already been approved. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c475df24-a912-49c8-8f59-18524c91af55
Contributor
There was a problem hiding this comment.
Pull request overview
Restores localization units overwritten by late OneLocBuild commits after #10268’s review.
Changes:
- Restores nine invalid translations to English fallback with
state="new". - Removes an extraneous
{0}placeholder from the French analyzer text.
Show a summary per file
| File | Description |
|---|---|
CrashDumpResources.fr.xlf | Restores crash-sequence fallback text. |
Resources.zh-Hant.xlf | Restores ResourceLock description fallback. |
Resources.ru.xlf | Restores ResourceLock description fallback. |
Resources.ja.xlf | Restores Native AOT description fallback. |
Resources.fr.xlf | Removes an invalid placeholder. |
Resources.es.xlf | Restores ResourceLock message fallback. |
Resources.de.xlf | Restores ResourceLock description fallback. |
Resource.de.xlf | Restores cleanup cancellation fallback. |
PlatformAdapterResources.ko.xlf | Restores browser runsettings fallback. |
PlatformAdapterResources.de.xlf | Restores browser runsettings fallback. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review Summary
Verdict: ✅ All clear — no issues found.
This PR reverts invalid OneLocBuild translations that landed after #10268 was approved, resetting affected <target> elements to state="new" with the English source text. The changes are mechanical and correct:
- All 10
.xlffiles consistently resetstate="translated"→state="new"with the English source as placeholder. - The XML prolog BOM/whitespace fix (
<?xml version="1.0" encoding="utf-8"?>) is consistently applied. - The
Resources.fr.xlffix removes a stray{0}placeholder that was incorrectly present in the French translation.
No public API, logic, or behavioral changes. No concerns across any of the 22 review dimensions.
This was referenced Jul 28, 2026
Amaury Levé (Evangelink)
enabled auto-merge (squash)
July 28, 2026 10:47
Petr Pokorny (0101)
approved these changes
Jul 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
Amaury Levé (Evangelink)
deleted the
dev/amauryleve/fix-pr10268-localization
branch
July 28, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10268. A late OneLocBuild commit landed after the filtered head was approved and reintroduced invalid translations in 10 files. This restores those reviewed resource units to their pre-merge values.