Skip to content

Use is not null instead of != null in new files from PR #10353#10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amaury Levé (Evangelink) merged 1 commit into from
Jul 31, 2026
Merged

Use is not null instead of != null in new files from PR #10353 #10362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Platform/Microsoft.Testing.Extensions.MSBuild/MSBuildConsumer.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,8 +200,8 @@ private async Task HandleFailuresAsync(string testDisplayName, bool isCanceled,
{
_totalTests++;
_totalFailedTests++;
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks != null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks.PipeClient != null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks is not null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks.PipeClient is not null);
Comment thread
Evangelink marked this conversation as resolved.
var failedTestInfoRequest = new FailedTestInfoRequest(testDisplayName, isCanceled, duration, errorMessage, errorStackTrace, expected, actual, codeFilePath, lineNumber);
await _msBuildTestApplicationLifecycleCallbacks.PipeClient.RequestReplyAsync<FailedTestInfoRequest, VoidResponse>(failedTestInfoRequest, cancellationToken).ConfigureAwait(false);
}
Expand All@@ -210,8 +210,8 @@ private async Task HandleSummaryAsync(TimeSpan elapsed, CancellationToken cancel
{
string? duration = ToHumanReadableDuration(elapsed.TotalMilliseconds);

ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks != null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks.PipeClient != null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks is not null);
ApplicationStateGuard.Ensure(_msBuildTestApplicationLifecycleCallbacks.PipeClient is not null);
Comment thread
Evangelink marked this conversation as resolved.
bool allowSkipped = PlatformCommandLineProvider.GetZeroTestsPolicy(_commandLineOptions) == ZeroTestsPolicy.AllowSkipped;
var runSummaryInfoRequest = new RunSummaryInfoRequest(_totalTests, _totalFailedTests, _totalPassedTests, _totalSkippedTests, duration, allowSkipped);
await _msBuildTestApplicationLifecycleCallbacks.PipeClient.RequestReplyAsync<RunSummaryInfoRequest, VoidResponse>(runSummaryInfoRequest, cancellationToken).ConfigureAwait(false);
Expand Down
10 changes: 5 additions & 5 deletions .../Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.TestNodeSerializers.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ private static void RegisterTestNodeSerializers()
properties["execution-state"] = "failed";
properties["error.message"] = failedTestNodeStateProperty.Explanation ?? failedTestNodeStateProperty.Exception?.Message;
Exception? exception = failedTestNodeStateProperty.Exception;
if (exception != null)
if (exception is not null)
{
properties["error.stacktrace"] = exception.StackTrace ?? string.Empty;
}
Expand All@@ -188,7 +188,7 @@ private static void RegisterTestNodeSerializers()
properties["assert.actual"] = assertionFailure.Actual ?? string.Empty;
properties["assert.expected"] = assertionFailure.Expected ?? string.Empty;
}
else if (exception != null)
else if (exception is not null)
{
properties["assert.actual"] = exception.Data["assert.actual"] ?? string.Empty;
properties["assert.expected"] = exception.Data["assert.expected"] ?? string.Empty;
Expand All@@ -201,7 +201,7 @@ private static void RegisterTestNodeSerializers()
{
properties["execution-state"] = "timed-out";
properties["error.message"] = timeoutTestNodeStateProperty.Explanation ?? timeoutTestNodeStateProperty.Exception?.Message;
if (timeoutTestNodeStateProperty.Exception != null)
if (timeoutTestNodeStateProperty.Exception is not null)
{
properties["error.stacktrace"] = timeoutTestNodeStateProperty.Exception.StackTrace ?? string.Empty;
}
Expand All@@ -213,7 +213,7 @@ private static void RegisterTestNodeSerializers()
{
properties["execution-state"] = "error";
properties["error.message"] = errorTestNodeStateProperty.Explanation ?? errorTestNodeStateProperty.Exception?.Message;
if (errorTestNodeStateProperty.Exception != null)
if (errorTestNodeStateProperty.Exception is not null)
{
properties["error.stacktrace"] = errorTestNodeStateProperty.Exception.StackTrace ?? string.Empty;
}
Expand All@@ -227,7 +227,7 @@ private static void RegisterTestNodeSerializers()
{
properties["execution-state"] = "canceled";
properties["error.message"] = canceledTestNodeStateProperty.Explanation ?? canceledTestNodeStateProperty.Exception?.Message;
if (canceledTestNodeStateProperty.Exception != null)
if (canceledTestNodeStateProperty.Exception is not null)
{
properties["error.stacktrace"] = canceledTestNodeStateProperty.Exception.StackTrace ?? string.Empty;
}
Expand Down