Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Report artifact post-processing input provenance - #10463

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance
Aug 5, 2026
Merged

Report artifact post-processing input provenance#10463
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/fix-artifact-provenance

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • add additive FileArtifactMessage.InputArtifactPaths field ID 8 to report the exact manifest inputs represented by each processed artifact
  • populate provenance per dispatcher output and define non-null ProcessedArtifact results as representing every supplied input
  • preserve manifest path strings verbatim so the SDK can intersect them with the originating job without cross-process normalization drift
  • cover serializer compatibility, old readers skipping field 8, multiple disjoint outputs, and the generic .xml collision from MTP artifact post-processing: a merged artifact can unlist unrelated artifacts sharing its extension dotnet/sdk#55555
  • update the dotnet-test pipe protocol and artifact post-processing RFC

Compatibility

This remains an additive field on serializer ID 7. Older readers skip it, newer readers treat its absence as an old-host response, and no protocol-version bump or handshake capability is required.

A follow-up SDK change is still required to vendor field 8 and remove only provenance paths that intersect the dispatched job's manifest. Relates to dotnet/sdk#55555.

Testing

  • ./build.cmd -pack -bl
  • 129 protocol test executions across net462, net8.0, and net9.0
  • 69 shared protocol-contract test executions across net462, net8.0, and net9.0
  • 3 focused artifact post-processing acceptance tests on net11.0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI balanced review requested due to automatic review settings August 5, 2026 16:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-output artifact provenance to resolve incorrect artifact collapsing tracked by dotnet/sdk#55555.

Changes:

  • Adds and serializes InputArtifactPaths as field ID 8.
  • Reports exact manifest inputs for each processed artifact.
  • Adds compatibility, routing, and acceptance coverage plus protocol documentation.
Show a summary per file
FileDescription
ProtocolTests.csTests provenance round-tripping.
ProtocolEdgeCaseTests.csTests absent and unknown fields.
DotnetTestProtocolSerializerTests.csPins field ID 8 and shared serialization.
DotnetTestPipeProtocol.csDecodes provenance in acceptance tests.
DotnetTestPipeArtifactPostProcessingTests.csTests disjoint outputs and legacy readers.
FileArtifactMessagesSerializer.csSerializes provenance paths.
ObjectFieldIds.csDefines field ID 8.
FileArtifactMessages.csAdds the provenance model property.
InternalAPI.Unshipped.txtTracks the platform internal API changes.
IArtifactPostProcessor.csDocuments all-input output semantics.
ArtifactPostProcessingDispatcherTool.csAttaches matched inputs to outputs.
018-Artifact-Post-Processing.mdUpdates the post-processing RFC.
004-protocol-dotnet-test-pipe.mdDocuments the additive wire field.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment threaddocs/RFCs/018-Artifact-Post-Processing.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6a2a6bc6-4930-45db-8389-760216a6348d
CopilotAI review requested due to automatic review settings August 5, 2026 18:59

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🧵 Parallel-safety audit — PR #10463

Parallelization — assemblies containing the changed test files:

Test assemblyScopeWorkersAnalyzer coverage
Microsoft.Testing.Platform.Acceptance.IntegrationTestsMethodLevel ([assembly: Parallelize] in Program.cs)CPU count (Workers = 0)coverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)
Microsoft.Testing.Platform.UnitTestsMethodLevelCPU countcoverable once MSTEST0074–0077 ship (attribute opt-in)

No .runsettings/testconfig.json/MSBuild parallelization overrides found for these projects, and this PR does not touch any [assembly: Parallelize]/[assembly: DoNotParallelize] declaration, so the configured MethodLevel scope stands unmodified.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Analysis:

  • DotnetTestPipeArtifactPostProcessingTests.cs (new methods Dispatcher_ReportsOnlyInputsRepresentedByEachOutput and Dispatcher_ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance) each build their working directory as Path.Combine(Path.GetTempPath(), $"artifact-dispatcher-...-{Guid.NewGuid():N}") — a per-invocation unique path, so no cross-test filesystem collision under MethodLevel concurrency (category B: none). Each method's finally deletes only its own GUID-scoped directory. No environment variables, CWD, console, or mutable static state are touched. No [ResourceLock]/[DoNotParallelize] declarations were added, removed, or would be warranted.
  • DotnetTestProtocolSerializerTests.cs, ProtocolEdgeCaseTests.cs, ProtocolTests.cs — all new/changed assertions operate on local MemoryStream instances and local FileArtifactMessage/FileArtifactMessages values passed through a pure round-trip helper; no shared or process-global state is read or written.

Nothing in this diff falls into categories A–D. Scope is MethodLevel for all three assemblies (the highest-risk configuration), but the added tests are already written in an isolation-safe style (unique GUID temp dirs, no shared statics), so there is nothing to flag.

Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 100.7 AIC · ⌖ 3.66 AIC · ⊞ 24.7K · [◷]( · )

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10463

Graded 8 new/modified test methods across 3 files, all covering the new InputArtifactPaths provenance field on FileArtifactMessage (wire protocol, serializer round-trips, and the artifact-dispatcher acceptance tests). Every test uses a clear Arrange-Act-Assert shape, asserts concrete values (not just null-checks), and exercises the specific mutation points introduced by this change (wire field id, serialization round-trip, dispatcher provenance grouping, and legacy-reader opt-out). No anti-patterns, tautological assertions, or unawaited async issues were observed, so all 8 tests grade A.

GradeTestMutationNotesHow to improve
A (90–100)mod DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
AdvertisesCapabilityAndReturnsMergedArtifact
2/2 killedAsserts advertised capability string and exact input-path provenance via AreSequenceEqual.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsOnlyInputsRepresentedByEachOutput
2/2 killedVerifies per-kind attribution and explicitly asserts the unrelated input is excluded.
A (90–100)new DotnetTestPipeArtifactPostProcessingTests.
Dispatcher_
ReportsDisjointInputsForMultipleOutputsAndLegacyReaderSkipsProvenance
3/3 killedCovers disjoint per-kind grouping and that the legacy reader path omits provenance.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessageFieldIds_
AreStable
3/3 killedReflection-based pin of the SessionUid, Kind, and new InputArtifactPaths wire ids.
A (90–100)mod DotnetTestProtocolSerializerTests.
FileArtifactMessages_
RoundTrips
2/2 killedRound-trips InputArtifactPaths for a populated and an empty-array artifact.
A (90–100)mod ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenMultipleArtifactsWithMixedNulls_
RoundTrips
1/1 killedConfirms InputArtifactPaths stays null when the source message omits it.
A (90–100)new ProtocolEdgeCaseTests.
FileArtifactMessages_
WhenUnknownFieldsPrecedeKnownFields_
DeserializesRemainingFields
1/1 killedVerifies unknown-field skipping does not corrupt the InputArtifactPaths default.
A (90–100)mod ProtocolTests.
FileArtifactMessagesSerializeDeserialize
2/2 killedLoop-based assertions verify InputArtifactPaths sequence equality for every artifact.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Suggestions on the Files
changed tab can be applied with one click. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 144.1 AIC · ⌖ 3.75 AIC · ⊞ 16.2K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit e0ab7e1 into mainAug 5, 2026
54 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/fix-artifact-provenance branch August 5, 2026 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101