Optimize non-generic collection count assertions

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

• use ICollection.Count for non-generic Assert.HasCount and Assert.IsEmpty calls instead of enumerating through Cast<object>()
• preserve the original plain-IEnumerable fallback, null exception ordering, failure messages, and one telemetry event per assertion call
• cover side-effecting and throwing collection implementations, fallback enumeration, exact messages, null behavior, and process-isolated telemetry cardinality

Performance

Release microbenchmark of the isolated count path over 1,000 elements (median of five 200,000-iteration samples):

Workload	Before	After	Allocations before	Allocations after
ICollection (ArrayList)	11,147.0 ns/op	8.2 ns/op	104 B/op	0 B/op
plain IEnumerable	17,432.4 ns/op	17,446.1 ns/op	24,096 B/op	24,096 B/op

The fallback result is effectively unchanged; the collection path becomes O(1) and allocation-free.

Validation

• multi-target TestFramework unit-test project build with binary log
• 1,513 net8.0 TestFramework unit tests passed with telemetry opted out
• Release pack completed with binary log
• net8.0 telemetry acceptance case passed and verified exactly one Assert.HasCount and one Assert.IsEmpty event

Closes#10573

[Copilot]

Pull request overview

Optimizes non-generic count assertions by using ICollection.Count while preserving fallback behavior and telemetry.

Changes:

• Adds the ICollection fast path.
• Adds unit tests for counting, failures, nulls, and enumeration.
• Verifies telemetry cardinality in acceptance tests.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs	Implements the optimized count path.
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs	Covers optimized and fallback behavior.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs	Validates assertion telemetry counts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🧵 Parallel-safety audit — PR #10575

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

• src/TestFramework/TestFramework/Assertions/Assert.HasCount.cs — production code change (fast-path for ICollection.Count), not a test file.
• test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.Items.cs — new test methods on the TestContainer-based internal framework (TestFramework.ForTestingMSTest), which has no parallel scheduler (effective scope off). The added methods only exercise local, per-instance helper classes (CountTrackingCollection, CountTrackingEnumerable, ThrowingCountCollection) with no static fields, environment variables, current-directory/culture mutation, or shared filesystem paths.
• test/IntegrationTests/MSTest.Acceptance.IntegrationTests/TelemetryTests.cs — the added assertions live inside an embedded synthetic test-project string (#file UnitTest1.cs) used to generate a throwaway test asset at run time; they are not compiled test methods of the acceptance assembly itself, so this is not new parallel-execution surface for that assembly.

No .runsettings, testconfig.json, .csproj/.props/.targets, or assembly-level [Parallelize]/[DoNotParallelize] attribute was changed by this PR.

Audited TestFramework.UnitTests at scope off (TestContainer engine, no scheduler). No parallelization-state changes detected for MSTest.Acceptance.IntegrationTests.

_{Re-run with /parallel-audit.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 40.1 AIC · ⌖ 2.92 AIC · ⊞ 24.8K · [◷]( · ◷)

[github-actions]

🧪 Expert test review — PR #10575

This PR adds a non-generic ICollection fast path to Assert.HasCount/Assert.IsEmpty (using Count instead of enumerating), preserves the existing null-argument behavior, and backs it with focused unit and acceptance tests. All reviewed tests are well-targeted, verify observable behavior (not just return values), and would catch realistic regressions (e.g., accidentally falling back to enumeration, dropping the null-check, or over/under-counting telemetry).

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new AssertTests. Count_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Verifies the fast path both returns the right count and never enumerates.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountDiffers_ ShouldPreserveFailureMessage	3/3 killed	Pins the exact failure message plus access-count/no-enumeration invariants.	—
A (90–100)	new AssertTests. Count_ NonGenericICollection_ WhenCountThrows_ ShouldPropagateWithoutEnumerating	2/2 killed	Confirms an exception from Count propagates and the collection is never enumerated.	—
A (90–100)	new AssertTests. Count_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms plain IEnumerable (no ICollection) still takes the enumerating path.	—
A (90–100)	new AssertTests. Count_ NonGenericNullCollection_ ShouldPreserveException	2/2 killed	Locks in ArgumentNullException with ParamName == "source" for both HasCount and IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericICollection_ ShouldUseCountWithoutEnumerating	2/2 killed	Same fast-path guarantee as HasCount, applied to IsEmpty.	—
A (90–100)	new AssertTests. IsEmpty_ NonGenericIEnumerable_ ShouldEnumerate	1/1 killed	Confirms IsEmpty still enumerates plain IEnumerable sources.	—
A (90–100)	mod TelemetryTests. MTP_ RunTests_ SendsTelemetryWithSettingsAndAttributes	2/2 killed	Regex-checks exact telemetry counts, catching accidental double-tracking or tracking the null short-circuit.	—
A (90–100)	new UnitTest1. NonGenericCountAssertions	4/4 killed	End-to-end asset test exercises success and null-argument paths for both HasCount and IsEmpty.	—

No high-confidence actionable findings — every reviewed test asserts meaningful, mutation-sensitive behavior with tight diagnostics (custom CountTrackingCollection/ThrowingCountCollection test doubles even guard against silently falling back to enumeration). No inline suggestions posted.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 85.3 AIC · ⌖ 3.78 AIC · ⊞ 16.9K · [◷]( · ◷)