Cover superseded retry slow-test tracking

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

SlowTestReporterBase must keep tracking a test node when a terminal update represents a superseded retry attempt, because a later attempt is still running. This adds focused coverage so that behavior cannot regress unnoticed.

The test sends an in-progress update followed by a failed superseded retry update, then verifies the slow-test notice still appears after the threshold. The shared test message helper now accepts optional retry metadata.

Testing

• GitHubActionsSlowTestReporterTests: 12 passed

Fixes#10825

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: Clean — no issues found.

This PR adds a focused unit test (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) that exercises the IsSupersededRetryAttempt() guard in SlowTestReporterBase.ConsumeAsync (line 147 of SlowTestReporterBase.cs). I verified the production code: when a terminal update carries a superseded retry attempt, the test is intentionally not removed from _inProgress, so the slow-test scan continues to surface it. The test correctly validates this by:

1. Sending an InProgress message to start tracking.
2. Sending a Failed message with RetryAttemptProperty(1, isSuperseded: true) — this should not stop tracking.
3. Running ScanOnceAsync past the threshold and asserting a notice was still emitted.

Dimension	Finding
Algorithmic Correctness	✅ Test logic matches production behavior at the IsSupersededRetryAttempt() branch.
Test Quality	✅ Follows existing test patterns (ConsumeAsync_TerminalState_StopsTrackingAsync, ConsumeAsync_ExecutionCompleted_StopsTrackingAsync). Naming is clear and consistent.
API Surface	✅ No public API changes — CreateMessage helper gains an optional RetryAttemptProperty? parameter, internal to the test file.
Style & Conventions	✅ Consistent with codebase style.
All other dimensions	N/A — this is a test-only change with no production code, localization, public API, or cross-TFM impact.

No inline comments needed — the diff is clean and well-scoped.

[github-actions]

🧪 Expert test review — PR #10840

Grade	Test	Mutation	Notes	How to improve
A (90–100)	new GitHubActionsSlowTestReporterTests. ConsumeAsync_ SupersededRetryAttempt_ KeepsTrackingAsync	2/2 killed	Directly exercises the new IsSupersededRetryAttempt guard, verifying tracking survives a superseded terminal update and the scan still emits the notice at threshold.	—

Only one production-facing test method changed in this PR: GitHubActionsSlowTestReporterTests.ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync (new). The CreateMessage helper was also extended with an optional retryAttempt parameter but is not itself a test. The new test correctly asserts both that the notice is still emitted (proving the in-progress test was not dropped) and that the message content matches the expected test name, giving good coverage against inverting or removing the !update.TestNode.IsSupersededRetryAttempt() check in SlowTestReporterBase.ConsumeAsync. No actionable findings.

_{This advisory comment was generated automatically. Grades are heuristic and informational — they do not block merging. Suggestions on the Files changed tab can be applied with one click. Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 44.3 AIC · ⌖ 1.1 AIC · ⊞ 16.9K · [◷]( · ◷)

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds focused regression coverage ensuring superseded retry attempts remain tracked by the slow-test reporter.

Changes:

• Tests superseded terminal retry handling.
• Extends the message helper with optional retry metadata.

File	Description
GitHubActionsSlowTestReporterTests.cs	Adds retry-tracking coverage and helper support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🧵 Parallel-safety audit — PR #10840

Parallelization — test assembly audited:

Test assembly	Scope	Workers	Analyzer coverage
Microsoft.Testing.Extensions.UnitTests	MethodLevel ([assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in Program.cs)	CPU count	coverable once MSTEST0074–0077 ship (attribute-based opt-in)

Only one file changed: test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsSlowTestReporterTests.cs, which adds a new [TestMethod] (ConsumeAsync_SupersededRetryAttempt_KeepsTrackingAsync) and extends the private CreateMessage helper with an optional retryAttempt parameter.

Findings: A (global-state) 0 · B (paths) 0 · C (declaration) 0 · D (over-serialization) 0 — by severity: Critical 0 · High 0 · Warning 0 · Info 0.

Nothing in the new test or the extended helper touches process-global state, shared filesystem paths, or [ResourceLock]/[DoNotParallelize] declarations:

• All state is local to the test method: a fresh CapturingOutputDevice, GitHubActionsSlowTestReporter, and FixedClock are constructed per test (as every sibling test in this class already does), so nothing is shared across concurrently-running tests.
• The shared private static readonly DateTimeOffset Start field is read-only after initialization — not mutated by this or any other test in the class — so it is not a race.
• CreateMessage's new retryAttempt parameter only adds a property to a locally-created PropertyBag; no static or process-wide state is touched.
• No environment variables, current directory, console redirection, culture, or filesystem paths are involved.
• No [ResourceLock] / [DoNotParallelize] declarations were added, removed, or already exist in this file, so there is no declaration-reconciliation (category C) concern.

This is a clean, additive unit test change with no parallel-safety impact under the detected MethodLevel scope.

_{Advisory only — heuristic, non-blocking. Re-run with /parallel-audit. This audit answers "is it parallel-safe?"; for testability, smells, or flakiness see the detect-static-dependencies / test-smell-detection / test-anti-patterns analyses.}

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 69.9 AIC · ⌖ 1.1 AIC · ⊞ 24.8K · [◷]( · ◷)