Skip to content

Deployment Item support in .NET Core - #565

Merged
ankit-nitd-zz merged 36 commits into
microsoft:masterfrom
ankit-nitd-zz:depItemNetCore
Apr 2, 2019
Merged

Deployment Item support in .NET Core#565
ankit-nitd-zz merged 36 commits into
microsoft:masterfrom
ankit-nitd-zz:depItemNetCore

Conversation

@ankit-nitd-zz

Copy link
Copy Markdown

Implementing deployment Item functionality in net core

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Feb 8, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment threadsrc/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj Outdated
@abhishkk

Copy link
Copy Markdown
Contributor

Please write RFC for this support. Currently we don't have documentation for DeploymentItem in mstest v2. So, write RFC for entire DeploymentItem support.

@abhishkk

Copy link
Copy Markdown
Contributor

Sign CLA agreement

@abhishkk

Copy link
Copy Markdown
Contributor

<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

As this resource file is moved to another path and also linking i used in csproj for this resource file, please validate whether resources from this file is appearing correctly in .NET desktop and .NET core for scenarios


Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.resx:62 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

@abhishkk

Copy link
Copy Markdown
Contributor

As we have moved files and used linking, can you check that resources are working fine for another language?


Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/xlf/Resource.ja.xlf:1 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

Comment threadsrc/Adapter/MSTest.CoreAdapter/MSTest.CoreAdapter.csproj Outdated
Comment threadsrc/Adapter/MSTest.CoreAdapter/MSTest.CoreAdapter.csproj
@ankit-nitd-zz

Copy link
Copy Markdown
Author

<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

As this resource file is moved to another path and also linking i used in csproj for this resource file, please validate whether resources from this file is appearing correctly in .NET desktop and .NET core for scenarios

Refers to: src/Adapter/PlatformServices.Shared/netstandard1.3/Resources/Resource.resx:62 in 16739e0. [](commit_id = 16739e0, deletion_comment = False)

validated

Comment threadsrc/Adapter/PlatformServices.Desktop/Deployment/AssemblyLoadWorker.cs Outdated
Comment threadsrc/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj Outdated
Comment threadsrc/Adapter/PlatformServices.Desktop/PlatformServices.Desktop.csproj Outdated
Comment threadsrc/Adapter/PlatformServices.NetCore/Deployment/AssemblyLoadWorker.cs Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ankit-nitd-zz@msftclas@abhishkk@singhsarab@jayaranigarg@cltshivash@ankit-arora12