Skip to content

Support for CancellationTokenSource in TestContext to help in timeout… - #585

Merged
Shiva Shankar (cltshivash) merged 4 commits into
microsoft:masterfrom
cltshivash:master
Mar 28, 2019
Merged

Support for CancellationTokenSource in TestContext to help in timeout…#585
Shiva Shankar (cltshivash) merged 4 commits into
microsoft:masterfrom
cltshivash:master

Conversation

@cltshivash

@cltshivashShiva Shankar (cltshivash) commented Mar 16, 2019

Copy link
Copy Markdown
Contributor

Support for CancellationTokenSource in TestContext to help in timeout scenario

@acesiddhu

Siddhartha Pandey (acesiddhu) commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

do we have a RFC for this change?

@cltshivash

Shiva Shankar (cltshivash) commented Mar 18, 2019

Copy link
Copy Markdown
ContributorAuthor

do we have a RFC for this change?

Yes will author one.

singhsarab
Sarabjot Singh (singhsarab) reviewed Mar 19, 2019
View reviewed changes
Comment threadsrc/TestFramework/Extension.Shared/TestContext.cs Outdated
jayaranigarg
Jayarani garg (jayaranigarg) reviewed Mar 20, 2019
View reviewed changes
Comment threadsrc/Adapter/MSTest.CoreAdapter/Execution/TestMethodInfo.cs Outdated
Comment threadsrc/Adapter/PlatformServices.Desktop/Services/DesktopThreadOperations.cs Outdated
Comment threadsrc/Adapter/PlatformServices.Shared/netstandard1.0/Services/ns10TestContextImplementation.cs
Comment threadsrc/TestFramework/Extension.Shared/TestContext.cs Outdated
Comment threadtest/UnitTests/PlatformServices.Shared.Unit.Tests/netstandard1.0/ns10ThreadOperationsTests.cs
@jayaranigarg

Jayarani garg (jayaranigarg) commented Mar 20, 2019

Copy link
Copy Markdown
Member

I would encourage you to add E2E test for the scenario which shows how can user leverage this CancellationToken.

@cltshivash

Shiva Shankar (cltshivash) commented Mar 28, 2019

Copy link
Copy Markdown
ContributorAuthor

I would encourage you to add E2E test for the scenario which shows how can user leverage this CancellationToken.

Added E2E tests

singhsarab
Sarabjot Singh (singhsarab) reviewed Mar 28, 2019
View reviewed changes
Comment threadsrc/Adapter/MSTest.CoreAdapter/Resources/Resource.resx
<data name="UTA_TestMethodExpectedParameters" xml:space="preserve">
<value>Only data driven test methods can have parameters. Did you intend to use [DataRow] or [DynamicData]?</value>
</data>
<data name="Execution_Test_Cancelled" xml:space="preserve">

@singhsarabSarabjot Singh (singhsarab)Mar 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please xlf file changes associated with this change

@jayaranigargJayarani garg (jayaranigarg)Mar 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run command "build.cmd -uxlf". You would have to commit the xlf files changes post running the script.

singhsarab
Sarabjot Singh (singhsarab) reviewed Mar 28, 2019
View reviewed changes
Comment threadtest/E2ETests/TestAssets/TimeoutTestProject/TerimnateLongRunningTasksUsingTokenTestClass.cs
namespace TimeoutTestProject
{
[TestClass]
public class TerimnateLongRunningTasksUsingTokenTestClass

@singhsarabSarabjot Singh (singhsarab)Mar 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TerimnateLongRunningTasksUsingTokenTestClass [](start = 17, length = 44)

Nit: Terminate

@cltshivash
Shiva Shankar (cltshivash) merged commit 1990568 into microsoft:masterMar 28, 2019
@singhsarab

Sarabjot Singh (singhsarab) commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

Shiva Shankar (@cltshivash) Can you please add an RFC for this. If added already, please add the link here. Thanks.

@jayaranigargJayarani garg (jayaranigarg) mentioned this pull request Apr 24, 2019
Closed
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Jul 22, 2025
Closed
This was referenced Aug 4, 2025
Closed
Closed
Open
This was referenced Apr 23, 2026
Closed
Closed
This was referenced May 1, 2026
Closed
Closed
Open
Closed
Open
This was referenced May 14, 2026
Closed
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Jun 3, 2026
Closed
Closed
@dependabotdependabotBot mentioned this pull request Jun 18, 2026
Closed
This was referenced Jun 25, 2026
Closed
Merged
@dependabotdependabotBot mentioned this pull request Jul 16, 2026
Closed
@dependabotdependabotBot mentioned this pull request Jul 30, 2026
Closed
This was referenced Aug 7, 2026
Closed
Open
Closed
Merged
This was referenced Sep 2, 2026
Open
Closed
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@singhsarabSarabjot Singh (singhsarab)singhsarab left review comments
@jayaranigargJayarani garg (jayaranigarg)jayaranigarg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cltshivash@acesiddhu@jayaranigarg@singhsarab