Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637

Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged

Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom
revert-7600-dev/ygerges/polluted-output

Conversation

@Youssef1313

@Youssef1313Youssef Fahmy (Youssef1313) commented Mar 31, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#7612

CopilotAI review requested due to automatic review settings March 31, 2026 07:08
CopilotAI reviewed Mar 31, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.

Changes:

  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.

@Youssef1313

Youssef Fahmy (Youssef1313) commented Mar 31, 2026

Copy link
Copy Markdown
MemberAuthor

Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.

CopilotAI commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...

Implemented in commit 467e567.

Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:

  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output

Files changed:

  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes

CopilotAI changed the title Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313) marked this pull request as ready for review March 31, 2026 10:48
CopilotAI review requested due to automatic review settings March 31, 2026 10:48
CopilotAI reviewed Mar 31, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs Outdated
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI review requested due to automatic review settings March 31, 2026 10:57
CopilotAI reviewed Mar 31, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI review requested due to automatic review settings March 31, 2026 11:45
CopilotAI reviewed Mar 31, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

@Youssef1313

Youssef Fahmy (Youssef1313) commented Mar 31, 2026

Copy link
Copy Markdown
MemberAuthor

CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.

Evangelink
Amaury Levé (Evangelink) reviewed Mar 31, 2026
View reviewed changes

@EvangelinkAmaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.

CopilotAI commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.

Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:

  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)

CopilotAI review requested due to automatic review settings March 31, 2026 14:28
CopilotAI reviewed Mar 31, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs

CopilotAI commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

We should have some acceptance tests for the new options and their values.

Copilot Address this comment.

Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):

  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one

@Youssef1313

Youssef Fahmy (Youssef1313) commented Mar 31, 2026

Copy link
Copy Markdown
MemberAuthor

CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.

@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI review requested due to automatic review settings March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313) removed the request for review from CopilotMarch 31, 2026 19:49

CopilotAI commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.

Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.

@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2026
Closed
Evangelink
Amaury Levé (Evangelink) reviewed Apr 1, 2026
View reviewed changes

@EvangelinkAmaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.

The implementation is clean and follows existing patterns well. A few items to address:

  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI review requested due to automatic review settings April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313) removed the request for review from CopilotApril 1, 2026 12:14
CopilotAI review requested due to automatic review settings April 1, 2026 13:07
CopilotAI reviewed Apr 1, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313) merged commit 4b12ce9 into mainApr 1, 2026
14 checks passed
@Youssef1313
Youssef Fahmy (Youssef1313) deleted the revert-7600-dev/ygerges/polluted-output branch April 1, 2026 19:24
This was referenced Apr 1, 2026
Closed
Closed
@kommundsenKim Ommundsen (kommundsen) mentioned this pull request May 9, 2026
Closed
@EvangelinkAmaury Levé (Evangelink) mentioned this pull request Jun 1, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2

4 participants

@Youssef1313@Evangelink
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options - #7637
Merged
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Apr 1, 2026
Merged
Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr options#7637
Youssef Fahmy (Youssef1313) merged 10 commits into
mainfrom 
revert-7600-dev/ygerges/polluted-output
Conversation
@Youssef1313
@Youssef1313Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#7612
CopilotAI
review requested due to automatic review settings
March 31, 2026 07:08
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reverts a prior change that suppressed printing captured stdout/stderr in terminal reporting, restoring “Standard output” / “Error output” sections in detailed test output across ANSI and non-ANSI terminals.
Changes:
  • Restore propagation and rendering of StandardOutputProperty / StandardErrorProperty in TerminalOutputDevice → TerminalTestReporter.
  • Update terminal reporter unit tests to validate the restored output formatting (ANSI/simple ANSI/non-ANSI, including progress-frame output).
  • Add an MSTest acceptance integration test verifying detailed output includes the expected standard/error output sections, and add the required localized resource strings.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.csUpdates expected terminal output to include standard/error output blocks for multiple terminal modes.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/OutputTests.csAdds acceptance coverage ensuring --output detailed includes the standard/error output sections.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlfAdds translations for the new StandardOutput / StandardError resource entries across all supported locales in this folder.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resxAdds StandardOutput / StandardError resource strings used by terminal formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.csRestores reading standard output/error properties from test nodes and passes them into terminal reporting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.csRestores rendering of standard output/error output blocks in test-completed output.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it defaults to all.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
Copilot Implement --show-stdout and --show-stderr command-line options. The command-line option should accept exactly one argument which is one of all, failed, or none. If not specified, it...
Implemented in commit 467e567.
Added --show-stdout and --show-stderr command-line options that each accept all (default), failed, or none:
  • all — show captured output for all tests (default behavior)
  • failed — show captured output only for failed/error/timeout/canceled tests
  • none — never show captured output
Files changed:
  • TerminalTestReporterCommandLineOptionsProvider.cs — registered the two new options with ArgumentArity.ExactlyOne and added argument validation
  • TerminalTestReporterOptions.cs — added OutputShowMode enum and ShowStdout/ShowStderr properties
  • TerminalOutputDevice.cs — reads the new options and passes them to TerminalTestReporterOptions
  • TerminalTestReporter.cs — applies the options in RenderTestCompleted() to conditionally pass stdout/stderr to the formatter
  • PlatformResources.resx — added description strings and error message for the new options
  • TerminalTestReporterTests.cs — added two unit tests verifying none and failed modes
CopilotAI
changed the title
Revert "Avoid printing stdout/stderr properties in console (#7600)"Revert "Avoid printing stdout/stderr properties in console (#7600)" and add --show-stdout/--show-stderr optionsMar 31, 2026
@Youssef1313
Youssef Fahmy (Youssef1313)
marked this pull request as ready for review
March 31, 2026 10:48
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:48
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 15 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Outdated

Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
Comment threadsrc/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
CopilotAI
review requested due to automatic review settings
March 31, 2026 10:57
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
CopilotAI
review requested due to automatic review settings
March 31, 2026 11:45
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Evangelink
Amaury Levé (Evangelink)
reviewed
Mar 31, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some acceptance tests for the new options and their values.
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WhenMSTestExtensionRegistered_OutputHelpContentOfRegisteredExtension is failing.
Fixed in commit 7cc2308. Updated the expected --help output in all three help info test files to include the new --show-stderr and --show-stdout options:
  • MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs (both the --help and --info patterns)
  • Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs (both the --help and --info patterns)
CopilotAI
review requested due to automatic review settings
March 31, 2026 14:28
CopilotAI
reviewed
Mar 31, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
We should have some acceptance tests for the new options and their values.
Copilot Address this comment.
Added acceptance tests in commit c2f8fdd in ShowOutputOptionTests.cs. The new tests cover all four key scenarios using a test asset with both a passing and failing test (each writing distinct stdout/stderr messages):
  • ShowStdout_None_NeverShowsStandardOutput — --show-stdout none suppresses all stdout output
  • ShowStdout_Failed_ShowsStandardOutputOnlyForFailedTests — --show-stdout failed shows stdout only for the failing test, not the passing one
  • ShowStderr_None_NeverShowsErrorOutput — --show-stderr none suppresses all stderr output
  • ShowStderr_Failed_ShowsErrorOutputOnlyForFailedTests — --show-stderr failed shows stderr only for the failing test, not the passing one
@Youssef1313
Youssef Fahmy (Youssef1313)
commented
Mar 31, 2026

Copy link


Copy Markdown

MemberAuthor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
@Youssef1313
Fix Help_WithAllExtensionsRegistered_OutputFullHelpContent: correct a…
cced0c7
…lphabetical ordering of extension options
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/7720e902-46f9-4abb-8ab4-4667485117f9
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
March 31, 2026 19:49
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotMarch 31, 2026 19:49
CopilotAI
commented
Mar 31, 2026

Copy link


Copy Markdown

Contributor
CopilotHelp_WithAllExtensionsRegistered_OutputFullHelpContent is failing.
Fixed in commit cced0c7. The expected Extension options: in Help_WithAllExtensionsRegistered_OutputFullHelpContent had --show-stderr/--show-stdout before --report-trx, but alphabetically r comes before s. Swapped the order so --report-trx/--report-trx-filename now appear before --show-stderr/--show-stdout.
@github-actionsgithub-actionsBot
mentioned this pull request
Mar 31, 2026

Closed

Evangelink
Amaury Levé (Evangelink)
reviewed
Apr 1, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach — giving users control via --show-stdout/--show-stderr is much better than the blanket suppression from #7600.
The implementation is clean and follows existing patterns well. A few items to address:
  1. Naming consistency — errorOutput parameter should be standardError to match the rest of the chain
  2. Unreachable default arms — the _ => cases in the OutputShowMode switches should use ApplicationStateGuard.Unreachable() per codebase convention
  3. Test coverage — missing acceptance tests for explicit all, default behavior, and invalid argument validation
  4. Default value — discussed offline, keeping All for backward compatibility now with plan to switch to Failed in the next major
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterOptions.cs
Comment threadtest/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs
@Youssef1313
Address review feedback: rename errorOutput to standardError, use Unr…
e86889b
…eachable(), add more acceptance tests
Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/8d276482-3c57-4566-a196-9ed5bdb23fb2
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
April 1, 2026 12:14
@Youssef1313
Youssef Fahmy (Youssef1313)
removed the request for review
from CopilotApril 1, 2026 12:14
CopilotAI
review requested due to automatic review settings
April 1, 2026 13:07
CopilotAI
reviewed
Apr 1, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Comment threadsrc/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
@Youssef1313
Youssef Fahmy (Youssef1313)
merged commit 4b12ce9
into
mainApr 1, 2026

14 checks passed

@Youssef1313
Youssef Fahmy (Youssef1313)
deleted the

revert-7600-dev/ygerges/polluted-output

branch
April 1, 2026 19:24

This was referenced Apr 1, 2026

Closed


Closed

@kommundsenKim Ommundsen (kommundsen)
mentioned this pull request
May 9, 2026

Closed

@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jun 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code reviewCopilotCopilot left review comments
@EvangelinkAmaury Levé (Evangelink)Evangelink approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Revise recent output change before shipping 4.2


4 participants

@Youssef1313@Evangelink