[Test Improver] Add unit tests for TimeSpanParser by Evangelink · Pull Request #7858 · microsoft/testfx

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

Amaury Levé (Evangelink) · 2026-04-27T07:57:42Z

Fixes#7852

Add 116 tests covering TimeSpanParser.TryParse and Parse methods: - Null/empty/whitespace inputs return false / throw FormatException - No suffix parses as milliseconds (e.g. '5400000' = 5400 seconds) - ms/mil suffix (case-insensitive) parses as milliseconds - s/sec/secs/second/seconds suffix parses as seconds - m/min/mins/minute/minutes suffix parses as minutes - h/hour/hours suffix parses as hours - d/day/days suffix parses as days - Decimal values (e.g. '1.5s') - Space between value and suffix (regex allows \s*) - TryParse and Parse are consistent for valid inputs - Invalid inputs (non-numeric, no leading digit) return false / throw Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds a new unit test suite for Microsoft.Testing.Platform.Helpers.TimeSpanParser, which is used by Microsoft.Testing.Platform to parse human-friendly timeout/duration strings.

Changes:

Introduces TimeSpanParserTests covering TryParse and Parse for common suffixes (ms/s/m/h/d) and invalid inputs.
Adds coverage for whitespace inputs, “no suffix” inputs (milliseconds), and some decimal/whitespace-before-suffix scenarios.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs	New MSTest-based unit tests for `TimeSpanParser` parsing behaviors

Copilot's findings

Comments suppressed due to low confidence (1)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs:165

TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly doesn't validate the parsed value/unit, and expectedMs is unused (also misleading for inputs like "5 m" which should be minutes). Consider asserting the expected TimeSpan for each case (or renaming the parameter) so the test verifies behavior rather than only non-zero output.

 [TestMethod]
[DataRow("5 s", 5)]
[DataRow("5 ms", 5)]
[DataRow("5 m", 5)]
public void TryParse_SpaceBetweenValueAndSuffix_ParsesCorrectly(string input, double expectedMs)
{
// The regex allows optional whitespace before suffix
bool result = TimeSpanParser.TryParse(input, out TimeSpan value);
Assert.IsTrue(result);
Assert.AreNotEqual(TimeSpan.Zero, value);
}

Files reviewed: 1/1 changed files
Comments generated: 4

CopilotAI review requested due to automatic review settings April 27, 2026 07:57

Amaury Levé (Evangelink) enabled auto-merge (squash) April 27, 2026 07:57

Copilotstarted reviewing on behalf of Amaury Levé (Evangelink)April 27, 2026 07:58 View session

CopilotAI reviewed Apr 27, 2026
View reviewed changes

YuliiaKovalova approved these changes Apr 27, 2026
View reviewed changes

Amaury Levé (Evangelink) merged commit b6d6b9d into mainApr 27, 2026
49 checks passed

Amaury Levé (Evangelink) deleted the test-assist/timespan-parser-unit-tests-eabf1f50849ca30c branch April 27, 2026 10:02

github-actionsBot mentioned this pull request Apr 28, 2026
[Test Improver] Monthly Activity 2026-04 #7791
Closed

Amaury Levé (Evangelink) mentioned this pull request May 1, 2026
[Test Improver] Monthly Activity 2026-05 #7969
Closed
5 tasks

This was referenced May 14, 2026
[Test Improver] Monthly Activity 2026-05 #8206
Closed
[Test Improver] Monthly Activity 2026-05 #8301
Closed
[Test Improver] Monthly Activity 2026-05 #8373
Closed

Amaury Levé (Evangelink) mentioned this pull request May 22, 2026
[Test Improver] Monthly Activity 2026-05 #8482
Closed
2 tasks