Eliminate delegate allocation in AbortForMaxFailedTestsExtension

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠

[Copilot]

AbortForMaxFailedTestsExtension.ConsumeAsync used .Any(t => t == ...) to check whether a test node's state property is a known failure type, allocating a Func<Type, bool> delegate on every call.

Change

Replace the LINQ call with Array.IndexOf, consistent with the same check already in TestApplicationResult.cs:

// Before — allocates a delegate per callTestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t =>t==testNodeStateProperty.GetType())// After — no allocation
Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties,testNodeStateProperty.GetType())!=-1

One heap object saved per consumed TestNodeUpdateMessage in the hot path.

[Copilot]

Pull request overview

This PR optimizes a hot-path check in AbortForMaxFailedTestsExtension by removing a per-call LINQ delegate allocation when determining whether a TestNodeStateProperty represents a failure outcome type.

Changes:

• Replace Any(t => t == ...) with Array.IndexOf(..., ...) != -1 for membership testing against the well-known “failed outcome” Type[].

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs	Removes LINQ-based type membership check in ConsumeAsync to avoid delegate allocation in a hot path.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Summary

Workflow: Expert Code Reviewer 🧠
Date: 2026-04-29
Repository: microsoft/testfx

Key Findings

No issues found. The change is correct, semantically equivalent, and consistent with the existing codebase pattern.

Verification points:

• Any(t => t == x) and Array.IndexOf(..., x) != -1 both use reference equality for Type objects. Type instances are runtime singletons in .NET, so both return identical results.
• The same Array.IndexOf pattern is already used in TestApplicationResult.cs, RetryDataConsumer.cs, and TrxReportEngine.cs for the exact same WellKnownTestNodeTestRunOutcomeFailedProperties array — this PR brings AbortForMaxFailedTestsExtension into alignment with those.
• The optimization is real: removing the Func<Type, bool> delegate allocation on every ConsumeAsync call in a hot path (one message per test node update) is a meaningful improvement at scale.
• No threading concerns introduced — the changed expression is side-effect-free and stateless.
• No public API surface is affected; the class is internal sealed.

Recommendations

None — the change is minimal, purposeful, and well-aligned with the existing codebase idiom.

---

Generated by Expert Code Reviewer

🧠 Reviewed by Expert Code Reviewer 🧠