Uh oh!
There was an error while loading. Please reload this page.
Address PR #8104 review feedback for LoggingManager.BuildAsync unit tests - #8112
Address PR #8104 review feedback for LoggingManager.BuildAsync unit tests#8112Amaury Levé (Evangelink) with Copilot wants to merge 4 commits into
LoggingManager.BuildAsync unit tests#8112Conversation
Tests cover: - AddProvider with null throws ArgumentNullException - BuildAsync with no providers returns empty factory - Factory delegate receives correct LogLevel and IServiceProvider - Non-IExtension provider is always included - Enabled IExtension provider is included - Disabled IExtension provider is excluded - IAsyncInitializableExtension provider has InitializeAsync called - Disabled IAsyncInitializableExtension provider does not have InitializeAsync called Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
LoggingManager.BuildAsync unit testsAmaury Levé (Evangelink)
commented
May 11, 2026
Copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
Pull request overview
This PR updates the unit tests for Microsoft.Testing.Platform.Logging.LoggingManager.BuildAsync to address review feedback from PR #8104 by strengthening assertions and adding coverage for the “enabled + async-initializable extension” provider path, without changing production behavior.
Changes:
- Strengthens the “no providers” test to validate the returned factory can actually create a logger.
- Adds coverage for a provider that is both
IExtension(enabled) andIAsyncInitializableExtension, asserting inclusion, initialization, andCreateLoggerinvocation. - Applies small readability improvements (consistent mock naming and explicit discards for intentionally unused return values).
Show a summary per file
| File | Description |
|---|---|
| test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs | Adds/updates LoggingManager.BuildAsync unit tests to tighten assertions and cover the enabled+initializable extension provider scenario. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Resolved. I merged I attempted to run |
Original prompt
Created from VS Code.