Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 310
[Test Improver] Add unit tests for LoggingManager.BuildAsync#8124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
| using Microsoft.Testing.Platform.Extensions; | ||
| using Microsoft.Testing.Platform.Helpers; | ||
| using Microsoft.Testing.Platform.Logging; | ||
| using Moq; | ||
| namespace Microsoft.Testing.Platform.UnitTests; | ||
| [TestClass] | ||
| public sealed class LoggingManagerTests | ||
| { | ||
| private readonly Mock<IMonitor> _mockMonitor = new(); | ||
| private readonly Mock<IServiceProvider> _mockServiceProvider = new(); | ||
| public LoggingManagerTests() | ||
| => _mockMonitor.Setup(m => m.Lock(It.IsAny<object>())).Returns(new Mock<IDisposable>().Object); | ||
| [TestMethod] | ||
| public void AddProvider_NullFactory_ThrowsArgumentNullException() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Assert.ThrowsExactly<ArgumentNullException>(() => manager.AddProvider(null!)); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_NoProviders_ReturnsNonNullFactory() | ||
| { | ||
| LoggingManager manager = new(); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| Assert.IsNotNull(factory); | ||
| factory.CreateLogger("smoke"); | ||
| } | ||
| [TestMethod] | ||
| [DataRow(LogLevel.Trace)] | ||
| [DataRow(LogLevel.Warning)] | ||
| [DataRow(LogLevel.Critical)] | ||
| public async Task BuildAsync_PassesCorrectLogLevelAndServiceProviderToFactory(LogLevel level) | ||
| { | ||
| LogLevel capturedLevel = default; | ||
| IServiceProvider? capturedServiceProvider = null; | ||
| LoggingManager manager = new(); | ||
| Mock<ILoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object); | ||
| manager.AddProvider((level, sp) => | ||
| { | ||
| capturedLevel = level; | ||
| capturedServiceProvider = sp; | ||
| return mockProvider.Object; | ||
| }); | ||
| await manager.BuildAsync(_mockServiceProvider.Object, level, _mockMonitor.Object); | ||
| Assert.AreEqual(level, capturedLevel); | ||
| Assert.IsNotNull(capturedServiceProvider, "Factory was not invoked"); | ||
| Assert.AreSame(_mockServiceProvider.Object, capturedServiceProvider); | ||
Evangelink marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_NonExtensionProvider_IsAlwaysIncluded() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<ILoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object); | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| factory.CreateLogger("test"); | ||
| mockProvider.Verify(p => p.CreateLogger("test"), Times.Once); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_EnabledExtensionProvider_IsIncluded() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<IExtensionLoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.IsEnabledAsync()).ReturnsAsync(true); | ||
| mockProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object); | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| factory.CreateLogger("test"); | ||
| mockProvider.Verify(p => p.CreateLogger("test"), Times.Once); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_DisabledExtensionProvider_IsExcluded() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<IExtensionLoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.IsEnabledAsync()).ReturnsAsync(false); | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| factory.CreateLogger("test"); | ||
| mockProvider.Verify(p => p.CreateLogger(It.IsAny<string>()), Times.Never); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_InitializableExtensionProvider_WhenEnabled_CallsInitializeAsync() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<IInitializableExtensionLoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.IsEnabledAsync()).ReturnsAsync(true); | ||
| mockProvider.Setup(p => p.InitializeAsync()).Returns(Task.CompletedTask); | ||
| mockProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object); | ||
Evangelink marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| factory.CreateLogger("test"); | ||
| mockProvider.Verify(p => p.InitializeAsync(), Times.Once); | ||
Evangelink marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| mockProvider.Verify(p => p.CreateLogger("test"), Times.Once); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_InitializableExtensionProvider_WhenDisabled_DoesNotCallInitializeAsync() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<IInitializableExtensionLoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.IsEnabledAsync()).ReturnsAsync(false); | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| mockProvider.Verify(p => p.InitializeAsync(), Times.Never); | ||
| } | ||
| [TestMethod] | ||
| public async Task BuildAsync_NonExtensionInitializableProvider_CallsInitializeAsync() | ||
| { | ||
| LoggingManager manager = new(); | ||
| Mock<IInitializableLoggerProvider> mockProvider = new(); | ||
| mockProvider.Setup(p => p.InitializeAsync()).Returns(Task.CompletedTask); | ||
| mockProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object); | ||
Evangelink marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| manager.AddProvider((_, _) => mockProvider.Object); | ||
| ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object); | ||
| factory.CreateLogger("test"); | ||
| mockProvider.Verify(p => p.InitializeAsync(), Times.Once); | ||
Evangelink marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| mockProvider.Verify(p => p.CreateLogger("test"), Times.Once); | ||
| } | ||
| } | ||
| internal interface IExtensionLoggerProvider : ILoggerProvider, IExtension; | ||
| internal interface IInitializableLoggerProvider : ILoggerProvider, IAsyncInitializableExtension; | ||
| internal interface IInitializableExtensionLoggerProvider : ILoggerProvider, IExtension, IAsyncInitializableExtension; | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.