[Efficiency Improver] perf: eliminate yield-iterator and GroupBy allocations in IsIgnored() hot path by Evangelink · Pull Request #8195 · microsoft/testfx

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

Amaury Levé (Evangelink) · 2026-05-13T17:51:59Z

IsIgnored() is called twice per test execution (class + method check in
UnitTestRunner). The original implementation always allocated:

A compiler-generated yield-iterator state machine via GetAttributes()
A GroupBy Lookup, even when the source sequence is empty

This change walks GetCustomAttributesCached() directly:

Fast path (no condition attrs, most common): 0 allocations
Single-attr path: 0 extra allocations — evaluates directly
Multi-attr path: List + GroupBy (same as before, minus state machine)

For a 10,000-test suite with no ignored tests:
~20,000 state machine objects eliminated (~960 KB)
~20,000 GroupBy Lookup objects eliminated
Net: ~40,000 fewer objects / ~1 MB less GC pressure per run

Proxy metric: heap allocation count → GC pressure → energy consumption.
GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC
CPU overhead per unit of test work.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Fixes#8159

…path IsIgnored() is called twice per test execution (class + method check in UnitTestRunner). The original implementation always allocated: - A compiler-generated yield-iterator state machine via GetAttributes<T>() - A GroupBy Lookup, even when the source sequence is empty This change walks GetCustomAttributesCached() directly: - Fast path (no condition attrs, most common): 0 allocations - Single-attr path: 0 extra allocations — evaluates directly - Multi-attr path: List<T> + GroupBy (same as before, minus state machine) For a 10,000-test suite with no ignored tests: ~20,000 state machine objects eliminated (~960 KB) ~20,000 GroupBy Lookup objects eliminated Net: ~40,000 fewer objects / ~1 MB less GC pressure per run Proxy metric: heap allocation count → GC pressure → energy consumption. GSF: Hardware Efficiency — fewer managed allocations reduce DRAM and GC CPU overhead per unit of test work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-05-13T17:52:08Z

Copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T17:57:58Z

Copilot resolve the merge conflicts in this pull request

Merged origin/main into the PR branch. The only conflict was in AttributeHelpers.cs — the main branch already contains an improved version of the same optimization (using Dictionary + groupOrder instead of LINQ GroupBy), so I took that version as the resolution.

Copilot

Copilot wasn't able to review any files in this pull request.

Amaury Levé (Evangelink) · 2026-05-13T18:01:50Z

Copilot address review comments

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T18:08:43Z

Copilot address review comments

Addressed in commit perf: collapse IsIgnored() to a single pass over allAttributes. The Dictionary and List are now lazily initialized (??=) inside the loop, so the separate first-pass scan is gone. The common case (no ConditionBaseAttribute) does a single iteration with zero allocations. The single-attribute fast-path duplication was already eliminated when the merge resolved the conflict by taking the unified grouping implementation from origin/main.

CopilotAI review requested due to automatic review settings May 13, 2026 17:52

Copilotstarted work on behalf of Amaury Levé (Evangelink)May 13, 2026 17:52 View session

Merge origin/main and resolve conflict in AttributeHelpers.cs
2313944
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilotfinished work on behalf of Amaury Levé (Evangelink)May 13, 2026 17:58

CopilotAI reviewed May 13, 2026
View reviewed changes

Comment threadsrc/Adapter/MSTestAdapter.PlatformServices/Helpers/AttributeHelpers.cs Outdated
Comment threadsrc/Adapter/MSTestAdapter.PlatformServices/Helpers/AttributeHelpers.cs Outdated

Copilotstarted reviewing on behalf of Amaury Levé (Evangelink)May 13, 2026 18:00 View session

Copilotstarted work on behalf of Amaury Levé (Evangelink)May 13, 2026 18:02 View session

perf: collapse IsIgnored() to a single pass over allAttributes
8aa493c
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilotfinished work on behalf of Amaury Levé (Evangelink)May 13, 2026 18:09

Amaury Levé (Evangelink) mentioned this pull request May 13, 2026
[Efficiency Improver] Monthly Activity 2026-05 #7975
Closed
2 tasks

Amaury Levé (Evangelink) enabled auto-merge (squash) May 14, 2026 07:39

Amaury Levé (Evangelink) disabled auto-merge May 14, 2026 07:43

Amaury Levé (Evangelink) merged commit 0f01130 into mainMay 14, 2026
10 checks passed

Amaury Levé (Evangelink) deleted the efficiency/optimize-isignored-allocs-1778609590-612a40a2cdae11a1 branch May 14, 2026 07:43