Uh oh!
There was an error while loading. Please reload this page.
[docs] Update glossary - weekly full scan - #8318
Conversation
Documents the new machine-readable JSON test discovery output mode introduced by PR #8280. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the glossary documentation to cover the new --list-tests json machine-readable discovery output mode introduced for Microsoft.Testing.Platform.
Changes:
- Adds a glossary entry for
--list-tests json. - Documents supported invocation forms and output behavior.
- Summarizes the JSON schema v1 structure and omitted-field behavior.
Show a summary per file
| File | Description |
|---|---|
| docs/glossary.md | Adds documentation for the JSON test discovery output mode and schema summary. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Review Summary — PR #8318[docs] Update glossary - weekly full scan
Documentation-only PR. Applied all 21 review dimensions; most are N/A.
| Dimension | Result |
|---|---|
| 1. Algorithmic Correctness | N/A |
| 2. Threading & Concurrency | N/A |
| 3. Security & IPC Contract Safety | N/A |
| 4. Public API & Binary Compatibility | N/A |
| 5. Performance & Allocations | N/A |
| 6. Cross-TFM Compatibility | N/A |
| 7. Resource & IDisposable Management | N/A |
| 8. Defensive Coding at Boundaries | N/A |
| 9. Localization & Resources | N/A |
| 10. Test Isolation | N/A |
| 11. Assertion Quality | N/A |
| 12. Flakiness Patterns | N/A |
| 13. Test Completeness & Coverage | N/A |
| 14. Data-Driven Test Coverage | N/A |
| 15. Code Structure & Simplification | N/A |
| 16. Naming & Conventions | N/A |
| 17. Documentation Accuracy | |
| 18. Analyzer & Code Fix Quality | N/A |
| 19. IPC Wire Compatibility | N/A |
| 20. Build Infrastructure & Dependencies | N/A |
| 21. Scope & PR Discipline | LGTM |
Findings (NITs)
typefield description incomplete (line 91): The list of sub-fields insidetypeis missingreturnTypeFullNameand uses "class" instead of the actual field nametypeName. Cross-checked againstDiscoveredTestsJsonSerializer.WriteTestNode.Alphabetical ordering (line 81):
--list-tests json(key:list-tests, "li...") sorts after all "Lean..." ("le...") entries, so the block should sit after### Lean Squad, not between### Lean–C# Correspondence (FV)and### Lean Squad.
Both are cosmetic NITs and do not block merge.
Generated by Expert Code Review (on open) for issue #8318 · ● 7M
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Amaury Levé (Evangelink)
commented
May 18, 2026
Copilot address review comments |
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Documents the new machine-readable JSON test discovery output mode
introduced by PR #8280.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Fixes#8309