Uh oh!
There was an error while loading. Please reload this page.
Skip expert-reviewer agentic workflow on OneLocBuild localization PRs - #8635
Conversation
OneLocBuild check-in PRs (authored by dotnet-bot, titled 'Localized file check-in...') are pure generated XLF updates that do not benefit from expert code review. Extend the review-on-open agentic workflow's 'if:' guard to skip them, matching the same detection pattern used by enable-auto-merge.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the expert-reviewer “on open” agentic workflow to avoid running on OneLocBuild localization PRs (pure generated .xlf check-ins), reducing unnecessary automation noise while preserving the existing “non-draft PR opened” trigger for normal contributor PRs.
Changes:
- Extend the workflow-level
if:guard inreview-on-open.agent.mdto skip PRs authored bydotnet-botwhose title starts withLocalized file check-in. - Regenerate and commit the strict-mode compiled workflow
review-on-open.agent.lock.ymlso the runtime jobs (pre_activation,activation) reflect the new guard.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/review-on-open.agent.md | Adds an if: guard to skip OneLocBuild “Localized file check-in” PRs from dotnet-bot. |
| .github/workflows/review-on-open.agent.lock.yml | Recompiled lock file reflecting the new skip condition in job if: expressions. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
| # | Dimension | Verdict |
|---|---|---|
| 4 | Documentation Accuracy | 🟨 1 NIT |
✅ 20/21 dimensions clean.
- Documentation — Comment says "human-authored PRs" but logic runs for all bots except
dotnet-bot+ "Localized file check-in" prefix
Summary:
The logic is correct and matches the pattern in enable-auto-merge.yml. The guard successfully skips OneLocBuild localization PRs while preserving expert-reviewer runs for:
- Human-authored PRs
dotnet-botPRs with non-localization titles- All other bot PRs (
dotnet-maestro[bot], etc.)
The compiled .lock.yml is correctly generated with updated metadata hash and guard propagation to both pre_activation and activation jobs.
Only issue is a minor documentation clarity improvement in the comment (see inline comment).
Generated by Expert Code Review (on open) for issue #8635 · ● 2.6M
Uh oh!
There was an error while loading. Please reload this page.
Amaury Levé (Evangelink)
commented
May 27, 2026
🔍 Build Failure AnalysisSummary — The build failed due to an invalid XLIFF 1.2 file ( Root cause: Malformed XLIFF file from OneLocBuildThe XLF localization file Affected project: Origin: Commit 41fd1ac (PR #8631) - "Localized file check-in by OneLocBuild Task" Why this PR is affectedThis PR (#8635) only modifies workflow files ( Proposed fixOption 1: Revert the bad XLF file to the last known good version The XLF file needs to be regenerated or manually fixed. The XLIFF 1.2 schema validation is strict about element ordering within Option 2: Rebuild localization files Run the localization rebuild process to regenerate all XLF files from the source # Standard .NET localization rebuild (exact command depends on your repo setup)
dotnet build /t:UpdateXlfOption 3: Manual intervention on main branch Since the problem is in Build overview
All MSBuild errors (1)
🤖 Generated by the Build Failure Analysis workflow · commit ${GH_AW_PR_HEAD_SHA}
|
Uh oh!
There was an error while loading. Please reload this page.
Stops the
expert-revieweragentic workflow from running on OneLocBuild localization check-in PRs (e.g. #8634), which are pure generated.xlfupdates that don't benefit from expert review.Change
Extends the
if:guard in.github/workflows/review-on-open.agent.mdto also skip when both:github.event.pull_request.user.login == 'dotnet-bot'startsWith(github.event.pull_request.title, 'Localized file check-in')This is the same detection pattern already used by
.github/workflows/enable-auto-merge.ymlfor these PRs.The recompiled
review-on-open.agent.lock.ymlis included in the commit (strict-mode compile, no warnings).What this does NOT fix
The
copilot-pull-request-reviewer[bot]review on the same PR is GitHub's Copilot code review product. It is not driven by repo workflows and can only be filtered via repo Settings → Copilot (path filters in Code review settings, or Content exclusion for patterns like**/xlf/**). That has to be configured by an admin in the UI.Notes
/review(review.agent.md) is intentionally left alone — it's opt-in.dotnet-maestro[bot]dependency-flow PRs are NOT included in this skip; happy to extend if desired.