[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions - #8739

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028
Jun 2, 2026
Merged

[perf-improver] perf: eliminate per-call string allocation in AnsiTerminal.SetColor and use HashSet for KnownFileExtensions#8739
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028

Conversation

@Evangelink

Copy link
Copy Markdown
Member

🤖 This is an automated contribution from Perf Improver.

Goal and Rationale

Two allocation hotspots in the terminal output path:

  1. AnsiTerminal.SetColor — Every call to SetColor(TerminalColor) built a new string via $"{AnsiCodes.CSI}{(int)color}{AnsiCodes.SetColor}". This happens during every live-progress render frame (once per assembly × 3 color changes per row × every 500 ms). There are only 17 possible TerminalColor values, so the strings can be pre-computed.

  2. KnownFileExtensions — The 13-element string[] was scanned linearly by Array.Contains on every AppendLink call (triggered for each failed-test file link in the run summary). A HashSet<string> gives O(1) lookup.

Approach

  1. Added AnsiCodes.GetSetColorEscapeCode(TerminalColor) — a switch expression that returns interned compile-time string literals (e.g. "\x1b[32m") for every known color. No heap allocation for common cases. Falls back to string interpolation for any unexpected future value.

  2. AnsiTerminal.SetColor now calls AnsiCodes.GetSetColorEscapeCode(color) instead of building the string inline.

  3. Changed KnownFileExtensions from private static readonly string[] to private static readonly HashSet<string> initialized with StringComparer.Ordinal (preserving the existing case-sensitive behaviour).

Performance Evidence

SiteBeforeAfter
AnsiTerminal.SetColor (per call)1 × string allocation (~6–8 bytes, formatting)0 — returns interned literal
KnownFileExtensions.ContainsO(n) — up to 13 comparisonsO(1) HashSet lookup
Frame-level colour allocations (10 assemblies, 500 ms cadence)~30 strings/sec0

Methodology: code inspection + diff review. The switch expression returns literal strings which the runtime interns; no heap allocation occurs.

Trade-offs

  • AnsiCodes gains one method (~20 lines). The switch explicitly enumerates all 17 TerminalColor values; adding a new value without updating the switch falls back to the interpolated string (no regression).
  • KnownFileExtensions is now a HashSet (one allocation at class init) instead of an array. The comparer is Ordinal to preserve existing case-sensitivity.

Test Status

  • Microsoft.Testing.Platform.UnitTests (net8.0): 995 passed, 0 failed, 3 skipped

Reproducibility

./build.sh
artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Generated by Perf Improver · sonnet46 7.6M ·

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/perf-improver.md@main

…nd use HashSet for KnownFileExtensions
- Add AnsiCodes.GetSetColorEscapeCode(TerminalColor) with a switch expression
that returns interned string literals for each known VT100 color code, avoiding
a heap allocation on every SetColor call during terminal progress rendering.
- Change KnownFileExtensions from string[] to HashSet<string> (StringComparer.Ordinal)
so that AppendLink's extension check is O(1) instead of O(n).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 1, 2026 16:14
@EvangelinkAmaury Levé (Evangelink) added area/performance Runtime / build performance / efficiency. type/automation Created or maintained by an agentic workflow. labels Jun 1, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Microsoft.Testing.Platform (MTP) ANSI terminal output path by removing two small but frequent allocation/lookup hotspots during progress rendering and link generation.

Changes:

  • Avoid per-call string interpolation in AnsiTerminal.SetColor by routing through a precomputed escape-code mapping.
  • Replace linear extension lookup (string[] + Contains) with a HashSet<string> for O(1) membership checks in AppendLink.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminal.csUses HashSet<string> for known file extensions and calls the new escape-code helper in SetColor.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiCodes.csAdds GetSetColorEscapeCode(TerminalColor) returning precomputed ANSI color escape sequences.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) June 2, 2026 06:26
@Evangelink
Amaury Levé (Evangelink) merged commit 42bc37b into mainJun 2, 2026
28 of 29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the perf-assist/ansi-terminal-alloc-reduction-b9fe2463258bb028 branch June 2, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performanceRuntime / build performance / efficiency.type/automationCreated or maintained by an agentic workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@JanKrivanek