Add Azure DevOps result-level attachments and run-level coverage upload

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M

[Amaury Levé (Evangelink)]

Part of #5951 — direction 3b (Result-level attachments).

Now that the live-publishing groundwork (#8295, #8297, #8298) is merged, this PR auto-attaches per-test artifacts and code coverage to the Azure DevOps Tests tab while the run is in progress.

What this does

For each failed/error/timeout/cancelled test result that the publisher streams to AzDO, after the batch is accepted and the per-result IDs come back, the publisher uploads (best effort):

• Every FileArtifactProperty on the TestNode (dumps, screenshots, log files…) as a GeneralAttachment to /Runs/{runId}/Results/{resultId}/attachments.
• StandardOutputProperty as stdout.log (ConsoleLog type), truncated at 256 KB inline with a ...[truncated] marker.
• StandardErrorProperty as stderr.log (GeneralAttachment type), same truncation.

Passing tests get no attachments by design (privacy/bandwidth).

For the run itself, the publisher now consumes SessionFileArtifact and uploads *.coverage, *.cobertura.xml, and *.opencover.xml to /Runs/{runId}/attachments with the CodeCoverage attachment type. Each process uploads what it sees on its own message bus — no owner-only directory scan, so no duplicates.

Key design decisions (refined via rubber-duck pass)

1. No retry of attachments via the publishing queue.PublishTestResultsAsync now returns Task<IReadOnlyList<int>?>. null means "AzDO accepted the batch but the response can't be parsed back to per-result IDs" — callers skip attachments and must not retry (to avoid double-publishing results). Only HTTP transport failures throw and feed the existing 3-attempt retry stack.
2. ID-to-result matching is validated. The parser checks response[i].automatedTestName == submitted[i].AutomatedTestName before trusting the IDs. Mismatch ⇒ returns null.
3. 16 MB per-file cap, enforced client-side in TryBuildAttachmentRequest. Larger files are silently skipped (matches AzDO's own limits and avoids base64 OOM).
4. 5-minute attachment HttpClient timeout (vs the default 100s) to accommodate large dump payloads.
5. OfType().FirstOrDefault() for stdout/stderr (not SingleOrDefault — duplicate properties shouldn't crash the publisher).

Test coverage

Added 9 new unit tests on top of the existing 22:

• ConsumeAsync_UploadsAttachmentsForFailedTests — file + stdout + stderr go to the right endpoints with the right types.
• ConsumeAsync_DoesNotUploadAttachmentsForPassedTests — passed outcome ⇒ zero attachment calls.
• ConsumeAsync_AttachmentUploadFailureLogsWarningAndDoesNotRetryPublish — upload exception logs AzureDevOpsLivePublishingResultAttachmentFailed and publishes the result only once.
• ConsumeAsync_PublishReturnsNullSkipsAttachmentsAndDoesNotRetry — ID-parse failure path skips attachments + warns.
• ConsumeAsync_SkipsOversizedFileAttachment — publisher forwards both files; the client's size cap is responsible for filtering.
• ConsumeAsync_TruncatesLargeStdoutInline — verifies the 256 KB cap and ...[truncated] marker.
• OnTestSessionFinishingAsync_UploadsCoverageSessionFileArtifacts — *.cobertura.xml / *.opencover.xml / *.coverage all uploaded as CodeCoverage.
• OnTestSessionFinishingAsync_SkipsNonCoverageSessionFileArtifacts — random *.log ignored.
• OnTestSessionFinishingAsync_CoverageUploadFailureLogsWarning — warns with AzureDevOpsLivePublishingRunAttachmentFailed.

All 31 AzureDevOpsLivePublishingTests and all 92 ClassName~AzureDevOps tests pass on net9.0.

Files changed

• AzureDevOpsLivePublishingModels.cs — constants, AzureDevOpsAttachmentTypes, wrapper + attachment record with factories.
• IAzureDevOpsTestResultsClient.cs — new return type + two new upload methods.
• AzureDevOpsTestResultsClient.cs — response parsing, attachment URI builders, TryBuildAttachmentRequest with size cap, attachment payload DTO.
• AzureDevOpsTestResultsPublisher.cs — SessionFileArtifact consumption, attachment building, FlushPendingResultsAsync ID capture + per-result upload, OnTestSessionFinishingAsync coverage drain.
• AzureDevOpsResources.resx + 13 xlf files — 3 new warning strings.
• PACKAGE.md — live publishing + automatic attachments listed under features.
• AzureDevOpsLivePublishingTests.cs — updated existing fake client + 9 new tests.

Out of scope (still open in #5951)

• Direction 4 (publish --report-trx TRX as an artifact for completeness when live publishing is on).
• Direction 5 (telemetry / metrics emission).
• A user-facing opt-out flag for per-test attachments (deferred to first-feedback).

[Copilot]

Pull request overview

This PR extends the Azure DevOps live test-results publisher in Microsoft.Testing.Extensions.AzureDevOpsReport to upload result-level attachments (file artifacts + stdout/stderr) for failing tests and run-level code coverage attachments (*.coverage, *.cobertura.xml, *.opencover.xml) during the run lifecycle. It also updates the REST client contract to return server-assigned result IDs so attachments can be posted to the correct result rows.

Changes:

• Change live result publishing to return per-result IDs and use them to upload per-result attachments (best-effort, no re-publish on ID-parse failure).
• Add run-level attachment upload for coverage session artifacts.
• Update unit tests, PACKAGE.md feature list, and localized resources for new warnings.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs	Updates fake client contract (publish returns IDs) and adds unit tests for result/run attachment behaviors.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx	Adds new warning strings for attachment upload failures and ID-parse failure.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.cs.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.de.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.es.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.fr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.it.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ja.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ko.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pl.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.pt-BR.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.ru.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.tr.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hans.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/xlf/AzureDevOpsResources.zh-Hant.xlf	Regenerates localization entries for the new resource strings.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/PACKAGE.md	Documents live publishing + automatic attachments as package features.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/IAzureDevOpsTestResultsClient.cs	Updates publish API to return IDs (or null) and adds upload methods for result/run attachments.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsPublisher.cs	Builds/queues attachments, uploads per-result attachments after publish, and uploads run-level coverage attachments at session finish.
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsTestResultsClient.cs	Implements publish response parsing for IDs and adds REST calls + payload building for attachments (size cap, timeouts).
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLivePublishingModels.cs	Adds attachment constants/types and attachment DTOs used by publisher/client.

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 6

[Amaury Levé (Evangelink)]

Review Summary — PR #8782

The overall design is sound: clear separation between result-level and run-level attachments, the null-return contract on PublishTestResultsAsync correctly prevents double-publishing on ID-parse failure, and the concurrency model (_flushSemaphore guarding _retryResults, ConcurrentQueue for the other collections) is correct. The xlf files were regenerated by the build tool (all new entries have state="new" with source-text placeholders), so that's fine per repo guidelines.

Dimension	Finding	Severity
Performance & Allocations	TruncateInline: per-character char[1] heap allocation via [ch] collection expression	MAJOR
Algorithmic Correctness	TruncateInline: truncation at a high surrogate produces an invalid UTF-16 string	MODERATE
Algorithmic Correctness	TryBuildAttachmentRequest: TOCTOU between fileInfo.Length check and ReadAllBytes	MODERATE
Test Completeness	TruncateInline boundary cases not tested (exact-limit, multi-byte chars, surrogate straddling budget)	MODERATE
All other dimensions (17)	✅ Clean	—

No blocking issues found. The three moderate findings should be addressed before merge; the performance finding in particular is straightforward to fix.

Generated by Expert Code Review (on open) for issue #8782 · sonnet46 4.2M

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 6.1M

[Copilot]

Copilot's findings

• Files reviewed: 20/20 changed files
• Comments generated: 3

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build fails in AzureDevOpsLivePublishingTests.cs due to two analyzer violations in newly-added test code: one IDE0053 (lambda should use expression body) and five MSTEST0037 (use Assert.Contains instead of Assert.IsTrue + .Any()).

i️ /tmp/binlog-data/ was not populated by the pre-agent steps; analysis was performed directly from /tmp/build-output.log and the workspace source.

---

Root cause 1: IDE0053 — Block-body lambda where expression body is required

The new ConsumeAsync_SkipsOversizedFileAttachment test assigns UploadTestResultAttachmentAsyncFunc using a block-body lambda whose sole statement is return Task.CompletedTask;. The project enforces IDE0053 as an error, so this must be an expression-body lambda.

Affected files / errors

• test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLivePublishingTests.cs:518 — IDE0053: Use expression body for lambda expression

Proposed fix — collapse the block body (the inline comments can be removed or moved to a separate comment above):

- client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) =>- {- // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest- // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end- // when running against the real client. For the unit test we only assert what the publisher sends.- return Task.CompletedTask;- };+ // The publisher still queues the oversized attachment; the client side TryBuildAttachmentRequest+ // drops it. In this fake we just record the call regardless — the contract is exercised end-to-end+ // when running against the real client. For the unit test we only assert what the publisher sends.+ client.UploadTestResultAttachmentAsyncFunc = (_, _, _, attachment, _) => Task.CompletedTask;

---

Root cause 2: MSTEST0037 — Assert.IsTrue(...Any(...)) should be Assert.Contains

Five assertions in two new tests use Assert.IsTrue(collection.Any(predicate)) instead of the Assert.Contains(collection, predicate) overload that produces clearer failure messages and satisfies the MSTEST0037 analyzer rule.

Affected files / errors

Line	Collection	Predicate
537	UploadTestResultAttachmentCalls	FileName == "small.txt"
538	UploadTestResultAttachmentCalls	FileName == "big.bin"
621	UploadTestRunAttachmentCalls	FileName == "results.cobertura.xml"
622	UploadTestRunAttachmentCalls	FileName == "results.opencover.xml"
623	UploadTestRunAttachmentCalls	FileName == "results.coverage"

Proposed fix (same pattern for all five):

- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "small.txt"));- Assert.IsTrue(client.UploadTestResultAttachmentCalls.Any(c => c.Attachment.FileName == "big.bin"));+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "small.txt");+ Assert.Contains(client.UploadTestResultAttachmentCalls, c => c.Attachment.FileName == "big.bin");

---

All MSBuild errors (6 unique, each repeated for net8.0 and net9.0)

Code	File:Line	Message
IDE0053	AzureDevOpsLivePublishingTests.cs:518	Use expression body for lambda expression
MSTEST0037	AzureDevOpsLivePublishingTests.cs:537	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:538	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:621	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:622	Use Assert.Contains instead of Assert.IsTrue
MSTEST0037	AzureDevOpsLivePublishingTests.cs:623	Use Assert.Contains instead of Assert.IsTrue

---

_{🤖 Generated by the Build Failure Analysis workflow using build output log · commit 1f62231}

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M · ◷

[Amaury Levé (Evangelink)]

Generated by Build Failure Analysis for issue #8782 · sonnet46 8.3M