Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping) - #9338

Merged
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration
Jun 22, 2026
Merged

Fix double registration in MSTest.AotReflection.SourceGeneration PoC and make it packable (non-shipping)#9338
Amaury Levé (Evangelink) merged 2 commits into
microsoft:mainfrom
Evangelink:evangelink/fix-aot-poc-double-registration

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Two fixes to the experimental MSTest.AotReflection.SourceGeneration PoC:

  1. Fix double test registration. The PoC .csproj<Compile Include>-ed MSTest.SourceGeneration's ReflectionMetadataGenerator.cs — which is itself decorated with [Generator]. As a result, the PoC analyzer assembly ran two source generators, and each emitted a [ModuleInitializer] that called ReflectionMetadataHook.Register(...) for the same assembly:

    • MSTestSourceGeneratedReflectionMetadata (shipping generator, 3-arg Register)
    • MSTestAotSourceGeneratedReflectionMetadata (PoC generator, 5-arg Register)

    CompositeSourceGeneratedReflectionDataProvider appends both providers with no de-duplication, so every test class was discovered twice. A trivial 2-test project reported 4 passing tests.

    The PoC's own RuntimeRegistrationEmitter already emits a complete and strictly richer registration (5-arg overload carrying materialized type/assembly attributes) plus [DynamicDependency] rooting, so the shared shipping generator was redundant. The three shared Compile includes (ReflectionMetadataGenerator.cs, ReflectionMetadataEmitter.cs, TestAssemblyMetadata.cs) — none of which were referenced by any PoC source — are removed. Only one [ModuleInitializer] is emitted now.

  2. Make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation. The generator dll is packed under analyzers/dotnet/cs. The package lands in artifacts/packages/<config>/NonShipping and is not published.

Verification

  • MSTest.AotReflection.SourceGeneration.UnitTests: 66/66 pass.
  • Stood up a minimal consuming project that references the generator as an analyzer:
    • Before: a 2-test project reported total: 4 (each test discovered twice).
    • After: reports total: 2, and only the PoC's generated files are emitted (the duplicate Sample.MSTestReflectionMetadata.g.cs from the shipping generator is gone).
  • dotnet pack produces MSTest.AotReflection.SourceGeneration.<ver>.nupkg in NonShipping, with the analyzer dll at analyzers/dotnet/cs/.

Notes

This remains a PoC tracked by #1837. The reflection-free registry it emits is still not consumed by the adapter (runtime discovery continues to go through ReflectionMetadataHook + [DynamicDependency]), which is out of scope for this change.

…and make it packable (non-shipping)
The PoC analyzer assembly compiled in MSTest.SourceGeneration's ReflectionMetadataGenerator (which is itself [Generator]), so referencing the PoC ran two source generators. Each emitted a [ModuleInitializer] calling ReflectionMetadataHook.Register for the same assembly, registering it twice with the composite provider and doubling discovered test counts (a 2-test project reported 4).
The PoC's own RuntimeRegistrationEmitter already emits a complete, richer (5-arg, attribute-carrying) registration plus DynamicDependency rooting, so the shared shipping generator was redundant. Remove the three shared Compile includes (generator, emitter, model) that nothing in the PoC referenced; only one ModuleInitializer is emitted now and a sample reports the correct test count.
Also make the project packable as a non-shipping package (IsPackable=true, IsShipping=false) so it can be consumed locally for experimentation; the generator dll is packed under analyzers/dotnet/cs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes duplicate MSTest registration in the experimental MSTest.AotReflection.SourceGeneration generator by removing shared “shipping” generator sources, and makes the PoC packable as a non-shipping NuGet analyzer for local experimentation.

Changes:

  • Remove shared MSTest.SourceGeneration generator/emitters/models Compile Includes to prevent double [ModuleInitializer] registration.
  • Enable packing (IsPackable=true, IsShipping=false) and add a pack rule to place the analyzer DLL under analyzers/dotnet/cs.
  • Update package description metadata to a dedicated PackageDescription.
Show a summary per file
FileDescription
src/Analyzers/MSTest.AotReflection.SourceGeneration/MSTest.AotReflection.SourceGeneration.csprojRemoves shared generator sources to prevent double registration; enables non-shipping packing and adds analyzer packing entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit c6839b9 into microsoft:mainJun 22, 2026
51 of 58 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the evangelink/fix-aot-poc-double-registration branch June 22, 2026 12:36
Amaury Levé (Evangelink) added a commit that referenced this pull request Jun 22, 2026
…ounts
After the build progresses past the restore/compile fixes, verify-nupkgs.ps1
fails because MSTest.AotReflection.SourceGeneration (made packable as a
non-shipping PoC in #9338) is a 4.3.0 package not present in the expected
file-count table, so it is validated with an empty expected value. Add it with
its actual content count (6: [Content_Types].xml, Icon.png, .nuspec, the
analyzer dll, .psmdcp, .rels).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101