Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add RFC 017: Custom test host launcher - #9349

Merged
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher
Jun 26, 2026
Merged

Add RFC 017: Custom test host launcher#9349
Amaury Levé (Evangelink) merged 7 commits into
mainfrom
docs/rfc-testhost-process-launcher

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds RFC 017 — Custom test host launcher (docs/RFCs/017-TestHost-Launcher.md).

The RFC proposes a public, experimental MTP extension point — ITestHostLauncher — that lets an extension control how the out-of-process test host is launched, instead of the platform always calling Process.Start. The platform keeps owning everything around the launch (argument/environment preparation, the controller↔host IPC pipe, PID tracking, ITestHostProcessLifetimeHandler callbacks, and exit-code reconciliation) and delegates only the single "create and start the test host" step.

The hook is deliberately agnostic of the launch mechanism ("we don't know if it's a process"): the launcher does not have to start a local OS process. It returns an ITestHostHandle (an IDisposable) that exposes only lifecycle (WaitForExitAsync(CancellationToken), ExitCode, HasExited, Terminate) plus an optional free-form string? Identifier used purely for diagnostics. This covers packaged-app activation, containers, and remote launches where no local PID exists.

The motivating scenario is testing packaged Windows apps — both UWP and packaged WinUI (which ship as MSIX and share the same deploy + AUMID-activate mechanism, the reason VSTest has a single UwpTestHostRuntimeProvider). This is the blocker behind #2784. The RFC also includes worked examples for debugger attach, elevation, container, and remote.

What changed since the first draft

This reworks the original process-centric draft to be generic:

  • ITestHostProcessLauncherITestHostLauncher; ITestHostProcessHandleITestHostHandle.
  • The mandatory int ProcessId is replaced by an optional free-form string? Identifier (diagnostics only); the redundant Exited event is dropped in favor of WaitForExitAsync; Kill()Terminate().
  • ITestHostHandle extends IDisposable, and WaitForExitAsync takes a CancellationToken (both supported by the runtime and the repo's netstandard2.0 polyfill).
  • File renamed 017-TestHost-Process-Launcher.md017-TestHost-Launcher.md.
  • Motivation reframed around packaged Windows apps (UWP + WinUI) rather than WinUI alone.
  • Documents the platform integration detail that makes PID-less launchers work (premature-exit gated on HasExited only).

Implementation

The hook is implemented, with a reference consumer (Microsoft.Testing.Extensions.PackagedApp) and unit + acceptance tests, in #9454.

Related: #2784, #9454

Proposes an experimental ITestHostProcessLauncher MTP extension point that lets an extension control how the out-of-process test host is launched (replacing Process.Start), enabling packaged WinUI/MSIX (AUMID activation, #2784), debugger, elevated, container, and remote launch scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 22, 2026 17:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new design document (RFC 017) proposing an experimental Microsoft.Testing.Platform extension point (ITestHostProcessLauncher) to let extensions customize how the out-of-process test host is launched, while keeping platform-owned responsibilities (args/env prep, IPC, lifetime handling, exit reconciliation) unchanged.

Changes:

  • Introduces RFC 017 documentation describing the proposed ITestHostProcessLauncher API surface and registration shape.
  • Documents intended platform integration points (controller host selection, launch-site delegation, singleton enforcement).
  • Provides worked examples (WinUI/MSIX activation, debugger attach, elevation, container, remote) plus alternatives and open questions.
Show a summary per file
FileDescription
docs/RFCs/017-TestHost-Process-Launcher.mdNew RFC describing an experimental extension point for customizing out-of-process test host process launching.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 4

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
- Fix TestHostOchestratorHost -> TestHostOrchestratorHost type name (the file name has the typo, the type does not)
- SSH example: EnvironmentVariables values are nullable; skip unset (null) vars instead of Quote(null)
- WinUI example: drop unnecessary async (no await) to avoid CS1998; return Task.FromResult
- Clarify #2784 relationship: it is titled for unpackaged WinUI, but this launcher serves both packaged (AUMID) and unpackaged WinUI scenarios
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'Alternatives' link pointed to #alternatives but the heading is 'Alternatives considered' (#alternatives-considered).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 24, 2026 08:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Process-Launcher.md Outdated
Make the proposal agnostic of the launch mechanism ("we don't know if it's a
process"):
- Rename ITestHostProcessLauncher -> ITestHostLauncher and ITestHostProcessHandle
-> ITestHostHandle; demote ProcessId to an optional int? used only for
diagnostics; rename Kill() -> Terminate(). Rename the file accordingly
(017-TestHost-Process-Launcher.md -> 017-TestHost-Launcher.md).
- Frame the motivation around packaged Windows apps (UWP and packaged WinUI share
the same MSIX deploy + AUMID-activate mechanism) while keeping debugger, elevation,
container, and remote as worked examples.
- Document the platform integration detail that makes PID-less launchers work
(premature-exit gated on HasExited only) and reference the implementation
(Microsoft.Testing.Extensions.PackagedApp) and PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) changed the title Add RFC 017: Custom test host process launcherAdd RFC 017: Custom test host launcherJun 26, 2026
- Contract: phrase env-var delivery as "the host must end up with the values in
context.EnvironmentVariables" (mechanism left to the launcher) instead of
"must receive", since AUMID activation cannot inject per-launch env vars.
- Packaged WinUI/MSIX example: stop claiming MSTestRunnerWinUI demonstrates the
controller pipe handshake (it self-hosts in-process); escape/quote the activation
args instead of string.Join(' ', ...) so quoting is preserved; spell out that the
launcher must bridge the pipe name / correlation id another way.
- Fix MD051: link fragment #alternatives -> #alternatives-considered.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 26, 2026 11:42

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
- Drop the redundant Exited event from ITestHostHandle (consumers use
WaitForExitAsync); the platform synthesizes the internal informational event from
the exit task.
- Replace the int? ProcessId with an optional free-form string Identifier
(diagnostics only: PID, container id, remote host:pid, ...), since the handle is
mechanism-agnostic.
- Fix remaining review nits: use Terminate() consistently (drop stray "Kill"
reference), filter null-valued env vars in the debugger/container examples
(consistent with the SSH example), and spell "queryable".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review June 26, 2026 12:37
CopilotAI review requested due to automatic review settings June 26, 2026 12:37
@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 26, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — only docs/RFCs/017-TestHost-Launcher.md changed (new file, 406 lines). Most of the 22 review dimensions (Threading, Performance, Security, Cross-TFM, IPC wire, Test Isolation, Analyzer Quality, etc.) are N/A. Dimensions evaluated: 17 — Documentation Accuracy and 21 — Scope & PR Discipline.


Scope & PR Discipline — ✅

  • RFC references the blocking issue (#2784) and the implementation PR (#9454).
  • Goals / Non-goals / Alternatives / Open Questions sections are all present and well-structured.
  • The design rationale (why ITestHostProcessLauncherITestHostLauncher, why not ITestHostExecutionOrchestrator, why not expose IProcessHandler) is thorough.

Documentation Accuracy — 4 findings

#SeverityFinding
1🟡 MODERATEWaitForExitAsync() has no CancellationToken parameter — platform cannot propagate overall-run cancellation cooperatively (inline comment on line 160)
2🟡 MODERATEITestHostHandle does not extend IDisposable — OS resources held by adapters (process handles, sockets) have no deterministic cleanup path via the platform (inline comment on line 163)
3🟡 MODERATEExitCode behavior is undefined when read before HasExited — implementers need a contract to code against (inline comment on line 158)
4⚪ NITQuote / PasteArguments helpers in Examples 1 and 5 are called but never defined or referenced, leaving a potential argument-injection pitfall for readers (inline comment on line 340)

✅ 20/22 dimensions clean (2 N/A, 2 have findings above).

  • WaitForExitAsync — add CancellationToken overload or document that callers must drive cancellation through Terminate()
  • ITestHostHandle — add IDisposable (or IAsyncDisposable) or add this to the Open Questions for #9454 to decide
  • ExitCode — document "must not be read before HasExited is true"
  • Example 5 — define or reference Quote, note it is a placeholder

Comment threaddocs/RFCs/017-TestHost-Launcher.md Outdated
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
Comment threaddocs/RFCs/017-TestHost-Launcher.md
- ITestHostHandle now extends IDisposable and WaitForExitAsync takes a
CancellationToken (both supported by the runtime and the netstandard2.0 polyfill).
The platform disposes the handle after exit and passes its cancellation token while
waiting, reconciling the real exit code afterwards.
- Document ExitCode-before-HasExited as undefined; note Quote/PasteArguments are
placeholders for proper argument quoting; fix the container example so Terminate()
tears down the container (docker stop) rather than only killing the local client.
- Record the design evolution in Alternatives.
Implemented in PR #9454.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Amaury Levé (Evangelink) merged commit f11f782 into mainJun 26, 2026
57 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the docs/rfc-testhost-process-launcher branch June 26, 2026 14:08
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 5, 2026
017 is already taken on main by 017-TestHost-Launcher.md (#9349), so rename
docs/RFCs/017-Artifact-Post-Processing.md -> 018-Artifact-Post-Processing.md.
Rework the design into a layered, decisive recommendation:
- Phase 1 (ship first): typed, invocation-agnostic IArtifactPostProcessor engine
contract (experimental) + a user-facing ITool per kind (merge-trx) sharing one
engine. Delivers user value with no SDK/protocol change (one platform-API change:
promote ITool to public).
- Phase 2: in-memory election (from data the SDK already has via handshake + live
FileArtifactMessages), a platform-owned internal dispatcher ITool, and merged
artifacts returned over the existing dotnet-test pipe as FileArtifactMessage.
- Election is minimal set-cover (fewest relaunches), arch-constrained for binary
coverage; live-channel alternative reframed to lead with reuse of the existing
pipe; experimental gating; cross-arch notes.
Also fixes markdownlint issues and corrects codebase-accuracy points surfaced in
review (ITool is internal today; TrxReportEngine has no file-merge path yet; no
--list-tools switch; public records must avoid synthesized init accessors).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101