[test-improver] test: add edge case tests for UseCancellationTokenPropertyAnalyzer (MSTEST0054)

[Amaury Levé (Evangelink)]

Goal and Rationale

UseCancellationTokenPropertyAnalyzer (MSTEST0054) had only 5 tests covering basic scenarios. Three meaningful boundary paths were untested:

Missing scenario	Why it matters
[TestInitialize] method (not just [TestMethod])	Verifies the analyzer fires on any method in a test class, not only test methods
Custom class with a CancellationTokenSource property	Verifies the symbol comparison is exact — only TestContext.CancellationTokenSource, not any identically named property
TestContext as a parameter (e.g., AssemblyInitialize)	Verifies the analyzer and fixer both handle the parameter-receiver pattern, not just the class-property pattern

Approach

Added three tests to UseCancellationTokenPropertyAnalyzerTests, each following the existing pattern:

1. WhenUsingCancellationTokenSourceInTestInitialize_ShouldReportDiagnostic — [TestInitialize] method accessing TestContext.CancellationTokenSource.Token; both the diagnostic and the → CancellationToken fix are verified.

2. WhenCustomClassHasCancellationTokenSourceProperty_ShouldNotReportDiagnostic — a non-TestContext class with a CancellationTokenSource property; no diagnostic expected, confirming the symbol equality check rejects non-TestContext types.

3. WhenUsingCancellationTokenSourceOnParameterInAssemblyInitialize_ShouldReportDiagnostic — [AssemblyInitialize] method where TestContext is a parameter (not a property); both the diagnostic and the fix are verified.

Test Status

Build: ✅ succeeded

File	Before	After
UseCancellationTokenPropertyAnalyzerTests	5	8

All 8 tests pass.

Reproducibility

.dotnet/dotnet test test/UnitTests/MSTest.Analyzers.UnitTests/MSTest.Analyzers.UnitTests.csproj \
-f net8.0 -c Debug \
--filter "FullyQualifiedName~UseCancellationTokenPropertyAnalyzerTests"

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Test Improver workflow. · 1.2K AIC · ⌖ 23.5 AIC · ⊞ 58K · [◷]( · ◷)

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/test-improver.md@main

[Copilot]

Pull request overview

This PR strengthens coverage for the MSTest analyzer MSTEST0054 (UseCancellationTokenPropertyAnalyzer) by adding targeted unit tests for previously untested boundary scenarios, ensuring both the analyzer and code fixer behave correctly across additional MSTest method shapes.

Changes:

• Added a diagnostic+code-fix test for CancellationTokenSource.Token usage inside a [TestInitialize] method.
• Added a negative test ensuring no diagnostic is produced for a non-TestContext type that happens to expose a CancellationTokenSource property.
• Added a diagnostic+code-fix test for TestContext provided as a method parameter (e.g., [AssemblyInitialize]), validating the parameter-receiver pattern.

Show a summary per file

File	Description
test/UnitTests/MSTest.Analyzers.UnitTests/UseCancellationTokenPropertyAnalyzerTests.cs	Adds three new edge-case tests covering [TestInitialize], a non-TestContext lookalike property, and TestContext as a parameter in [AssemblyInitialize].

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9355

3 new test methods graded in UseCancellationTokenPropertyAnalyzerTests. All three follow the standard Roslyn analyzer test pattern for this repo: a descriptive When...Should... name, concise inline code/fixedCode fixtures, and a single meaningful VerifyCodeFixAsync or VerifyAnalyzerAsync assertion that validates both diagnostic detection and fix correctness. No issues found across the batch.

Δ	Test	Grade	Band	Notes
new	UseCancellationTokenPropertyAnalyzerTests. WhenCustomClassHasCancellationTokenSourceProperty_ ShouldNotReportDiagnostic	A	90–100	No issues found.
new	UseCancellationTokenPropertyAnalyzerTests. WhenUsingCancellationTokenSourceInTestInitialize_ ShouldReportDiagnostic	A	90–100	No issues found.
new	UseCancellationTokenPropertyAnalyzerTests. WhenUsingCancellationTokenSourceOnParameterInAssemblyInitialize_ ShouldReportDiagnostic	A	90–100	No issues found.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 173.9 AIC · ⌖ 12.8 AIC · ⊞ 43.6K · [◷]( · ◷)