Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0 - #9508

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet
Jun 30, 2026
Merged

Fix Dependabot discovery of bundled Playwright; bump to 1.61.0#9508
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/jubilant-parakeet

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes#9362

Problem

Despite several attempts (#9365, #9422, #9452), Dependabot still never bumps the bundled Playwright version. As reported in #9362, it's stuck at 1.60.0 even though Microsoft.Playwright.MSTest.v4 1.61.0 has been published on nuget.org for days across multiple daily Dependabot runs.

Root cause

#9452 switched the Dependabot anchor for the bundled packages from a PackageReference (with ExcludeAssets="all") to a PackageDownload, on the theory that ExcludeAssets="all" hid the reference from Dependabot.

That theory is wrong on both counts:

  1. Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502). So after Fix Dependabot discovery of bundled Playwright via PackageDownload #9452 the Playwright anchor became invisible to Dependabot.
  2. ExcludeAssets="all" does NOT hide a PackageReference from Dependabot — it only stops the package's assets from flowing into the build. Dependabot reads the PackageReference XML node, not the asset-flow rules. So the original #9422 anchor was the correct mechanism.

Aspire's bump in #9446 actually came from its ExcludeAssetsPackageReference (present during the #9422#9452 window), not from its PackageDownload. Playwright simply had no newer release during that brief window (1.61 wasn't out yet); then #9452 removed the working anchor right before 1.61 shipped — and silently broke Aspire's discovery too (it only looks fine because it's already at latest).

Fix

  • MSTest.Acceptance.IntegrationTests.csproj — restore PackageReference ... ExcludeAssets="all" anchors (the kind Dependabot reads) for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing, while keeping the PackageDownload items for nupkg staging + *Version property correlation. Rewrote the comment to document the real Dependabot behavior. This dual-item layout is exactly what Aspire ran through green CI between Anchor SDK-bundled packages so Dependabot bumps them #9422 and Fix Dependabot discovery of bundled Playwright via PackageDownload #9452.
  • Directory.Packages.props — bump bundled Playwright 1.60.0 → 1.61.0 (both the MicrosoftPlaywrightVersion property and the literal Microsoft.Playwright.MSTest.v4PackageVersion, kept in sync so _ValidateBundledSdkFeatureVersions passes). Corrected the "condition 2" comment.

Verification

The change is config-only and structurally identical to the proven Aspire setup, so I'm confident in the MSBuild validity. The Dependabot behavior itself can only be confirmed on the next scheduled run against main.

#9452 switched the Dependabot anchor to PackageDownload, but Dependabot's NuGet ecosystem does not read PackageDownload items at all (dependabot/dependabot-core#2502), so the bundled Playwright version became invisible to Dependabot and stopped updating (1.61.0 was never proposed).
Restore the PackageReference (ExcludeAssets="all") anchor for both Microsoft.Playwright.MSTest.v4 and Aspire.Hosting.Testing - ExcludeAssets only stops assets flowing into the build, it does not hide the reference from Dependabot. Keep the PackageDownload items for nupkg staging and property correlation. Bump bundled Playwright 1.60.0 -> 1.61.0.
Fixes#9362
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how MSTest SDK–bundled packages are surfaced to Dependabot (so updates get proposed) and bumps the bundled Playwright version to 1.61.0.

Changes:

  • Restores PackageReference + ExcludeAssets="all" anchors (and keeps PackageDownload staging) for Playwright and Aspire in the MSTest acceptance integration test project.
  • Bumps MicrosoftPlaywrightVersion and the corresponding CPM PackageVersion for Microsoft.Playwright.MSTest.v4 from 1.60.0 to 1.61.0.
  • Updates in-file documentation to reflect Dependabot’s behavior and the intended anchor mechanism.
Show a summary per file
FileDescription
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csprojReintroduces Dependabot-visible PackageReference anchors while retaining PackageDownload entries used for nupkg staging.
Directory.Packages.propsUpdates Playwright version to 1.61.0 and revises the “Dependabot discovery” guidance/comments for bundled SDK packages.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

@Evangelink

This comment has been minimized.

…isleading PackageDownload
- Revert the manual 1.60.0 -> 1.61.0 bump: doing it here would leave the bundle at latest, so we couldn't tell whether the anchor fix actually let Dependabot propose the update. Leaving it at 1.60.0 means Dependabot's next run proposing 1.60.0 -> 1.61.0 is the proof the fix works.
- Drop the Playwright PackageDownload anchor and its misleading comment (flagged in review): Dependabot ignores PackageDownload entirely, and nothing consumes Playwright's nupkg (only Aspire's is staged by CopyNuGetPackagesForTestAssets). The PackageReference (ExcludeAssets="all") is the sole Dependabot anchor; Aspire keeps its PackageDownload purely for nupkg staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink

Copy link
Copy Markdown
MemberAuthor

🧪 Test quality grade — PR #9508

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 123.4 AIC · ⌖ 12.5 AIC · ⊞ 43.8K · [◷]( · )

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jun 29, 2026
@0101

Copy link
Copy Markdown
Member

Heads-up: this diff doesn't appear to include the version bump described in the Fix section.

The description says it bumps bundled Playwright 1.60.01.61.0 in Directory.Packages.props (both the MicrosoftPlaywrightVersion property and the Microsoft.Playwright.MSTest.v4PackageVersion), but at the current head both still read 1.60.0:

  • Directory.Packages.props (~line 40): <MicrosoftPlaywrightVersion>1.60.0</MicrosoftPlaywrightVersion>
  • Directory.Packages.props (~line 177): <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="1.60.0" />

The Directory.Packages.props hunks in the diff are limited to the comment block, and the PackageReference anchor restoration in MSTest.Acceptance.IntegrationTests.csproj looks correct. It just looks like the manual 1.61.0 edit didn't make it into the commits.

Could you double-check and push the version bump (so _ValidateBundledSdkFeatureVersions reflects it now rather than waiting on the next Dependabot run)? Alternatively, if this PR is meant to be the discovery-mechanism fix only, the title/description could be updated to match. Thanks!

@Evangelink
Amaury Levé (Evangelink) merged commit 51edbf7 into mainJun 30, 2026
39 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/jubilant-parakeet branch June 30, 2026 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled Playwright for .NET version in MSTest SDK

4 participants

@Evangelink@0101@drognanar