Allow --minimum-expected-tests 0 (#7457) - #9724

Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged

Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom
dev/amauryleve/allow-min-expected-tests-zero

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.

Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.

Why this is separate from #9709

Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.

Stacked on #9709

This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.

Change

  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).

Tests

  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.

Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink) mentioned this pull request Jul 8, 2026
Merged
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink) merged commit addaa4c into dev/amauryleve/curly-couscousJul 8, 2026
24 of 26 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/allow-min-expected-tests-zero branch July 8, 2026 11:54
github-actions[bot]
github-actionsBot reviewed Jul 8, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.

Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.

@github-actions

github-actionsBot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #9724

5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.

GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)

Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit that referenced this pull request Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Allow --minimum-expected-tests 0 (#7457) - #9724
Merged
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Jul 8, 2026
Merged
Allow --minimum-expected-tests 0 (#7457)#9724
Amaury Levé (Evangelink) merged 2 commits into
dev/amauryleve/curly-couscousfrom 
dev/amauryleve/allow-min-expected-tests-zero
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Summary
Follow-up to #9709, part of #7457 (item #2). Allows the literal value --minimum-expected-tests 0.
Previously validation rejected 0 (value <= 0). It now rejects only negative and non-integer values. Combined with the zero-tests verdict governance in #9709, an explicit --minimum-expected-tests 0 accepts an empty run and returns exit code 0 — the same outcome the reporter asked for in #7457 (""--minimum-expected-tests 0 should have the same outcome as --ignore-exit-code 8""). It gives users an explicit, opt-in ""zero tests is acceptable"" escape hatch per test host.
Why this is separate from #9709
Note: allowing a user-typed--minimum-expected-tests 0 is deliberately different from having the SDK auto-inject--min 0 into every module — the latter was rejected because older Microsoft.Testing.Platform versions reject --min 0 and the SDK cannot know a module's MTP version at argument-build time. Whoever types --min 0 explicitly owns that assumption.
Stacked on #9709
This PR targets the #9709 branch, because --minimum-expected-tests 0 + zero tests only resolves to success once #9709's verdict-governance logic is in place (otherwise the ZeroTests(8) verdict is computed first). Review/merge #9709 first; the diff here is only the validation change.
Change
  • PlatformCommandLineProvider.IsMinimumExpectedTestsOptionValidAsync: reject only value < 0.
  • Validation message: ""single non-zero positive integer"" → ""single non-negative integer"" (+ regenerated 13 PlatformResources.*.xlf via /t:UpdateXlf).
Tests
  • PlatformCommandLineProviderTests: 0 / 1 / 10 now valid; negatives / non-integers still invalid.
  • TestApplicationResultTests: --minimum-expected-tests 0 + zero tests → success.
  • ExecutionTests (acceptance): --filter-uid matching nothing + --minimum-expected-tests 0 → exit code 0; negative-value validation-message expectation updated.
Unit tests pass locally (110/110 across TestApplicationResultTests + PlatformCommandLineProviderTests). Acceptance tests require -pack and run in CI.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
@Evangelink
Allow --minimum-expected-tests 0 (#7457)
508c9d4
Validation now rejects only negative (or non-integer) values, so an explicit
'--minimum-expected-tests 0' is accepted. Combined with the zero-tests verdict
governance, a zero minimum accepts an empty run (exit code 0) -- the same
outcome as '--ignore-exit-code 8' -- giving users a per-module 'zero tests is
acceptable' opt-in.
Stacked on the verdict-governance change (#9709), which is what makes an
explicit '--minimum-expected-tests 0' with zero tests resolve to success
instead of the ZeroTests (exit code 8) verdict.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Update changelog PR link to#9724
2a48f91
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@EvangelinkAmaury Levé (Evangelink)
mentioned this pull request
Jul 8, 2026
 Merged

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 8, 2026 11:54
@Evangelink
Amaury Levé (Evangelink)
merged commit addaa4c
into
dev/amauryleve/curly-couscousJul 8, 2026

24 of 26 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/allow-min-expected-tests-zero

branch
July 8, 2026 11:54
github-actions[bot]
github-actionsBot
reviewed
Jul 8, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Summary: Clean, well-scoped change. The validation relaxation (value <= 0 → value < 0) is correct — when --minimum-expected-tests 0 is provided, the option's presence routes GetProcessExitCode() into the minimum-expected branch where _totalRanTests < 0 is always false, yielding ExitCode.Success and bypassing the zero-tests-policy check entirely. This is the correct design for an explicit "zero tests is acceptable" opt-in.
Tests thoroughly cover boundaries (negative, non-integer, zero, positive), both at the unit and acceptance integration level. Localization is properly done via .resx with XLF targets correctly marked needs-review-translation. Changelog updated. No public API surface change. No threading, security, or performance concerns.
@github-actions
github-actionsBot
commented
Jul 8, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9724
5 test methods graded across 3 files, all earning A. The PR cleanly extends unit and acceptance coverage for the new --minimum-expected-tests 0 behaviour at every layer (unit, integration, and acceptance). Tests are well-named, well-commented, and assertive throughout.
GradeTestNotes
A (90–100)mod ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsNegative_
ResultIsNotOk		Two assertions (exit code + output text) with a helpful inline comment; update aligns the expected string to the new validation wording.
A (90–100)new ExecutionTests.
Exec_
WhenMinimumExpectedTestsIsZeroAndNoTestsRun_
ResultIsOk		Well-named and commented; exit-code assertion is the complete observable verification for this acceptance scenario.
A (90–100)mod PlatformCommandLineProviderTests.
IsInvalid_
When_
MinimumExpectedTests_
Is_
Negative_
Or_
Not_
An_
Integer		Expanded DataRows (negative, float, empty, non-integer); dual assertions on validity flag and error message.
A (90–100)new PlatformCommandLineProviderTests.
IsValid_
When_
MinimumExpectedTests_
Is_
NonNegative_
Integer		Complements the invalid test; the IsValid check is the complete assertion for the happy path — no error message to also verify.
A (90–100)new TestApplicationResultTests.
GetProcessExitCodeAsync_
If_
MinimumExpectedTests_
Zero_
And_
No_
Tests_
Ran_
Returns_
Success		Well-commented with issue reference; exit-code equality check is exactly right for the zero-minimum scenario.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 92.2 AIC · ⌖ 13.6 AIC · ⊞ 9.5K · [◷]( · ◷)
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
b288da5
Reverts the ##9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in ##9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue ##7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jul 8, 2026
@Evangelink
Revert '--minimum-expected-tests 0' support (#7457)
f5c9072
Reverts the #9724 change that allowed the literal value
'--minimum-expected-tests 0'. Keeping '0' invalid restores an unambiguous
meaning for GetMinimumExpectedTests() == 0 ('option not set'), which avoids the
terminal-reporter verdict divergence tracked in #9744: with '--min 0' the exit
code was 0 (success) while the terminal still rendered a failed 'Zero tests ran'
verdict, because the shared verdict helpers could not distinguish 'unset' from
'explicit 0' without a cross-repo change to the vendored TerminalTestReporterOptions.
Issue #7457 item #2 ('--min 0 == --ignore-exit-code 8') remains served by the
existing '--ignore-exit-code 8'. The load-bearing behavior for the
'dotnet test --test-modules' orchestrator -- an explicit '--minimum-expected-tests N'
governs the zero-tests verdict (exit code 9, not 8) -- is unaffected and stays.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Evangelink