test: add edge case tests for AvoidOutRefTestMethodParametersAnalyzer (MSTEST0062)

[Amaury Levé (Evangelink)]

Fixes#9716

Adds three additive tests covering previously-untested paths in AvoidOutRefTestMethodParametersAnalyzer (MSTEST0062). No production code changes.

Test	Covers
WhenTestMethodHasDerivedTestMethodAttributeAndOutParam_Diagnostic	Analyzer fires + fixer removes out when a custom attribute derived from TestMethodAttribute is used; exercises the attr.AttributeClass.Inherits(...) branch
WhenTestMethodOutsideTestClassHasOutParam_Diagnostic	Analyzer fires even when the containing class lacks [TestClass] (no TestClass guard)
WhenTestMethodHasInParameter_NoDiagnostic	in parameters are not flagged — the analyzer checks only RefKind.Out/RefKind.Ref

Test status

Debug build: 0 warnings, 0 errors. MSTest.Analyzers.UnitTests pass on both net472 and net8.0 (7 pre-existing + 3 new).

[Copilot]

Pull request overview

This PR adds three additive unit tests to AvoidOutRefTestMethodParametersAnalyzerTests.cs to cover previously-untested code paths in AvoidOutRefTestMethodParametersAnalyzer (MSTEST0062). There are no production code changes. The new tests exercise the attr.AttributeClass.Inherits(...) branch (custom derived TestMethodAttribute), the absence of a [TestClass] guard, and the fact that in parameters are intentionally not flagged. I verified each test against the analyzer (only RefKind.Out/RefKind.Ref are flagged) and the fixer (which only strips out/ref keywords, leaving the s = ""; bodies valid).

Changes:

• Add WhenTestMethodHasDerivedTestMethodAttributeAndOutParam_Diagnostic covering the inheritance-based attribute detection path.
• Add WhenTestMethodOutsideTestClassHasOutParam_Diagnostic confirming the analyzer fires without a [TestClass] guard.
• Add WhenTestMethodHasInParameter_NoDiagnostic confirming in parameters are not flagged.

Show a summary per file

File	Description
test/UnitTests/MSTest.Analyzers.UnitTests/AvoidOutRefTestMethodParametersAnalyzerTests.cs	Adds three edge-case tests; correct and consistent with existing test structure, aside from a minor OutParam vs OutParameter naming inconsistency in two method names.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Result: LGTM — no issues found across all evaluated dimensions.

Dimension	Verdict
Correctness	✅ Clean
Test Isolation	✅ Clean
Assertions	✅ Clean
Flakiness Risk	✅ Clean
Consistency	✅ Clean
Data-Driven / Parameterization	✅ Clean

22 dimensions evaluated, 0 findings.

All three new tests correctly exercise previously-untested paths in the analyzer:

• Derived attribute: exercises Inherits() resolution at analyzer line 58.
• Outside TestClass: confirms the analyzer has no [TestClass] guard (by design — it keys only on [TestMethod]-derived attributes).
• in parameter: confirms the RefKind.Out or RefKind.Ref check correctly excludes RefKind.In.

Tests follow established naming, structure, and assertion patterns. No shared state, no flakiness vectors.

[Copilot]

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9731

Grade	Test	Notes
B (80–89)	new AvoidOutRefTestMethodParametersAnalyzerTests. WhenTestMethodHasDerivedTestMethodAttributeAndOutParameter_ Diagnostic	Body is ~41 lines (code + fixedCode pair) slightly over the ~30-line guideline — consider trimming the inline snippets for easier reading.
A (90–100)	new AvoidOutRefTestMethodParametersAnalyzerTests. WhenTestMethodHasInParameter_ NoDiagnostic	No issues found.
A (90–100)	new AvoidOutRefTestMethodParametersAnalyzerTests. WhenTestMethodOutsideTestClassHasOutParameter_ Diagnostic	No issues found.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 63.1 AIC · ⌖ 7.46 AIC · ⊞ 9.5K · [◷]( · ◷)