Add client-declared IsStateful capability to MTP

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

Summary

Relates to #6494.

Introduces a client-declared statefulness capability so a test framework can distinguish:

• a stateful client — one that persists an addressable set of test nodes for the whole session and keeps each node in its last-known state until explicitly updated (e.g. an IDE test explorer); from
• a stateless client — one that consumes updates as a stream and does not retain node state after the run (e.g. dotnet test).

This is the "stateless vs stateful" axis discussed in #6494: rather than having a framework infer the environment (parsing --server, sniffing client name/DesignMode, etc.), the client declares how it will consume results, and the framework branches on that. It cleanly answers scenarios like "is pre-enumerating theory rows worth it?" without coupling to transport or environment.

Design

• New experimental IClientCapabilities { bool IsStateful } surfaced via a new IClientInfo.Capabilities getter, so the C# shape mirrors the wire protocol's clientInfo / capabilities split 1:1.
• The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful, right next to the existing debuggerProvider.
• Backward compatible / opt-in: absent or false ⇒ stateless (current behavior). Console host defaults to stateless; server host builds the value from the client's declared capabilities.
• A framework reads it during a run via serviceProvider.GetClientInfo().Capabilities.IsStateful.

Notes / follow-ups

• The server only reads this; it becomes fully useful once real clients (VS Test Explorer, dotnet test) start sending it — a coordination point with the VS/SDK teams, exactly like debuggerProvider.
• Public API additions are all [TPEXP] (experimental), so no shipped-API break.
• Deliberately scoped to the stateless/stateful axis; the "not run" / explicit-tests discussion (How do I report a test that's not run - add ExplicitTestNodeStateProperty #2538) is intentionally out of scope.

Testing

• Microsoft.Testing.Platform builds clean across all TFMs (net8.0/net9.0/netstandard2.0, i.e. both the STJ and Jsonite serializer paths).
• Microsoft.Testing.Extensions.VSTestBridge.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests build clean.

[Copilot]

Pull request overview

This PR introduces a client-declared statefulness capability to Microsoft.Testing.Platform (MTP), relating to issue #6494. It lets a client declare (rather than the framework infer) whether it retains test-node state for the whole session (stateful, e.g. an IDE Test Explorer) or consumes updates as a stream (stateless, e.g. dotnet test). The flag travels through the server-mode initialize handshake under capabilities.testing.isStateful alongside the existing debuggerProvider, is exposed via a new experimental IClientCapabilities surfaced from IClientInfo.Capabilities, and is fully backward compatible (absent/false ⇒ stateless).

Changes:

• New experimental IClientCapabilities { bool IsStateful } ([TPEXP]) and a new IClientInfo.Capabilities getter, wired through ClientInfoService/ClientCapabilitiesService.
• Both server-mode deserializer paths (STJ and Jsonite) read the optional isStateful flag, defaulting to false; console host is stateless, server host reads the client's declared value.
• Protocol docs and acceptance/unit test call sites updated for the new field.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs	New experimental interface exposing IsStateful (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/ClientCapabilitiesService.cs	New internal record implementing the interface (missing UTF-8 BOM).
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs	Adds Capabilities getter to the client-info contract.
src/Platform/Microsoft.Testing.Platform/Services/ClientInfoService.cs	Threads IClientCapabilities through the record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs	Adds IsStateful to the ClientCapabilities wire record.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/JsonRpcMethods.cs	Adds the "isStateful" JSON key constant.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs	Jsonite path reads optional isStateful.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs	STJ path reads optional isStateful; lacks a unit test.
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.RequestExecution.cs	Builds capabilities from the client's declared value.
src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs	Console host declares stateless.
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt	Declares the three new [TPEXP] API members.
docs/mstest-runner-protocol/001-protocol-intro.md	Documents isStateful under capabilities.testing.
test/.../ObjectModel/RunSettingsPatcherTests.cs	Updates constructor calls (BOM stripped).
test/.../ObjectModel/ObjectModelConvertersTests.cs	Updates constructor calls (BOM stripped).
test/.../ServerMode/v1.0.0/ClientCapabilities.cs	Adds IsStateful (defaulted) to the test wire record.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean, well-scoped PR that adds the plumbing for a client-declared isStateful capability through the MTP initialize handshake. The design mirrors the existing debuggerProvider pattern and is properly experimental.

Verdict Table

#	Dimension	Verdict	Notes
1	Algorithmic Correctness	✅ LGTM	Both deserializers correctly handle the optional field with safe defaults
2	Threading & Concurrency	✅ N/A	No shared mutable state introduced; ConsoleTestHost field is static readonly, ServerTestHost field is set during single-threaded init
3	Public API & Binary Compat	⚠️ MODERATE	Adding Capabilities to shipped IClientInfo is source-breaking for external implementors — mitigated by [Experimental("TPEXP")] (see inline)
4	IPC Wire Compat	✅ LGTM	Optional field, absent → false, backward-compatible with older clients
5	Security & IPC Safety	✅ N/A	No new trust boundary or input validation concerns
6	Resource & Lifetime	✅ N/A	No disposable or long-lived resources introduced
7	Performance	✅ LGTM	Negligible overhead — one extra boolean in deserialization and one extra record field
8	Error Handling	✅ LGTM	Both deserializer paths handle missing/malformed isStateful gracefully
9	Cross-TFM	✅ LGTM	No TFM-conditional code; System.Text.Json path and Jsonite path both updated
10	Localization	✅ N/A	No user-facing strings
11	Test Completeness	⚠️ NIT	No test exercises isStateful: true end-to-end (see inline); acceptable since no behavioral branching exists yet
12	Naming & Conventions	✅ LGTM	IClientCapabilities, IsStateful, ClientCapabilitiesService follow repo conventions
13	Documentation	✅ LGTM	Protocol doc and XML doc comments are accurate and consistent
14	Code Structure	✅ LGTM	Minimal surface area; follows interface → internal record pattern
15	PublicAPI.Unshipped.txt	✅ LGTM	All 3 new API entries correctly declared with [TPEXP] prefix
16	init accessor ban	✅ LGTM	No init accessors
17	Scope Discipline	✅ LGTM	Single concern; follow-ups (consumer usage, client-side sending) tracked in #6494
18–22	Remaining dimensions	✅ N/A	Not applicable to this change

Key Observations

1. Wire compatibility ✅ — Both the STJ (Json.Deserializers.cs) and Jsonite (SerializerUtilities.Deserializers.cs) paths treat isStateful as optional, defaulting to false. Older clients that don't send the field will continue to work unchanged.

2. API evolution note — The new Capabilities property on IClientInfo is technically a source break for external implementors, but IClientInfo is [Experimental("TPEXP")] so this is expected. If IClientInfo is ever graduated, a default interface method or separate interface will be needed (see inline comment).

3. Pure plumbing — No code currently reads IsStateful to change behavior. The value flows from the wire → internal ClientCapabilities record → ClientCapabilitiesService → IClientInfo.Capabilities and stops there. This is intentional per the PR description; actual behavioral branching comes in a follow-up once clients start sending the flag.

Overall: well-designed, minimal, and backward-compatible. No blocking issues found.

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 5
• Review effort level: Medium

[github-actions]

🔍 Build Failure Analysis

Summary — The build fails with 21 RS0051 errors because new internal API symbols introduced in this PR are not declared in InternalAPI/InternalAPI.Unshipped.txt. The public API entries in PublicAPI/PublicAPI.Unshipped.txt were correctly updated for the IClientCapabilities interface, but the corresponding internal implementation types were missed.

Root cause: Missing internal API declarations in InternalAPI.Unshipped.txt

This project tracks both public and internal API surfaces. The PR introduces three groups of internal API changes that all need entries in src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

Group 1 — New ClientCapabilitiesService record (12 errors)

The entirely new internal sealed record ClientCapabilitiesService(bool IsStateful) : IClientCapabilities generates 12 undeclared symbols (constructor, properties, operators, Equals, GetHashCode, ToString, Clone, Deconstruct).

Group 2 — Modified ClientInfoService record (4 errors)

Adding the IClientCapabilities Capabilities parameter to the existing record changes the constructor signature and Deconstruct method, and adds the new Capabilities property with getter/init.

Group 3 — Modified ServerMode.ClientCapabilities record + JsonRpcStrings constant (5 errors)

Adding bool IsStateful to ClientCapabilities(bool DebuggerProvider, bool IsStateful) generates a new constructor, Deconstruct, and the IsStateful property. The new JsonRpcStrings.IsStateful constant also needs a declaration.

---

Proposed fix

Add the following lines to src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt:

const Microsoft.Testing.Platform.ServerMode.JsonRpcStrings.IsStateful = "isStateful" -> string!
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider, bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider, out bool IsStateful) -> void
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.get -> bool
Microsoft.Testing.Platform.ServerMode.ClientCapabilities.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.<Clone>$() -> Microsoft.Testing.Platform.Services.ClientCapabilitiesService!
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ClientCapabilitiesService(bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Deconstruct(out bool IsStateful) -> void
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? other) -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.get -> bool
Microsoft.Testing.Platform.Services.ClientCapabilitiesService.IsStateful.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.get -> Microsoft.Testing.Platform.Services.IClientCapabilities!
Microsoft.Testing.Platform.Services.ClientInfoService.Capabilities.init -> void
Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version, Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version, out Microsoft.Testing.Platform.Services.IClientCapabilities! Capabilities) -> void
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.Equals(object? obj) -> bool
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.GetHashCode() -> int
override Microsoft.Testing.Platform.Services.ClientCapabilitiesService.ToString() -> string!
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator !=(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool
static Microsoft.Testing.Platform.Services.ClientCapabilitiesService.operator ==(Microsoft.Testing.Platform.Services.ClientCapabilitiesService? left, Microsoft.Testing.Platform.Services.ClientCapabilitiesService? right) -> bool

Additionally, mark the old record signatures (now replaced) as removed:

*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.ClientCapabilities(bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.ServerMode.ClientCapabilities.Deconstruct(out bool DebuggerProvider) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.ClientInfoService(string! Id, string! Version) -> void
*REMOVED*Microsoft.Testing.Platform.Services.ClientInfoService.Deconstruct(out string! Id, out string! Version) -> void

Note: The *REMOVED* entries are not causing RS0051 errors today (RS0017 may be a warning in this project), but they are necessary for accurate API tracking since the old constructor/Deconstruct signatures no longer exist.

---

Build overview

Property	Value
Result	❌ FAILED
Duration	208.8s
MSBuild	18.8.0-preview-26302-115+f7b4c5716
Projects	49
Errors	22 (21 RS0051 + 1 meta Build failed)
Warnings	0
Failed projects	Microsoft.Testing.Platform.csproj → Build.proj → NonWindowsTests.slnf (cascade)

All MSBuild errors (21)

#	Code	File	Symbol
1	RS0051	JsonRpcMethods.cs:43	const JsonRpcStrings.IsStateful
2	RS0051	RpcMessages.cs:93	ClientCapabilities.ClientCapabilities(bool, bool)
3	RS0051	RpcMessages.cs:93	ClientCapabilities.Deconstruct(out bool, out bool)
4	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.get
5	RS0051	RpcMessages.cs:93	ClientCapabilities.IsStateful.init
6	RS0051	ClientCapabilitiesService.cs:6	ClientCapabilitiesService (type + 11 auto-generated members)
7–16	RS0051	ClientCapabilitiesService.cs:6	.ctor, .IsStateful, .Equals, .GetHashCode, .ToString, ==, !=, .<Clone>$, .Deconstruct
17	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.get
18	RS0051	ClientInfoService.cs:6	ClientInfoService.Capabilities.init
19	RS0051	ClientInfoService.cs:6	ClientInfoService.ClientInfoService(string!, string!, IClientCapabilities!)
20	RS0051	ClientInfoService.cs:6	ClientInfoService.Deconstruct(out string!, out string!, out IClientCapabilities!)
21	RS0051	ClientInfoService.cs:6	ClientInfoService(string!, string!, IClientCapabilities!)

---

_{🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit f66b623}

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · [◷]( · ◷)

[github-actions]

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · 141.2 AIC · ⌖ 9.08 AIC · ⊞ 7.3K · ◷

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 1
• Review effort level: Medium

[Copilot]

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 0 new
• Review effort level: Medium

[github-actions]

🧪 Test quality grade — PR #9789

9 test methods graded across 2 files (4 new, 5 modified). All tests pass the basics; the four new deserialization tests each make a single targeted boolean assertion — clean and focused, but could be strengthened by setting debuggerProvider: false to rule out field-aliasing false-passes.

Grade	Test	Notes
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithIsStatefulTrue_ JsonitePath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ ClientCapabilities_ WithoutIsStateful_ JsonitePath_ DefaultsToStateless	Single Assert.IsFalse covers the default-stateless path cleanly; no further issues.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithIsStatefulTrue_ StjPath_ SurfacesStatefulClient	Single Assert.IsTrue; setting debuggerProvider: false would guard against field-aliasing false-passes.
B (80–89)	new JsonTests. Deserialize_ InitializeRequest_ WithoutIsStateful_ StjPath_ DefaultsToStateless	Single Assert.IsFalse verifies default-stateless behavior; symmetric with the true-path test, no issues.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenNoRunSettingsProvided_ CreateRunSettingsWithResultsDirectoryElement	Single equality assertion on ResultsDirectory; mechanical constructor-arg update, test body is clean.
B (80–89)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsExists_ MergesParameters	Six thorough merge assertions; body is ~32 lines — consider splitting into focused preserve/update/add tests.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WhenRunSettingsDoesNotExist_ AddParameters	Four assertions fully verify both added parameters (name + value each); focused and clean.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsContainingResultsDirectory_ EntryIsNotOverridden	Two assertions verify non-override behavior and existing element preservation; clear and complete.
A (90–100)	mod RunSettingsPatcherTests. Patch_ WithRunSettingsProvidedButMissingResultsDirectory_ AddsElement	Two complementary assertions check added ResultsDirectory and preserved Canary element.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 96.6 AIC · ⌖ 9.1 AIC · ⊞ 9.5K · [◷]( · ◷)