Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861

Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged

Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom
dev/amauryleve/native-aot-trim-warnings-audit

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented Jul 11, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).

What changed (commit by commit)

  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).

  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.

  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.

  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.

  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.

Verification

  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).

Notes

@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings July 11, 2026 12:57
CopilotAI reviewed Jul 11, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.

Changes:

  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.

Review details

  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs Outdated
Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs Outdated
Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
github-code-quality[bot]
github-code-qualityBot found potential problems Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Fixed
@Evangelink
Amaury Levé (Evangelink) marked this pull request as ready for review July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI review requested due to automatic review settings July 11, 2026 20:29
CopilotAI reviewed Jul 11, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs Outdated
github-code-quality[bot]
github-code-qualityBot found potential problems Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI review requested due to automatic review settings July 13, 2026 08:33
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI review requested due to automatic review settings July 13, 2026 09:29
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low

CopilotAI review requested due to automatic review settings July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed the dev/amauryleve/native-aot-trim-warnings-audit branch from e356659 to 2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed the dev/amauryleve/native-aot-trim-warnings-audit branch from 2ec7947 to f95d892CompareJuly 13, 2026 09:42
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI review requested due to automatic review settings July 13, 2026 09:48
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low

@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI review requested due to automatic review settings July 13, 2026 11:34
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI review requested due to automatic review settings July 13, 2026 11:43
CopilotAI reviewed Jul 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs Outdated
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs Outdated
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI review requested due to automatic review settings July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed the dev/amauryleve/native-aot-trim-warnings-audit branch from 67783cc to 05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed the dev/amauryleve/native-aot-trim-warnings-audit branch from 05df2dd to 67ac175CompareJuly 13, 2026 13:24
@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #9861

GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)

CopilotAI reviewed Jul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@EvangelinkAmaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink) merged commit f1a3762 into mainJul 13, 2026
115 of 116 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/native-aot-trim-warnings-audit branch July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes
+1 more reviewer
@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state/needs-reviewAwaiting review from the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData - #9861
Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Jul 13, 2026
Merged
Native AOT trim-warning reduction: agnostic MSTestEngine, element-sourced MTP filter, and source-gen DynamicData#9861
Amaury Levé (Evangelink) merged 12 commits into
mainfrom 
dev/amauryleve/native-aot-trim-warnings-audit
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
Reduces trim/Native-AOT warnings on the native Microsoft.Testing.Platform (MTP) path for MSTest, working toward #9769. Each commit is an independent, self-contained step; the stack builds on the recently-merged reflection-free source generator and coexists with the [DynamicallyAccessedMembers] DynamicData fix from #9832 (this branch was rebased on top of it and integrates both).
What changed (commit by commit)
  1. Route the MTP path through an agnostic MSTestEngine — the native MTP framework (MSTestTestFramework) previously reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor, so the MTP layer called the VSTest layer to reach the platform-services engine. The neutral orchestration (telemetry, STA/apartment wrapper, engine calls) is extracted into a new adapter-level MSTestEngine. Both hosts now reach the engine with neutral inputs; the VSTest classes keep their public surface. No behavior change (the run-selected-test-cases path still materializes elements lazily after settings init).
  2. Evaluate the native MTP filter from UnitTestElement — the shared TestMethodFilter matched by materializing a vstest TestCase (ToTestCase → TestObject.SetPropertyValue/GetPropertyValue), which pulls in the trim/AOT-unsafe TestObject property converters (IL2026/IL2072) and the AdapterTestProperties custom TypeConverters. A dedicated MTP-only filter (MtpTestElementFilterProvider/MtpTestElementFilter) evaluates the filter straight from the neutral element model using hard-coded vstest property labels. Because it's a distinct type the MTP graph references exclusively, the trimmer drops the TestCase-materializing branch. This also cascaded to remove the System.Runtime.Serialization (DataContract) reachability.
  3. DynamicDataSourceResolver seam — DynamicDataOperations.GetData / DynamicDataAttribute.GetDisplayName resolved the source member / display-name method by reflection. New public-infrastructure registry (EditorBrowsable-Never, mirroring ReflectionMetadataHook) lets the source generator supply compile-time accessors; reflection becomes the fallback for reflection mode. Integrated with Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832: the reflection fallback keeps its [DynamicallyAccessedMembers(All)] annotations (flowed into the extracted helpers) so it stays trim-safe too — the source-gen path avoids reflection entirely, the fallback is DAM-safe.
  4. Emit DynamicData accessors from the reflection-free generator — the generator registers a reflection-free accessor only when a generated direct member access provably behaves exactly like the runtime reflection lookup in DynamicDataOperations; otherwise it emits no registration and the (DAM-safe) reflection fallback runs. Concretely it emits accessors for static property, field, and parameterless method sources (resolving the declaring type from the test method's containing type, honoring an explicit typeof(...) and DynamicDataSourceType, and a custom display-name method resolved declared-only). It deliberately falls back to reflection for: parameterized method sources (whose arguments need the reflection binder's widening/conversion semantics that an exact unbox cast can't replicate), void/by-ref/pointer-returning methods, ambiguous overloads, names that map to more than one member kind, and members that aren't accessible from the consuming assembly. The requested DynamicDataSourceType is part of the registration key, so an accessor generated for one attribute cannot satisfy a different attribute that names the same member with an incompatible source kind. This removes the DynamicDataOperations/DynamicDataAttribute IL2070/IL2075 warnings from AOT publish for the supported shapes.
  5. Runtime coverage — adds a [DynamicData] property-source test to the source-gen non-AOT acceptance asset so the generated accessor is exercised end-to-end.
Verification
  • Full build across all TFMs (incl. UWP): 0 warnings/errors.
  • Unit: TestFramework DynamicData (41), source generator (112), adapter, platform-services incl. filter — all pass.
  • Native MTP acceptance (packed, net11.0): filter/discovery/runsettings/test-run-parameters — all pass.
  • Native AOT trim analysis: TestObject.ConvertProperty*, AdapterTestProperties converters, System.Runtime.Serialization, TestMethodFilter, and DynamicDataOperations/DynamicDataAttribute warnings are all gone from the MTP path. Remaining MSTest-owned reflection warnings are TypeCache.InstantiateTestFilter / ProviderDiscovery (unrelated; next candidate before warnAsError can be enabled).
Notes
@Evangelink
Route MTP path through an agnostic MSTestEngine instead of the VSTest…
8f008fd
… MSTestDiscoverer/MSTestExecutor
The native Microsoft.Testing.Platform framework (MSTestTestFramework) previously
reused the VSTest-shaped MSTestDiscoverer/MSTestExecutor classes, so the MTP layer
called the VSTest layer which then called the platform-services engine.
Extract the neutral orchestration (telemetry lifetime, STA/apartment run wrapper,
and the calls into MSTestDiscovererHelpers/UnitTestDiscoverer/TestExecutionManager)
into a new platform-agnostic MSTestEngine at the adapter level. Every input is
neutral (IAdapterMessageLogger, ITestElementFilterProvider, IUnitTestElementSink,
ITestResultRecorder, run settings XML, test-run directory), so:
- MSTestDiscoverer/MSTestExecutor unwrap their IDiscoveryContext/IRunContext/
IFrameworkHandle into neutral inputs and delegate to MSTestEngine (keeping their
VSTest ITestDiscoverer/ITestExecutor surface + Cancel()).
- MSTestTestFramework builds the neutral inputs directly and drives MSTestEngine,
no longer referencing the VSTest MSTestDiscoverer/MSTestExecutor classes.
Behavior is preserved: the run-selected-test-cases path materializes elements
lazily (after settings initialization) so a settings error still bails out before
any conversion.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evaluate the native MTP test filter from UnitTestElement instead of a…
9247909
… vstest TestCase
On the native Microsoft.Testing.Platform path the shared TestMethodFilter matched
by materializing a vstest TestCase (UnitTestElement.GetOrCreateHostTestCase ->
ToTestCase -> TestObject.SetPropertyValue) and reading it back
(TestObject.GetPropertyValue). Those TestObject property converters use
TypeDescriptor.GetConverter, which is trim/AOT-unsafe (IL2026/IL2072, see #9769),
and referencing AdapterTestProperties rooted the custom string[]/KeyValuePair
TypeConverters (DataContract serialization).
Add a dedicated, MTP-only filter path:
- MSTestFilterExpression now implements IUnitTestElementFilterExpression so the
underlying vstest expression (which already matches purely from a
Func<string,object?> provider) can be evaluated without a TestCase.
- New MtpTestElementFilterProvider / MtpTestElementFilter evaluate the filter
straight from the neutral UnitTestElement using hard-coded vstest property labels
(FullyQualifiedName, Name, Id, ClassName, TestCategory, Priority) plus traits, so
the path references neither ToTestCase nor AdapterTestProperties.
- MSTestTestFramework wires the MTP discovery/run through this provider; the VSTest
TestElementFilterProvider/TestMethodFilter path is unchanged.
Because the two filters are distinct types and the MTP graph references only the
element-sourced one, the trimmer drops the TestCase-materializing branch. A
native-AOT trim analysis now shows zero TestObject.ConvertProperty*, zero custom
TypeConverter, zero TestMethodFilter and zero System.Runtime.Serialization warnings
on the MTP path (remaining IL20xx come from unrelated DynamicData/TypeCache
reflection).
Note: the vstest label for a test's display name is 'Name' (TestCaseProperties.
DisplayName.Label), which is what users write as 'Name=...'.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Add DynamicData source resolver seam so source-gen can supply data wi…
6f70cdc
…thout reflection
DynamicDataOperations.GetData and DynamicDataAttribute.GetDisplayName resolved the
data-source member / display-name method by reflecting over the declaring type
(Type.GetProperty/GetMethod/GetField, TypeInfo.GetDeclaredMethod), which the trimmer
cannot prove safe (IL2070/IL2075).
Introduce DynamicDataSourceResolver, a public infrastructure registry (EditorBrowsable
Never, mirroring ReflectionMetadataHook) that the MSTest source generator populates from
a module initializer with compile-time accessors:
- RegisterDataProvider(type, sourceName, Func<object?[],object?>)
- RegisterDisplayNameProvider(type, methodName, Func<MethodInfo,object?[]?,string?>)
DynamicDataOperations / GetDisplayName now consult the resolver first and only fall back
to reflection when no accessor is registered (reflection mode). The reflection fallback is
isolated into helpers annotated with justified UnconditionalSuppressMessage, since under
trimming / Native AOT the source-generated registration provides the data instead.
Adds TestFramework unit tests covering both the registered (resolver) and unregistered
(reflection fallback) paths for data and display names.
This is the framework-side seam; wiring the source generator to emit the registrations is
the following change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Emit DynamicData source accessors from the reflection-free source gen…
6db2a64
…erator
Completes the DynamicData source-gen story: the MSTest reflection-free generator now
resolves each [DynamicData] source at compile time and registers a delegate with
DynamicDataSourceResolver, so under trimming / Native AOT the data (and custom display
name) are read without reflecting over the declaring type. This backs the framework-side
suppressions added previously and removes the DynamicDataOperations / DynamicDataAttribute
IL2070/IL2075 trim warnings from AOT publish.
- TestClassModelBuilder resolves the [DynamicData] source member (property/method/field,
including an explicit declaring type and method-source arguments) and the optional
custom display-name method, degrading to no registration (runtime reflection fallback)
when the member cannot be resolved / is inaccessible / has the wrong shape.
- MetadataRegistryEmitter emits a DynamicDataSourceReflectionInfo per source with the
accessor delegate (property/field read, or method call casting the source arguments)
and the display-name accessor.
- RuntimeRegistrationEmitter's module initializer registers them via
DynamicDataSourceResolver.RegisterDataProvider / RegisterDisplayNameProvider.
Also broadens the display-name reflection fallback suppression to IL2070.
Adds source-generator unit tests for property/method-with-args/field/cross-type/custom
display-name/unresolvable sources and a compile check of the emitted registration.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Cover source-generated DynamicData at runtime in the source-gen non-A…
a4baf8f
…OT acceptance test
Adds a [DynamicData] property-source test method to the source-generated non-AOT asset so
the emitted DynamicDataSourceResolver accessor is exercised end-to-end: the two data rows
must discover, run, and pass through the source-generated data provider (not reflection).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
July 11, 2026 12:57
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Reduces Native AOT trimming warnings by separating native MTP orchestration/filtering from VSTest and generating reflection-free DynamicData accessors.
Changes:
  • Adds platform-agnostic MSTest discovery/execution orchestration and MTP-native filtering.
  • Adds a DynamicData accessor registry and source-generator support.
  • Expands unit and acceptance coverage.
Show a summary per file
FileDescription
test/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.csTests resolver registration and fallback.
test/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.csTests generated DynamicData accessors.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SourceGenerationNonAotTests.csExercises generated DynamicData at runtime.
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txtTracks the public resolver API.
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txtTracks internal resolver methods.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.csImplements the accessor registry.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.csPrefers generated data accessors.
src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataAttribute.csUses generated display-name accessors.
src/Analyzers/MSTest.SourceGeneration/Models/TestClassModel.csModels resolved DynamicData sources.
src/Analyzers/MSTest.SourceGeneration/Helpers/Constants.csAdds the resolver type name.
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.csResolves DynamicData source symbols.
src/Analyzers/MSTest.SourceGeneration/Generators/RuntimeRegistrationEmitter.csRegisters generated accessors.
src/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.csEmits accessor metadata and delegates.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestExecutor.csDelegates execution to MSTestEngine.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/MSTestDiscoverer.csDelegates discovery to MSTestEngine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.csFilters neutral MTP test elements directly.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestFramework.csRoutes native MTP through the neutral engine.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestFilterContext.csExposes element-based filter matching.
src/Adapter/MSTest.TestAdapter/MSTestEngine.csCentralizes neutral discovery and execution.
src/Adapter/MSTest.TestAdapter/InternalAPI/uwp/InternalAPI.Unshipped.txtTracks UWP engine APIs.
src/Adapter/MSTest.TestAdapter/InternalAPI/InternalAPI.Unshipped.txtTracks new adapter internals.
Review details
  • Files reviewed: 21/21 changed files
  • Comments generated: 12
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Adapter/MSTest.TestAdapter/MSTestEngine.cs
Outdated

Comment threadtest/UnitTests/TestFramework.UnitTests/Attributes/DynamicDataSourceResolverTests.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs
Comment threadsrc/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MtpTestElementFilter.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Fixed

@Evangelink
Amaury Levé (Evangelink)
marked this pull request as ready for review
July 11, 2026 20:07
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: DynamicData source-gen parity, identifier escaping…
bd1096e
…, BOMs, doc
Tighten the source generator's [DynamicData] resolution so a reflection-free
accessor is only emitted when it provably behaves like the runtime reflection
lookup in DynamicDataOperations; otherwise fall back to the (DAM-safe) reflection
path:
- Default the source/display-name declaring type to the test method's containing
type (matches methodInfo.DeclaringType), so inherited [DynamicData] resolves
under the base type instead of the leaf.
- Honor DynamicDataSourceType (explicit Property/Method/Field) and skip when the
name maps to more than one member kind across the hierarchy (AutoDetect kind
selection vs C# binding can diverge).
- Validate the property getter itself (static + accessible from the consuming
assembly), skip params/param-collection and by-ref source methods, and skip
ambiguous method overloads.
- Resolve display-name methods declared-only (GetDeclaredMethod), require
RefKind.None params, and reject ambiguous overloads.
- Guard declaring types to be closed + referenceable.
- Escape emitted member/method identifiers so reserved-keyword names (e.g.
@Class) compile.
Also: add UTF-8 BOM to the four new .cs files, and correct the
DynamicDataSourceResolver doc to describe the DAM-safe reflection fallback (#9832)
rather than claiming it is unsafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 11, 2026 20:29
CopilotAI
reviewed
Jul 11, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

github-code-quality[bot]
github-code-qualityBot
found potential problems
Jul 11, 2026
View reviewed changes
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 08:33
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:29
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:41
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
e356659 to
2ec7947CompareJuly 13, 2026 09:41
@Evangelink
Address PR review: skip source-gen accessor for parameterized Dynamic…
f95d892
…Data methods
MethodInfo.Invoke applies the default binder's primitive widening / conversions
(e.g. a boxed int 3 passed to a long parameter), which a generated direct call
with an exact unbox cast ((long)args[0]) cannot replicate and would throw
InvalidCastException. Only register reflection-free accessors for parameterless
static source methods; parameterized source methods keep the DAM-safe reflection
fallback. Drop the now-dead argument-cast emission and update the generator tests
accordingly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
2ec7947 to
f95d892CompareJuly 13, 2026 09:42
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 3
  • Review effort level: Medium
Comment threadsrc/TestFramework/TestFramework/Attributes/DataSource/DynamicDataSourceResolver.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadtest/UnitTests/MSTest.SourceGeneration.UnitTests/MSTestReflectionMetadataGeneratorTests.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 09:48
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 0 new
  • Review effort level: Low
@github-actions

This comment has been minimized.

Sign in to view
@Evangelink
Address PR review: key DynamicData registration by source type; skip …
f0cad4a
…void sources
- Include the requested DynamicDataSourceType in the DynamicDataSourceResolver
registration/lookup key so an accessor generated for one attribute cannot
satisfy a different attribute naming the same declaring type/member with an
incompatible source kind (e.g. a Property registration answering a Method
request instead of taking the reflection path that reports the missing method).
- Skip source-gen accessors for void / by-ref / pointer-returning methods (the
emitted (object?)Type.Source() would not compile); those keep the reflection
fallback as before.
- Simplify the resolver to carry only the member kind (methods are always
parameterless now) and thread the requested source type through the model,
emitted DynamicDataSourceReflectionInfo, and module-init registration.
- Tests: registration-key discrimination (framework), void-method and
source-kind-mismatch skips (generator). Update Internal/Public API baselines.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:34
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 4
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
CopilotAI
review requested due to automatic review settings
July 13, 2026 11:43
CopilotAI
reviewed
Jul 13, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 7
  • Review effort level: Medium
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

Comment threadsrc/Analyzers/MSTest.SourceGeneration/Generators/MetadataRegistryEmitter.cs
Outdated

@github-actions

This comment has been minimized.

Sign in to view
CopilotAI
review requested due to automatic review settings
July 13, 2026 13:24
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
67783cc to
05df2ddCompareJuly 13, 2026 13:24
@Evangelink
Address PR review: DynamicData source-gen edge cases (enum, member sh…
67ac175
…apes, exception parity)
- Skip registration when the attribute carries an undefined DynamicDataSourceType
cast value (e.g. (DynamicDataSourceType)99), which would emit uncompilable
DynamicDataSourceType.99; those keep the runtime fallback.
- Reject source/display-name members whose generated direct access would not
compile or box: static abstract/virtual (interface) members (CS8926) and
pointer / function-pointer / ref-like property, method-return, and field types.
- Preserve reflection exception semantics: property and method (and custom
display-name) accessors now wrap thrown user exceptions in
TargetInvocationException, matching PropertyInfo.GetValue / MethodInfo.Invoke;
field reads stay a plain expression (FieldInfo.GetValue does not wrap).
- Remove the now-unused testClassSymbol parameter from BuildMethod (IDE0060).
- Tests: undefined-enum skip, field-not-wrapped, and property/display-name
wrapping assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5797f94-192e-479e-a45f-2b2f8094c93b
@Evangelink
Amaury Levé (Evangelink)force-pushed
the
dev/amauryleve/native-aot-trim-warnings-audit
branch
from
05df2dd to
67ac175CompareJuly 13, 2026 13:24
@github-actions
github-actionsBot
commented
Jul 13, 2026

Copy link


Copy Markdown

Contributor
🧪 Test quality grade — PR #9861
GradeTestNotes
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DynamicDataRegistration_
Compiles		Single "no compile errors" assertion is meaningful but consider adding a containment check on expected generated output to verify the correct code was emitted.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForMethodSourceWithArguments		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForUndefinedSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
ForVoidMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
DoesNotEmitDynamicDataAccessor_
WhenSourceKindMismatchesExplicitSourceType		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForCrossTypeSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForFieldSource		Embedded userCode string pushes body past ~30 lines; the comment explaining no TargetInvocationException wrapping is useful — assertions are precise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForParameterlessMethodSource		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDynamicDataAccessor_
ForPropertySource		Embedded userCode string pushes body past ~30 lines; five precise containment assertions — consider extracting shared stubs into named constants.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
EmitsDisplayNameAccessor_
WhenCustomDisplayNameSpecified		Embedded userCode string pushes body past ~30 lines; consider extracting shared stubs into named constants to reduce visual noise.
B (80–89)new MSTestReflectionMetadataGeneratorTests.
Generator_
SkipsUnresolvableDynamicDataSource		Single containment assertion is meaningful; a complementary NotContain on any accessor emission would strengthen confidence.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataFallsBackToReflectionWhenProviderRegisteredForDifferentSourceType		Clear AAA; exception assertion confirms the reflection path is taken rather than the registered provider.
A (90–100)new DynamicDataSourceResolverTests.
GetDataPassesSourceArgumentsToRegisteredProvider		Captures provider arguments via closure and asserts their exact values — no issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDataUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameFallsBackToReflectionWhenNoProviderRegistered		No issues found.
A (90–100)new DynamicDataSourceResolverTests.
GetDisplayNameUsesRegisteredProviderInsteadOfReflection		No issues found.
A (90–100)mod SourceGenerationNonAotTests.
SourceGenerationNonAot_
BuildsAndRunsTests_
WithExitCodeZero		Well-structured integration test; exit-code, file-existence, and summary assertions all updated to reflect the new DynamicData test case.
This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with
/grade-tests.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
  • awmgmcpg
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
See Network Configuration for more information.
🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 75.6 AIC · ⌖ 7.18 AIC · ⊞ 8.9K · [◷]( · ◷)
CopilotAI
reviewed
Jul 13, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@EvangelinkAmaury Levé (Evangelink)
added
the 
state/needs-review
Awaiting review from the team.
label
Jul 13, 2026
@Evangelink
Amaury Levé (Evangelink)
merged commit f1a3762
into
mainJul 13, 2026

115 of 116 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/native-aot-trim-warnings-audit

branch
July 13, 2026 14:35
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@0101Petr Pokorny (0101)0101 approved these changes

+1 more reviewer

@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

state/needs-reviewAwaiting review from the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink@0101