Uh oh!
There was an error while loading. Please reload this page.
Add MSTEST0035 tests for custom RetryBaseAttribute subclasses - #9923
Merged
Conversation
Add four tests covering the Inherits() path for custom derived RetryBaseAttribute subclasses in UseRetryWithTestMethodAnalyzer: - WhenNonTestMethodHasCustomDerivedRetryAttribute_Diagnostic - WhenTestMethodHasCustomDerivedRetryAttribute_NoDiagnostic - WhenNonTestClassHasCustomDerivedRetryAttribute_Diagnostic - WhenTestClassHasCustomDerivedRetryAttribute_NoDiagnostic These tests confirm that user-defined RetryBaseAttribute subclasses are correctly handled by the Inherits() check in the analyzer. Fixes#9918 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: efa48d3b-7307-4c38-a477-815b089201c5
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MSTEST0035 coverage for custom RetryBaseAttribute subclasses.
Changes:
- Tests diagnostic behavior on non-test methods and classes.
- Tests no-diagnostic behavior on valid test methods and classes.
Show a summary per file
| File | Description |
|---|---|
test/UnitTests/MSTest.Analyzers.UnitTests/UseRetryWithTestMethodAnalyzerTests.cs | Adds four custom retry attribute analyzer tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Amaury Levé (Evangelink)
enabled auto-merge (squash)
July 14, 2026 07:50
Petr Pokorny (0101)
approved these changes
Jul 14, 2026
This comment has been minimized.
This comment has been minimized.
Regenerated via UpdateXlf. The last localized check-in added translations for 'GlobalTestFixtureShouldBeValidClassLayout' (fr) and 'SlowTestStillRunning' (ru) that XliffTasks rejects (placeholder mismatch), breaking the build with "xlf is out-of-date with resx". UpdateXlf resets those two units to state="new" so the build passes; they will be re-translated on the next localization pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4350f662-0e5d-4e05-b156-1ef619da3b9e
| - la classe doit être « public » | ||
| -La classe doit être marquée avec « [TestClass] » (ou un attribut dérivé). | ||
| - la classe ne doit pas être générique.</target> | ||
| <target state="new">Methods marked with '[GlobalTestInitialize]' or '[GlobalTestCleanup]' should follow the following layout to be valid: |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
🧪 Test quality grade — PR #9923
This advisory comment was generated automatically. Grades are heuristic Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Petr Pokorny (0101)
approved these changes
Jul 14, 2026
Amaury Levé (Evangelink)
disabled auto-merge
July 14, 2026 09:09
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9918
Goal
UseRetryWithTestMethodAnalyzer(MSTEST0035) usesInherits()to detect any subclass ofRetryBaseAttribute— not just the built-in[Retry]. The existing tests only exercised[Retry]directly. This PR adds four tests that exercise theInherits()path via a user-definedMyRetryAttribute : RetryBaseAttributesubclass.Coverage
[TestMethod])[TestClass])The test helper class uses
#pragma warning disable MSTESTEXPto suppress the experimental diagnostic onRetryResult/RetryContext, andprotected override(matching the base member visibility as seen from an external assembly).Validation
Built and ran
MSTest.Analyzers.UnitTestsfor bothnet472andnet8.0— all tests pass.