Uh oh!
There was an error while loading. Please reload this page.
Switch back to official Gallery APIs for Marketplace operations - #458
Closed
Winston Liu (winstliu) wants to merge 1 commit into
Closed
Switch back to official Gallery APIs for Marketplace operations#458Winston Liu (winstliu) wants to merge 1 commit into
Winston Liu (winstliu) wants to merge 1 commit into
Conversation
Contributor
Winston Liu (@winstliu), can you please merge latest master and update the package version to 0.21.0. Other changes looks good. |
Tarun Ramsinghani (tarunramsinghani)
requested changes
Feb 14, 2025
Tarun Ramsinghani (tarunramsinghani)
approved these changes
Feb 14, 2025
Nathan Hammond (nathanhammond)
commented
Feb 18, 2025
Contributor
Tarun Ramsinghani (@tarunramsinghani) since this change applies cleanly you can "Rebase and merge" if you wish to have a linear history. I just ran a build internally which cherry-picked this PR's commit and it did work. (I would really like to undo all of my hacks.) (Been a while since Winston Liu (@winstliu) was online; I assume OOO.) |
Winston Liu (winstliu)
commented
Feb 18, 2025
MemberAuthor
Yes, back now :). I'll try to address the comments this week. |
Winston Liu (winstliu)
commented
Mar 14, 2025
MemberAuthor
This was superseded by #494. Yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded APIs were introduced by #313, unfortunately without documenting how the APIs were broken.
In that PR, the publish APIs changed from accepting a content stream to accepting a base64-encoded version of the VSIX, which fails with
Extension package is malformed/corruptedonce the VSIX gets large enough (I assume the Marketplace has a max POST limit that is being exceeded).As it's been 5 years, I'm hoping that whatever was broken with azure-devops-node-api has been fixed since then, so I'm removing the hardcoding and going back to the official APIs, which continue to use a content stream and thus don't suffer from the corrupted issue.
Validation (on Azure DevOps, I don't have a Server instance to test on):
Fixes#187, fixes#339, fixes#362