Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Result bar chart - #10
Merged
Merged
Conversation
ilmarinen
commented
May 24, 2021
ilmarinen
requested review from
John (Juan) Lema (jlema) and Nicholas King (nking-1)May 24, 2021 20:20
Closed
Nicholas King (nking-1)
approved these changes
May 24, 2021
| num_beams=num_beams) | ||
| analyzed_sentences = perspective_api_client.analyze_sentences(generated_sentences) | ||
| return {"text_generation_results": analyzed_sentences} | ||
| analyzed_sentences_with_ids = list(map( |
There was a problem hiding this comment.
You might want to revert this when you merge your work with mine
Author
There was a problem hiding this comment.
I took a look at the id generation code. So I think that we should use id's given to us from the backend as these might come from a DB down the line. I modified the constructor of the model you added so that it just takes the server side id.
John (Juan) Lema (jlema)
approved these changes
May 24, 2021
Bump postcss based on Dependabot alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.