Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

Top p bug fix and nice out of the box defaults - #16

Merged
ilmarinen merged 3 commits into
devfrom
goode-defaults
May 25, 2021
Merged

Top p bug fix and nice out of the box defaults#16
ilmarinen merged 3 commits into
devfrom
goode-defaults

Conversation

@ilmarinen

@ilmarinenilmarinen commented May 25, 2021

Copy link
Copy Markdown
  1. Set temperature to be 1.0 as this prevents repetition in the generated text.
  2. Set top p to 0.8 and top k to 50 (based on experimentation and info from forums).
  3. Set max length to 70 (based on experimentation and info from forums. Nice compromise between speed and volume of text returned).

jlema
John (Juan) Lema (jlema) approved these changes May 25, 2021
View reviewed changes
Comment threadfrontend/components/TextGenerationControl.tsx Outdated
@ilmarinen
ilmarinen merged commit 56af419 into devMay 25, 2021
@jlemaJohn (Juan) Lema (jlema) added bug Something isn't working enhancement New feature or request labels May 25, 2021
@jlemaJohn (Juan) Lema (jlema) added this to the Eric Demo milestone May 25, 2021
@jlemaJohn (Juan) Lema (jlema) linked an issue May 25, 2021 that may be closed by this pull request
ValueError: top_p has to be a float > 0 and < 1, but is 0 #14
Closed
@ilmarinen
ilmarinen deleted the goode-defaults branch May 25, 2021 20:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@nking-1Nicholas King (nking-1)nking-1 approved these changes
@jlemaJohn (Juan) Lema (jlema)jlema approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

None yet

Milestone

Eric Demo

Development

Successfully merging this pull request may close these issues.

ValueError: top_p has to be a float > 0 and < 1, but is 0

3 participants

@ilmarinen@nking-1@jlema