Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

Layout fixes and input validation - #18

Merged
Nicholas King (nking-1) merged 4 commits into
devfrom
layout-fixes
May 25, 2021
Merged

Layout fixes and input validation#18
Nicholas King (nking-1) merged 4 commits into
devfrom
layout-fixes

Conversation

@nking-1

@nking-1Nicholas King (nking-1) commented May 25, 2021•
edited
Loading

Copy link
Copy Markdown
  • Fixes bar chart alignment
  • Adjusts layout of text generation form to match mocks
  • Adds input mask for number text fields to prevent NaN bug
  • Adds sort dropdowns
  • Fixes state bug by moving state into redux store

image

@jlemaJohn (Juan) Lema (jlema) added the enhancement New feature or request label May 25, 2021
@jlemaJohn (Juan) Lema (jlema) added this to the Eric Demo milestone May 25, 2021
@jlemaJohn (Juan) Lema (jlema) linked an issue May 25, 2021 that may be closed by this pull request
[interaction] [STRETCH] Filtering and sorting scores #9
Closed
@jlemaJohn (Juan) Lema (jlema) removed a link to an issue May 25, 2021
[interaction] [STRETCH] Filtering and sorting scores #9
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JingyaChenJingyaChen (JingyaChen)Awaiting requested review from JingyaChen
2 more reviewers
@ilmarinenilmarinenilmarinen approved these changes
@jlemaJohn (Juan) Lema (jlema)jlema approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

Eric Demo

Development

Successfully merging this pull request may close these issues.

3 participants

@nking-1@ilmarinen@jlema