Uh oh!
There was an error while loading. Please reload this page.
feat: Add type information to __assign(…) helper function - #83
Open
ExE Boss (ExE-Boss) wants to merge 1 commit into
Open
feat: Add type information to __assign(…) helper function#83ExE Boss (ExE-Boss) wants to merge 1 commit into
__assign(…) helper function#83ExE Boss (ExE-Boss) wants to merge 1 commit into
Conversation
ExE Boss (ExE-Boss)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)January 15, 2020 07:15
Member
Is there any particular reason you're looking to type these more strictly? |
ExE Boss (ExE-Boss)
commented
Jan 15, 2020
ContributorAuthor
Well, I’d like to eventually add type information to all TSLib helpers. |
Member
But is there a benefit? This code generally doesn't get consumed by users, and specifically this function has a hard time being accurately typed. |
ContributorAuthor
Well, this function acts as an alias for Arguably, it should be defined as: exportdeclarevar__assign: typeofObject.assign; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds typed overloads to
__assign, along with a TSDoc comment copied fromlib.es2015.core.d.ts#ObjectConstructor.assign(…).review?(Daniel Rosenwasser (@DanielRosenwasser))