chore: clean up TypeProvider attributes - #11418
Merged
Jorge Rangel (jorgerangel-msft) merged 4 commits intoJul 29, 2026
Merged
Conversation
commit: |
Contributor
|
No changes needing a change description found. |
Jorge Rangel (jorgerangel-msft)
force-pushed
the
cleanup-attributes
branch
from
July 28, 2026 16:30
a2ddbec to
caddb16
Compare
Copilot started reviewing on behalf of
Jorge Rangel (jorgerangel-msft)
July 28, 2026 16:31
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how TypeProvider handles attributes to better separate (1) attributes that can be cached/analyzed during reference-map analysis from (2) attributes that must be rebuilt at write time based on finalized generation decisions (notably the MRW context’s buildable attributes). It also simplifies the reference-map helper code and adjusts MRW tests to ensure back-compat attribute materialization happens before assertions.
Changes:
- Remove an unused name-matching helper in
ProviderReferenceMapAnalyzer.Helpers. - Rework
TypeProviderattribute write-time behavior by introducing a rebuild path (GetAttributesForWrite+RebuildAttributes) and a new back-compat hook (BuildAttributesForBackCompatibility). - Update
ModelReaderWriterContextDefinitionto apply last-contract buildable attribute restoration viaBuildAttributesForBackCompatibility, and update tests to callProcessTypeForBackCompatibility()before inspecting buildable attributes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/ReferenceMap/ProviderReferenceMapAnalyzer.Helpers.cs | Removes an unused private helper. |
| packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/TypeProvider.cs | Introduces write-time attribute rebuild support and a back-compat hook for attributes. |
| packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ModelReaderWriterContextDefinition.cs | Moves last-contract buildable attribute restoration into the new attribute back-compat hook and caches customized buildable types. |
| packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/Definitions/ModelReaderWriterContextDefinitionTests.cs | Ensures tests materialize back-compat state before asserting on buildable attributes. |
Jorge Rangel (jorgerangel-msft)
marked this pull request as ready for review
July 28, 2026 18:50
Jorge Rangel (jorgerangel-msft)
requested review from
JoshLove-msft,
Jose Arriaga Maldonado (joseharriaga),
Jesse Squire (jsquire) and
m-nash
as code owners
July 28, 2026 18:50
Jorge Rangel (jorgerangel-msft)
enabled auto-merge
July 28, 2026 20:11
…bute type Verify the attribute type is ModelReaderWriterBuildableAttribute before deriving a buildable identity so visitor-added type-valued attributes are preserved instead of overwriting the generated buildable attribute. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0922f61d-c8c9-4b4b-bfe6-e53ce3af4653
…ute via TestData Rework the coverage into an end-to-end back-compat scenario: the last contract declares a buildable attribute for the model, a visitor appends [TypeConverter(typeof(Model))], and the generated context is compared against a TestData expected file that shows both attributes preserved. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0922f61d-c8c9-4b4b-bfe6-e53ce3af4653
Remove the _customizedBuildableTypes cache so BuildAttributes recomputes the customized buildable types from the current customization view on every rebuild. Reset() recreates CustomCodeView, and the stale cache could otherwise keep suppressing types from a previously resolved view. Add a reset regression test that validates the generated context via TestData before and after Reset. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0922f61d-c8c9-4b4b-bfe6-e53ce3af4653
JoshLove-msft
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #11232