Remove global state from linter library - #1794
Merged
Nick Guerrera (nguerrera) merged 3 commits intoApr 5, 2023
Merged
Conversation
This caused issues depending on order things were run in a process. For example, it was causing tests to fail in test explorer when another libs tests ran first. **Breaking change**: This removes the ability to enable a rule from another library on a LibraryLinter.
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/1794/ |
Timothee Guerin (timotheeguerin)
approved these changes
Apr 5, 2023
Timothee Guerin (timotheeguerin)
left a comment
Member
There was a problem hiding this comment.
Simple enough to fix. I'll add a note on the built-in linter issue about this PR.
Should we update the docs also to say you cannot enable another linter rules anymore.
Closed
Contributor
Author
|
Thanks, yeah, I'll update the docs. |
Nick Guerrera (nguerrera)
force-pushed
the
no-global-linter
branch
from
April 5, 2023 19:28
1fc06d4 to
a6ffec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused issues depending on order things were run in a process. For example, it was causing tests to fail in test explorer when another libs tests ran first.
Breaking change: This removes the ability to enable a rule from another library on a LibraryLinter.