Generate Code from TypeSpec in VSCode - #5312
Merged
Merged
Conversation
Crystal YU (chunyu3)
marked this pull request as draft
December 10, 2024 01:48
Collaborator
Crystal YU (chunyu3)
force-pushed
the
generateSDK
branch
from
December 10, 2024 02:41
39789e2 to
3a9886c
Compare
Crystal YU (chunyu3)
requested a review
from Will Temple (witemple-msft)
as a code owner
January 9, 2025 16:00
Allen Zhang (allenjzhang)
suggested changes
Jan 9, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
|
You can try these changes here
|
Crystal YU (chunyu3)
force-pushed
the
generateSDK
branch
from
January 14, 2025 03:04
5d11232 to
94dcc8f
Compare
Allen Zhang (allenjzhang)
approved these changes
Jan 14, 2025
Allen Zhang (allenjzhang)
previously approved these changes
Jan 14, 2025
Allen Zhang (allenjzhang)
left a comment
Contributor
There was a problem hiding this comment.
As a future enhancement, if main.tsp is not found, should prompt them for an entry point tsp file. main.tsp does NOT need there.
Allen Zhang (allenjzhang)
dismissed stale reviews from Timothee Guerin (timotheeguerin) and themself
January 14, 2025 18:39
Tim OOF. Concern has been address.
Allen Zhang (allenjzhang)
approved these changes
Jan 14, 2025
Allen Zhang (allenjzhang)
left a comment
Contributor
There was a problem hiding this comment.
As a future enhancement, if main.tsp is not found, should prompt them for an entry point tsp file. main.tsp does NOT need there.
Contributor
|
Crystal YU (@chunyu3), Rodge Fu (@RodgeFu), I still see there are a few things should be cleaned up as you should purely rely on the TypeSpec config and build capabilities. Since this PR has been out long and isolated to VSCode packages, I will merge it for release. Let's make quick follow up on optmization asap. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5025
Fix #5463
Integrate Code Generation in VSCode extension