Uh oh!
There was an error while loading. Please reload this page.
http-client-java, clean generated java files in emitter - #8301
Merged
Weidong Xu (weidongxu-microsoft) merged 17 commits intoAug 29, 2025
Conversation
Weidong Xu (weidongxu-microsoft)force-pushed
the
http-client-java_clean-generate-java-files
branch
from
August 27, 2025 08:34
366e7d9 to
bb21c2bCompareContributor
No changes needing a change description found. |
Collaborator
You can try these changes here
|
Weidong Xu (weidongxu-microsoft) added a commit
to Azure/autorest.java
that referenced
this pull request
Aug 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to clean generated Java files in the http-client-java emitter to address issue #8278. The implementation adds file deletion capabilities that identify and remove previously generated Java files before writing new ones, with support for partial updates.
- Added
deleteGeneratedJavaFilesmethods toFileUtilclass that can identify and delete generated Java files based on code generation markers - Updated file writing methods to return
Pathinstead ofFilefor consistency - Integrated the deletion functionality into both fluent and DPG code generation workflows
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
FileUtil.java | Added methods to delete generated Java files with marker detection and updated writeToFile to return Path |
FileUtilTests.java | Added comprehensive tests for the new file deletion functionality |
TypeSpecFluentPlugin.java | Updated to use new Path-returning writeToFile method |
TypeSpecPlugin.java | Updated to use new Path-returning writeToFile method |
Main.java | Integrated file deletion logic into both fluent and DPG generation workflows |
PartialUpdateOpsImpl.java | Deleted generated file (demonstrates the cleanup functionality) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Weidong Xu (weidongxu-microsoft)force-pushed
the
http-client-java_clean-generate-java-files
branch
from
August 28, 2025 02:18
213fef8 to
d655baaCompareWeidong Xu (weidongxu-microsoft)force-pushed
the
http-client-java_clean-generate-java-files
branch
from
August 28, 2025 05:02
045fe1b to
5bbaed7CompareWeidong Xu (weidongxu-microsoft)
marked this pull request as ready for review
August 28, 2025 09:23
Weidong Xu (weidongxu-microsoft)
requested review from
Anu Thomas (anuchandy) and Srikanta (srnagar)
as code ownersAugust 28, 2025 09:23
Weidong Xu (weidongxu-microsoft)
requested review from
Xiaofei Cao (XiaofeiCao) and Haoling Dong (haolingdong-msft)
as code ownersAugust 28, 2025 09:23
Haoling Dong (haolingdong-msft)
commented
Aug 29, 2025
Member
Do we want to run autorest validation CI? |
ContributorAuthor
I think there is no need. The code change (Main, TypeSpecPlugin##) is for TypeSpec along. |
Uh oh!
There was an error while loading. Please reload this page.
Xiaofei Cao (XiaofeiCao)
approved these changes
Aug 29, 2025
Haoling Dong (haolingdong-msft)
approved these changes
Aug 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
Weidong Xu (weidongxu-microsoft)
deleted the
http-client-java_clean-generate-java-files
branch
August 29, 2025 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#8278
Limited to
srcfolder (as in practice I found without this limit, lot of IO on files innode_modules)Will do regen sync, and maybe more tests after release.